Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 0/3] extcon: usbc-tusb320: Initial TUSB320L support
To:     Yassine Oudjana <y.oudjana@protonmail.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Michael Auchter <michael.auchter@ni.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <07981514-563a-d64b-3fbf-ddf51e021f2c@samsung.com>
Date:   Thu, 30 Sep 2021 12:36:22 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20210925054407.944225-1-y.oudjana@protonmail.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20210925054535epcas1p45ad283474c848a9ec83febd44b4965b5@epcas1p4.samsung.com>
        <20210925054407.944225-1-y.oudjana@protonmail.com>
Precedence: bulk

On 9/25/21 2:45 PM, Yassine Oudjana wrote:
> The TUSB320L is a newer chip with additional features. It is close enough to TUSB320 so it works
> to some extent out-of-the-box, but for some reason it can start in UFP mode which is not desirable.
> 
> This series adds support for reset and mode setting for both chips, and does that while probing
> to ensure the chip starts with the default mode of following the PORT pin.
> 
> Changes since v4:
>  - Use ops struct instead of type enum.
> Changes since v3:
>  - Remove unused tusb_modes.
>  - Remove extra blank line.
> Changes since v2:
>  - Read state before setting default mode, then update it again after resetting.
>  - Remove mode tracing from irq handler
>  - Add a delay after reset to handle tSOFT_RESET
>  - Use a separate mode setting function for each of TUSB320 and TUSB320L.
> Changes since v1:
>  - Split first patch into two patches, one adding support for mode setting and reset on TUSB320,
>    and the other adding support for TUSB320L.
>  - Fix dt_binding_check warning:
>    ../Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml:15:6: [warning] wrong indentation: expected 6 but found 5 (indentation)
> 
> Yassine Oudjana (3):
>   extcon: usbc-tusb320: Add support for mode setting and reset
>   extcon: usbc-tusb320: Add support for TUSB320L
>   dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string
> 
>  .../bindings/extcon/extcon-usbc-tusb320.yaml  |   4 +-
>  drivers/extcon/extcon-usbc-tusb320.c          | 163 +++++++++++++++++-
>  2 files changed, 161 insertions(+), 6 deletions(-)
> 

Thanks for fixup. Applied them.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics