Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp27136pxb; Wed, 29 Sep 2021 23:47:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYVOzXKG2MB1xUXrF+K4fBL0r3N8b+yzhlWZiiODUZJEyMN/XU3NHJuEJlEVldOJvMoXDP X-Received: by 2002:a63:1547:: with SMTP id 7mr3552694pgv.122.1632984451833; Wed, 29 Sep 2021 23:47:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632984451; cv=none; d=google.com; s=arc-20160816; b=bD4fpaAUAHOKOZEEE1o8r3vk/RQpkWApuTwinUv3/jgk6QWl3fW19rbINWZ3isEHkG hLbFZQPj58I/p2eT6kLvLYM17MkbLkM+LI9GWttToJ0pca/SJRvOhypVO0yOwtQ+3xWO h6eU6cmXE27fPcJUsawNs3+C3ao3X3hqDKt5HOSSJAs2r1t8ZwwJYchGVTO9ro88jJtS zqgqOL02KLM2+l2I4nHHQVOAA7mXg7smJKYM5mDRBA6j32la5uM5CSZuM+DhNkpjiC5+ 1sMluUWmh5xAtSgfvgK7dQeKn4Tjc3UkACNqa/4amDTMMNMSEb+/1+PbDIh3h7qNFBpS BpQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sffS8F/ZTJ8Yh84J2Sk+jIsG3lFPWqGHT7VP9qHkDlE=; b=B4spDJlh/Q2/euj/vd1ZtdCLK5fhc4V74cNGb20wdnAdm3KXQcIbb/UKQnUtE7+gAq 3o4SoRDfY2/ck8/14s95FZcB59DFpKRgIaokcjR6hRakXfMaa4QCpuvpGVdt0GEBGzo5 Q/7vQO7Fx8rCrOvGBLLz9tU2JX9PYl/adVQwbVCdOZcWHjYeuDNwzStmsVnRkmX1PfO5 ZAiJcQPubXrFAei6HuQn76Xl2dk49QcYFGk10Cvi/EL3BDhVK8VonTGDsACDsa7G11Lj Ip3JNjhJFpG2B5w9Oq8PfndPwAhN2D/oeTI2pVLkQUNPEXYgvqhzENFzfCmd9AjGmpQf D59g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f15si2644961pln.345.2021.09.29.23.47.18; Wed, 29 Sep 2021 23:47:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348351AbhI3Grx (ORCPT + 99 others); Thu, 30 Sep 2021 02:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236162AbhI3Grx (ORCPT ); Thu, 30 Sep 2021 02:47:53 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07E89C06176A for ; Wed, 29 Sep 2021 23:46:11 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id A1C4D1F44723 From: Enric Balletbo i Serra To: Prashant Malani , linux-kernel@vger.kernel.org Cc: Benson Leung , Guenter Roeck , "Gustavo A. R. Silva" Subject: Re: [PATCH] platform/chrome: cros_ec_proto: Fix check_features ret val Date: Thu, 30 Sep 2021 08:45:55 +0200 Message-Id: <163298432635.3251747.6538622508689471214.b4-ty@collabora.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210916014632.2662612-1-pmalani@chromium.org> References: <20210916014632.2662612-1-pmalani@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Sep 2021 18:46:27 -0700, Prashant Malani wrote: > The kerneldoc for cros_ec_check_features() states that it returns 1 or 0 > depedending on whether a feature is supported or not, but it instead > returns a negative error number in one case, and a non-1 bitmask in > other cases. > > Since all call-sites only check for a 1 or 0 return value, update > the function to return boolean values. Applied, thanks! [1/1] platform/chrome: cros_ec_proto: Fix check_features ret val commit: d50497c4a05e73e76874fd0d4942036375a7ec0f Best regards, -- Enric Balletbo i Serra