Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] usb: hub: Mark root hubs on removable devices, as
 removable.
To:     Rajat Jain <rajatja@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Chris Chiu <chris.chiu@canonical.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
CC:     levinale@google.com, bleung@google.com, rajatxjain@gmail.com,
        jsbarnes@google.com, pmalani@google.com
References: <20210929224823.556943-1-rajatja@google.com>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <2df726b3-e5c4-0fbb-991d-e31e74348d52@suse.com>
Date:   Thu, 30 Sep 2021 10:02:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <20210929224823.556943-1-rajatja@google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HBfKJwtM6D60TUJ7NBBUoEeAWEDTELpEXX4W7uzFtJU/Y604GvKsOYA+ZbgW?=
 =?us-ascii?Q?ItPpyn1v1nACJfArdqmRQuUN85hc1M6ODxUowbgTNwM32uhXWcVASOBvIrAU?=
 =?us-ascii?Q?BD9otfeX3JBSZia3LhlUGc9VQT6bBdZ0Gs0AJtx4+SjoQmX8MaRffxxToLha?=
 =?us-ascii?Q?ZsxsHwXrwMaTEWjZexUMK6FV5tLxtzMwgDvkVpy9CF5vnoQflUBX2iMZdgR+?=
 =?us-ascii?Q?UHet48Pp38SEJnKJovVW6mdnfbYzNPMHN+VplyPCtY3B8oPhkY+TrGLJzZdW?=
 =?us-ascii?Q?A3Xb/hJ09dpEmjgxcgtem43fiNHVyHJ0BrRJrRGIWj0vR1VAytVUWZli5Ord?=
 =?us-ascii?Q?WXGlAv+XviCQ/uCJV78QFDoRKiNOJEiWQbExRhEkeANj0/Suq9QqBiRp4O3y?=
 =?us-ascii?Q?7gsfj+FCEt29ZJaVQwUUsCF+2zX0NWHLG1izktk6VL9odh5Uo3fChwmsncQy?=
 =?us-ascii?Q?dwFoVnuyCAkynEMOPUiLshL23OozjUQQWIytE8jurfRSusejIXR8hhPiD+yR?=
 =?us-ascii?Q?VH7yGtQs1Pg7AfbbcFYhKXOyXBo97vuvwYrYUSycMwf2cx7zMWMIHdIIyNXH?=
 =?us-ascii?Q?y/a0bWHr8jETKiY+j+Q6qpwNqFliZMnPawS3fd8ycvQjPQoK2osNjmS7atXC?=
 =?us-ascii?Q?kl9zAzVHzXoewy2tvjXmmUEBoQF+LR2rmzQcPQ8Z5YGEIOMURWA+W4PfYyZ6?=
 =?us-ascii?Q?P0Vr+LkJf4BdDTwAYfhdKL6RZwL2xjwB2XqcmBwjlk+Ucf9+NYKWNn/jbutj?=
 =?us-ascii?Q?2Tc5qosNzxSerogvu8pmoJrAuYUyTWHUcxuOgwBrWSrCX6H6Cy/L5CBggGP8?=
 =?us-ascii?Q?V7lsFsehRWtlR2Bjh9enPEj95K7uEK05IufZCcTi6XjV9xJqV6MX24nutlHL?=
 =?us-ascii?Q?UXkJUwLep8zjcMJySAkCE3uApGAS+RtFjFViAQl3oliVpFunpPk+7HV921Mp?=
 =?us-ascii?Q?m6FY2R1UyXvZ6pJPHEqStGLRGMv+nEOWQyPB++7CobAqqZEJPqDYnr9qHRxJ?=
 =?us-ascii?Q?oTpb5+C3D0ATSqXx5i+FU5FyltbziHDEZbbLkNmq5n8ft5CWnfmh6s75AbsY?=
 =?us-ascii?Q?s4byN91w5vXzlUMejcmZ3IbZuL8QCxUcb5MCprTsGgb3zZ0nVFcW6gDrQ0sC?=
 =?us-ascii?Q?BkXZLyP/kg5xrLKUqZGUoayySjY8MnonZODd9AXrKcyBCBKV8JEL6AJkDxi+?=
 =?us-ascii?Q?IUjm+bv0Wp2NYoX5zWTuZaQnvn8pnUBWma09NxBQr5vyPetcFFyKONUNFL5r?=
 =?us-ascii?Q?SlDSc3FlDCjpcq2XGocFc4xYjIZAoxA70AryaS3QGDpYE1bbSceKF+Jx9vnf?=
 =?us-ascii?Q?ZJscLlF5Wsr+jCkT2fIOZEQTbJSzsGEWw9JFL2bHgAspnjidlzGpy+oJvnei?=
 =?us-ascii?Q?UZYK4amkwHSTY+QQC4kOMDxDvDBo?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1216f5de-c8d9-457f-5869-08d983e89705
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 08:02:04.0905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y39rXANqnxAPj3jQr2uANdK4fNMB8HPgSmd25Wle/fS4nQgpltRsi/+udMPH8stGgrzX8AOdNfRCkTCCB4S9Mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2822
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 30.09.21 00:48, Rajat Jain wrote:
> Currently all usb root hubs are always marked as DEVICE_REMOVABLE_UNKNOWN
> unconditionally. Let us try to help the users to identify the removable
> root hubs, by checking the device on which the root hub sits. If the base
> (parent) device on which the root hub sits, is removable (e.g. on
> thunderbolt docks), then the roothub is also marked as removable.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>

Hi,

frankly, why? You are needlessly throwing away information about where
in the tree
removal can happen. This looks like a worsening, not an improvement to me.

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver