Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a6919b32-e789-7ed9-bab7-8235638e9c12@suse.cz>
Date:   Thu, 30 Sep 2021 10:22:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH] mm: remove useless lines in enable_cpucache()
Content-Language: en-US
To:     Shi Lei <shi_lei@massclouds.com>, cl@linux.com, penberg@kernel.org,
        rientjes@google.com, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20210930034845.2539-1-shi_lei@massclouds.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20210930034845.2539-1-shi_lei@massclouds.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/30/21 05:48, Shi Lei wrote:
> These lines are useless, so remove them.

I would clarify that they are useless after commit 10befea91b61 ("mm:
memcg/slab: use a single set of kmem_caches for all allocations")


> Signed-off-by: Shi Lei <shi_lei@massclouds.com>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  mm/slab.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index 4d826394ffcb..01775fe0e002 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3900,8 +3900,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp)
>  	if (err)
>  		goto end;
>  
> -	if (limit && shared && batchcount)
> -		goto skip_setup;
>  	/*
>  	 * The head array serves three purposes:
>  	 * - create a LIFO ordering, i.e. return objects that are cache-warm
> @@ -3944,7 +3942,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp)
>  		limit = 32;
>  #endif
>  	batchcount = (limit + 1) / 2;
> -skip_setup:
>  	err = do_tune_cpucache(cachep, limit, batchcount, shared, gfp);
>  end:
>  	if (err)
>