Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Sep 2021 12:25:45 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Dawid Esterhuizen <desterhuizen@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Statements should start on a tabstop
Message-ID: <20210930092435.GN2048@kadam>
References: <YVTN5i8qwjlGwOPp@kkobus.whirley.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YVTN5i8qwjlGwOPp@kkobus.whirley.local>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RTWJmzFp8tbwl70wXbLKnnOoyil3yWLSKO9bCeJcLjbKBZuCyk+suVWahO0d?=
 =?us-ascii?Q?EkvdXeWJKu9djtnh92jHKh5CdQ+yvZnWS+llraFzAEDirB0YtzZfK35zIxOo?=
 =?us-ascii?Q?3SLyXtL9/5HJZd/Q8UFPxa0E9+5dyLxZ8ZndRzpWZDCUEtKjKnVgNYx/Nhtn?=
 =?us-ascii?Q?ANCchX7Zh9O2PSkLLlpNG1xK4qo48GZKrEgrcf776ki2TvT12boMybbKjVTw?=
 =?us-ascii?Q?6dOxNoPXDS2Ntxr3PmwPBbHkQo4EhMAPspW5JiiWD8PXeibp5QgbIF/juxtH?=
 =?us-ascii?Q?QyQqmXmwE6yVaqUNHq22zNplsUplPyOoyD4XmU8Nksqk+AUorbY9Bv0mxwhL?=
 =?us-ascii?Q?Y1Nq4+TNuzqS54Omh1S57UiowHA92LTHDeu6AoqLoy0b+cKQmz0oISj0hQlk?=
 =?us-ascii?Q?XTLv85pSoPqc+cRomdn3p4pwDPXXK9f7aF3dDCIdjQjTkYsHvIWH7R8H/aYy?=
 =?us-ascii?Q?maSpkEiu1wEjLs13QzxlywapeOtlfdh+WdR0qykE70OrKh5grAnyDmmXmzp8?=
 =?us-ascii?Q?42td/lJGgwlbHir5mwxLJJMUTHOvWWkbVRgXkAzMwUcatvtdVpJiwdZZ1cHI?=
 =?us-ascii?Q?CmbjAaHP+ZWL0Av79MyCO6g8zdDQZnNXMBe6vZIKIX2OYFOxsbvR0Ey1cJSJ?=
 =?us-ascii?Q?0aRhCZ3AkofDhoz8+zkGEzXhyoKQiXgE4bf8iAKYLJL+rVkfhm/1iWxpnIat?=
 =?us-ascii?Q?eKBMeyDJ5RL2DK3f1ndmMIZa/6a/eZ4wDsZFJMXDUShDPyRyZ5Oa+TAFKxPb?=
 =?us-ascii?Q?9ueXSnOZHVGn7S8nVjWnn5xRDHZL+g9W28eBAe/QiUX2Wd5a2gVRutVjqCRT?=
 =?us-ascii?Q?zh1lyiIx6SyBonbyJFQfjnqSa50EnQYEA8HLj8StKaC70QLtLFWWb142ejQM?=
 =?us-ascii?Q?Qre9OasvipPjrAcc+6+3u9YaYKxkzDi1t9PjgdtPAYbXrCEoeGda/q34JB9M?=
 =?us-ascii?Q?UUpf8XAWoK5J3CPyBzO0r3oeKlGtuXg8KQVXgnHG0eCIsk4Zx6LhUPSo28jS?=
 =?us-ascii?Q?SR7Uy2Uw57+uIwkpYt1hJEw3AGO/Yvtbd488ZttfJ9S7hKUj+S8AjOuCp4QB?=
 =?us-ascii?Q?lTkl3jOtX31aZR4X+mdUz71EyLJaD1ivtuDZRT0opgl/0MSYUKTNqoXrDQbp?=
 =?us-ascii?Q?idhSLsEcF2WtfEigwupbH+8hDyViNvvU77hffbF0R1R0RzBe2jyXqRuUDWQD?=
 =?us-ascii?Q?KQVVoXSyfIWCeh1YO66nXRtCxCKJUx/Z1UHgaiq8yrPXPs7unS1K5yHmqXs9?=
 =?us-ascii?Q?5NcwrXETZX7QlWmXib+OLrcWutb3YfDPErGniNkK2D128tk+Nm9UJiqodYCG?=
 =?us-ascii?Q?B3JjmQQT45LEhShheHWoa9uB?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4db3bcfb-d8c1-4343-32f1-08d983f45058
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 09:25:59.8379
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a20J3TomBLTRVmDY9B1WdsfbkTfPziZWHmsI/E+2QRe1k/2npPVdhu+9SAng5L679TKigJNYCRvnmE1rj9EwL6vOe2P6bzXXRG5nBV0dz8c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1248
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10122 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0
 adultscore=0 bulkscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109300057
X-Proofpoint-GUID: ViFAe8r3OMNCExhjCH-ADKF0mRfVNs_y
X-Proofpoint-ORIG-GUID: ViFAe8r3OMNCExhjCH-ADKF0mRfVNs_y
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 29, 2021 at 10:34:46PM +0200, Dawid Esterhuizen wrote:
> This path fixes four checkpatch.pl warnings:
> 
> Statements should start on a tabstop
> 
> Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_xmit.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
> index 2e6afc7bb0a1..bc1287cc853e 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.h
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.h
> @@ -182,11 +182,11 @@ struct sta_xmit_priv {
>  };
>  
>  struct	hw_txqueue {
> -	/*volatile*/ sint	head;
> -	/*volatile*/ sint	tail;
> -	/*volatile*/ sint	free_sz;	/*in units of 64 bytes*/
> -	/*volatile*/ sint      free_cmdsz;
> -	/*volatile*/ sint	 txsz[8];
> +  /*volatile*/ sint head;
> +  /*volatile*/ sint tail;
> +  /*volatile*/ sint free_sz;	/*in units of 64 bytes*/
> +  /*volatile*/ sint free_cmdsz;
> +  /*volatile*/ sint txsz[8];

These "volatile" comments are wrong and pointless.  Just delete them
instead.

regards,
dan carpenter