Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] r8152: stop submitting rx for -EPROTO
To:     Jason-ch Chen <jason-ch.chen@mediatek.com>,
        Hayes Wang <hayeswang@realtek.com>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "Project_Global_Chrome_Upstream_Group@mediatek.com" 
        <Project_Global_Chrome_Upstream_Group@mediatek.com>,
        "hsinyi@google.com" <hsinyi@google.com>,
        nic_swsd <nic_swsd@realtek.com>
References: <20210929051812.3107-1-jason-ch.chen@mediatek.com>
 <cbd1591fc03f480c9f08cc55585e2e35@realtek.com>
 <4c2ad5e4a9747c59a55d92a8fa0c95df5821188f.camel@mediatek.com>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <274ec862-86cf-9d83-7ea7-5786e30ca4a7@suse.com>
Date:   Thu, 30 Sep 2021 11:30:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <4c2ad5e4a9747c59a55d92a8fa0c95df5821188f.camel@mediatek.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rhRK09H2EKEGyIUT8VhgEz2Vv1IYMSeBEVoZbYubnKMGv6eIDVIURGo1Zin2?=
 =?us-ascii?Q?xxGSbO/MR2+N/PDPi/TUzE4fkV3nyfsttcG66mkAIRBzgaHo6HFoAnm1xQ6l?=
 =?us-ascii?Q?s7g6RTfXoE2OFI+N+i7J9/g6G95Xsoqutnf3tHOmwNTMku/ekOPRBdts+Pte?=
 =?us-ascii?Q?RDbMQ+47lKlzeypiQWYoJDpaCf5sszN4D4SoZ2mhVi5rEJ0YqqFc9tBwboA9?=
 =?us-ascii?Q?0uqf2udfJSW3r1qUqYF4Y+zi+yrXZZPr2D3xAQ1+k93BzortBxlF4bekUIHL?=
 =?us-ascii?Q?c+8zJDXT1+gDOL9ACvtkpPafMt2KPPq+qyLxhGVtJAQOKrh1fzAEQzN3qnmS?=
 =?us-ascii?Q?40+ulOVRPznxQAt7nJX+AXkiwrwx/ZBeYXnPviAYGfKqVywK2ejdJlvXswAH?=
 =?us-ascii?Q?sAZgP+m2fA/6Y+oK/22U2qrHLeeIZYkYjnY5OpooGZncQ1QipKlu01iuLN5y?=
 =?us-ascii?Q?5w6tIEgaPY5xXm0uEJSJHBgRb74SZWQ+zqKFYAhNIxxfL6GUKKfFdDXXpAh0?=
 =?us-ascii?Q?1bE9sVywspEweIJLvGgKlazpTS97ZO0HgLDs9LY0xiZcA56gbtU5cGamKbxH?=
 =?us-ascii?Q?snyJaHqx70HSNKld527bm4uA5yLCrvzrrgLO57GJ46dTxZxCgShwz9QqB089?=
 =?us-ascii?Q?n6fMBSEu7cpFIABowE8gdQRxLW3Ubad2R/iI5ea2Nue42Ps6Pv8XmbFmB3D6?=
 =?us-ascii?Q?Zf8CB9U53ooxFi7D/H9WGchxPO9AcaRbrPCdm/kk6Hz8lAleHlcV6YFHOueT?=
 =?us-ascii?Q?xS9diz0TtrRGIJ0Gwvv0DEz2PXgM8MfhAP3nROJM42rrY9v1ao3q5+uN/x2T?=
 =?us-ascii?Q?fGShyfMcIB399l3mI4FJu8s40gt2J32otHZt/bSEu40TiM/tF/N87/5cWz10?=
 =?us-ascii?Q?bqONN/5lfdpmee6llS5uBXJk52HYKPo8x5jbqAqdsUzwdsuFXXuQ5JbHInBx?=
 =?us-ascii?Q?Xg0zuILr4JVAykR1+Iw2XxqsxI+8oiOobBnkBqcTce+viWyaIvDojsOfrUqC?=
 =?us-ascii?Q?tabvvXpuZbWvkN7DpgLTtFTBEUOspP1HMac/E34mnWVt/yvy+czs2dSQgVNJ?=
 =?us-ascii?Q?jy4hDMMfQggqZVJt0y+7rlgWnD2KvkHUD8osR0q6mRjbGcmEeL4Qk5aSrwHr?=
 =?us-ascii?Q?RnwQ8ZiEwh8MX7gvOVncJ0YgVEb3TSpsTH2k+aLH0WoZT5/cqEqWcNbA9CUg?=
 =?us-ascii?Q?6Yo8wAYtozzTSKGiGqOOks8Z4KP47NUi4zAewO2Xm9k8Tjdr9KTv62rh3Dcz?=
 =?us-ascii?Q?DtIKzQEj4Vm9xYC5uqOuay64etyKypfA5RGRoWZggDLo01hH9gvhVgyKrWKy?=
 =?us-ascii?Q?DfBuSP4xifmUw7/x0chkJjTSRo6wVat1Z94Yat0WALzrTVQZfnqmmL9Qt0P9?=
 =?us-ascii?Q?cBdQ8nz11LpAbzA52Habu1gfDyUT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c382a353-cc03-4863-4f7e-08d983f4eb88
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 09:30:19.8312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4oowC6GyiL0nfFj2LEToTxKqklRfTHDMR2Gon4r/D6i/pd5tUz4nV4Kn1ggU4AL/i/TrSUKe6r9LfGMue62U7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4137
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29.09.21 11:52, Jason-ch Chen wrote:
> On Wed, 2021-09-29 at 08:14 +0000, Hayes Wang wrote:
>>
> Hi Hayes,
>
> Sometimes Rx submits rapidly and the USB kernel driver of opensource
> cannot receive any disconnect event due to CPU heavy loading, which
> finally causes a system crash.
> Do you have any suggestions to modify the r8152 driver to prevent this
> situation happened?
>
> Regards,
> Jason
>
Hi,

Hayes proposed a solution. Basically you solve this the way HID or WDM do i=
t
delaying resubmission. This makes me wonder whether this problem is specifi=
c
to any driver. If it is not, as I would argue, do we have a deficiency
in our API?

Should we have something like: usb_submit_delayed_urb() ?

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver