Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp152165pxb; Thu, 30 Sep 2021 03:13:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybORRzL0K3c66wrvF8r8gCNqC/Dg2FLx+MjzQLkLmJ5RM6XFknEIk9VhwhPp62C2aSj1Q5 X-Received: by 2002:a62:7ec4:0:b0:44b:bc4b:844b with SMTP id z187-20020a627ec4000000b0044bbc4b844bmr4859376pfc.48.1632996782991; Thu, 30 Sep 2021 03:13:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632996782; cv=none; d=google.com; s=arc-20160816; b=AIhd1NR9S2CiGUmiCAaZwE2sMpt5g7u7Q7O0WNAb+ffO1tJxrG69xQ24TEDsMpe6dG 7zPoU5Wn2p3EQ0PW44dnbVJ1fID1qIlxtNMqTtnl2cheSGhPaQypdc1VN12rsIm12Ujr EUiqRuqDK9rMpcM/q9+DC+dNmQOjF0jFPZZxsTw0VGbCtQwvsObTBNBfKMRQuF04onOH VH0xLrnN4HIPpD4TTy882xrJRxeujV+wGzFyVwoacRLESluhLPr7Jqgeu/CaWjDRwJAd yyX2Ai3Pzk7DfkWxhyzsh1q76v9FZ8ljplyNj1AbotroOkmpq1LukgXGq9Me0RWFd8/t fcEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:dmarc-filter :sender:dkim-signature; bh=E1AIzzsSn5azqCzofW1zjFrXokehguwfbLDDQiqkgO8=; b=mc9e01kItidQMRdFESZ7TWnHCaubr89pLPGQASEqJM6FQi/mYBIiyUegVsq3lUTpaB SiDDVV2Oe5ISMo4nOTvoDMm59/oGFryYG47W8RVjDixZr+4fK3XfCea2b+JvNZRbHFEC 4hjxgM+nKUPHHJiYAN1rLryZnuAGLKHDr56LL3Mt1Hzygb2AyhW+DnpnsADgIho4GJFJ BGj8rYhDSOH0LcdNTVVXesxs8nWX1GIjb0ckxumEHZNSTvVxbKRyKHX2xkoToU7rH3R/ O43toSI/R/Jlx7jpsvCT2Nsmxmb2hJS4HSHq/VMuVu732zsfcU9sXtxkmhcw1J+IleK/ 7RXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=cwAVT6xu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x1si3345987pfo.218.2021.09.30.03.12.50; Thu, 30 Sep 2021 03:13:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=cwAVT6xu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349789AbhI3KLX (ORCPT + 99 others); Thu, 30 Sep 2021 06:11:23 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:16368 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349743AbhI3KLQ (ORCPT ); Thu, 30 Sep 2021 06:11:16 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632996574; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=E1AIzzsSn5azqCzofW1zjFrXokehguwfbLDDQiqkgO8=; b=cwAVT6xuw3XaejVC65JQnIG3ij6eBwOg1b114luAhrNkp4XqOaFpVfbnCXxduvu5i9fgMADh z7G4x14p82Z8lWljn00BJG3Svn7xUS2cKqkLMl0RZthQqJLYltTZGbU6qek2h6oA7hQX/iZP /j8zmuMgdFIXWw4+ZyLi5kJdBf4= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 61558cdd47d64efb6df8cf3b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 30 Sep 2021 10:09:33 GMT Sender: pkondeti=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8C51AC4360C; Thu, 30 Sep 2021 10:09:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from codeaurora.org (unknown [202.46.22.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pkondeti) by smtp.codeaurora.org (Postfix) with ESMTPSA id 674C5C4338F; Thu, 30 Sep 2021 10:09:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 674C5C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Pavankumar Kondeti To: linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, "Rafael J . Wysocki" , Rajendra Nayak , Pavankumar Kondeti , Viresh Kumar , Nishanth Menon , Stephen Boyd Subject: [PATCH] opp: Fix required-opps phandle array count check Date: Thu, 30 Sep 2021 15:39:08 +0530 Message-Id: <1632996548-11647-1-git-send-email-pkondeti@codeaurora.org> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 'required-opps' property is optional. So of_count_phandle_with_args() can return -ENOENT when queried for required-opps. Handle this case. Signed-off-by: Pavankumar Kondeti --- drivers/opp/of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 2a97c65..5437085 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -170,7 +170,7 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table, } count = of_count_phandle_with_args(np, "required-opps", NULL); - if (!count) + if (count <= 0) goto put_np; required_opp_tables = kcalloc(count, sizeof(*required_opp_tables), -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.