Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp153959pxb; Thu, 30 Sep 2021 03:15:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIP3Z3qmObTtOS7cQexIEB3e35xzFYDKhisw1rFGHrxOoQ5EkOt1zvAsqELWQjFpmHNi8z X-Received: by 2002:a63:af4b:: with SMTP id s11mr4186743pgo.185.1632996924266; Thu, 30 Sep 2021 03:15:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632996924; cv=none; d=google.com; s=arc-20160816; b=Bwt51+xjgttC8c274b7SbvsV6Lv2JOa1rY9MP+cuTFZCFHJLcuaysblTjUcVGAmgE8 Ye2WrIKxRnCN/ZCo+U6rPwt0bpeRa4p4pwCgFAV+omFybOuyn9tJqOF8gEXunWFL27HY RMvEAcmZCKQJEh3NLjwFi9SbP5Puk4UEDJ8OvqBawf1VmtqrxrSE0HKLpIOzpGShlU5U yrnOzCMTyI3UuHn8V114b3FDi5iEGm6TJ0PymFeCYXh1yOseYb3P46CSpRaguADS33qd Qa6hUsLbGFkF+2+Op1UlwUQ14h4d47EDHL85sWFTIOOM+qOX4IA8mDQobZhJ0IUkBsZs Tx+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=di22f+1qtT1rJlDsDU5gv52bfkIzi99/0/f5YELZTOw=; b=C6y9siI2lV9HbqRWQxpQY6UJ5wQKJgzCPR8/oiNY4v51KUk+0jIwLgj9pruQRQuxxA mn9scpTsDFN2Emm2iHIH+RW2iCVv2x24M/PSQUcL91zmnN+udMhVjxSP41deJxfvGFT6 Sxuf2emfqiQ5ibVXpYaaLHnPVc9Kl9Vg/3pS8MOrN0lYHBtGd0zlTVH6q2ccMYHB8Xf0 lmVX4QMlbtZHU3zespHZs4D5dA2/AgtAbMovntl3ZwbJrQ0/3303Y7jrm5j9FKyZps7B Bco2qSDKH9whQfLeTewTlBJJymVRiU3aOCprgh1WsasVVQssWmwngz92QlyBntC2a/iv SP0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@monstr-eu.20210112.gappssmtp.com header.s=20210112 header.b=ppyHc1xu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p37si2940973pgb.550.2021.09.30.03.15.11; Thu, 30 Sep 2021 03:15:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@monstr-eu.20210112.gappssmtp.com header.s=20210112 header.b=ppyHc1xu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349837AbhI3KOz (ORCPT + 99 others); Thu, 30 Sep 2021 06:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349811AbhI3KOy (ORCPT ); Thu, 30 Sep 2021 06:14:54 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 564B2C06176D for ; Thu, 30 Sep 2021 03:13:11 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id g7so19954239edv.1 for ; Thu, 30 Sep 2021 03:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=di22f+1qtT1rJlDsDU5gv52bfkIzi99/0/f5YELZTOw=; b=ppyHc1xu2ZjQ/kTBT2c/n07AkMuYUtXvdy0s7QXVTxECAFMjweuXUCK7xVE+xwaX0C 6o8ZrsH3/9Aynnbf9fMbiY9C8vrkZKxMS2dYyF99LaMNbMDmo+1MshkoCVBu64oPE6ga zFJAQfJwiWTcCZsmLrqej5kKbY2vHfu7puIu4/K01CNJFBuzzGgBrIqsTKFJtWl1D8WY Zs33o3bUzbg+B6tae1aWxdGoSxVf8Jp54BcOj5rIAhOIm93rKhQ0OmZemre71DGprt/y YIumJdsINVkRuayzKbrt7Bx5i0AKwik6J4Ki1n3eaMHv8bBS9zWjaa6znfhzuZJX3poI GbLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=di22f+1qtT1rJlDsDU5gv52bfkIzi99/0/f5YELZTOw=; b=2JidXOeysvWe/xRk8DMfs+jTBKJjTBizBhochvpB9G7fSxvS2sFRhftKhCNJTlmvtH aCx8sf7jyCARA1eRrWyg1HfUEDE1KkM4aCCIXxd8zAux3Ts3COs+CX4nUJ/aBhnwnAWh aMVkgrJUx5r4LAdwqU3yMlCasoJIMAHRg+LMsFimBIAtggumqROq5rJgyM4zHEum9GSV QBcQ6dvbw477Abuzz4k+tQneG2zgX1st975QuN8jkc+9sEjHXqq8UIoO1EhQFjl9Dac2 gsualX0cejdblAxAnazRE0IQcEf/cRwCXZItRYGRF3h9f76mZRe3+JunBJJYuBIVJ0R9 5+zA== X-Gm-Message-State: AOAM532ZjE/gBEKVTBxfn2G77vh6kpbMFRly0H+l+OGzq8ixJtTuk5Qp UmgC0ZqGTFs4P1BMsjSntho6Rw== X-Received: by 2002:a17:906:4d99:: with SMTP id s25mr5632392eju.175.1632996789937; Thu, 30 Sep 2021 03:13:09 -0700 (PDT) Received: from ?IPv6:2a02:768:2307:40d6::45a? ([2a02:768:2307:40d6::45a]) by smtp.gmail.com with ESMTPSA id j14sm1265961edl.21.2021.09.30.03.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Sep 2021 03:13:09 -0700 (PDT) Subject: Re: [PATCH v4 10/11] microblaze: Use is_kernel_text() helper To: Kefeng Wang , arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net, ast@kernel.org, ryabinin.a.a@gmail.com, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, bpf@vger.kernel.org, linux-alpha@vger.kernel.org, Christophe Leroy References: <20210930071143.63410-1-wangkefeng.wang@huawei.com> <20210930071143.63410-11-wangkefeng.wang@huawei.com> From: Michal Simek Message-ID: <2a23c06c-62e5-d4f8-4c7c-4e5c055a9e69@monstr.eu> Date: Thu, 30 Sep 2021 12:13:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210930071143.63410-11-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/21 9:11 AM, Kefeng Wang wrote: > Use is_kernel_text() helper to simplify code. > > Cc: Michal Simek > Signed-off-by: Kefeng Wang > --- > arch/microblaze/mm/pgtable.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/microblaze/mm/pgtable.c b/arch/microblaze/mm/pgtable.c > index c1833b159d3b..9f73265aad4e 100644 > --- a/arch/microblaze/mm/pgtable.c > +++ b/arch/microblaze/mm/pgtable.c > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -171,7 +172,7 @@ void __init mapin_ram(void) > for (s = 0; s < lowmem_size; s += PAGE_SIZE) { > f = _PAGE_PRESENT | _PAGE_ACCESSED | > _PAGE_SHARED | _PAGE_HWEXEC; > - if ((char *) v < _stext || (char *) v >= _etext) > + if (!is_kernel_text(v)) > f |= _PAGE_WRENABLE; > else > /* On the MicroBlaze, no user access > Acked-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs