Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp222981pxb; Thu, 30 Sep 2021 04:52:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztdf8N4py9CCRaVo1/h4X11M55EZxKgYEq2k+ToO1WXS9woL2t6Bzc6RKFS4hFaDkVdor2 X-Received: by 2002:a50:cf87:: with SMTP id h7mr6750575edk.324.1633002766996; Thu, 30 Sep 2021 04:52:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633002766; cv=none; d=google.com; s=arc-20160816; b=jMgMoIcrxJaKxKS3PZH1aC6Caro1SOE3srymXPmRoRCuhoA4hOWw2Yxzc3fdNvCPrj RJWambZvuQI0d99KEv96PbREhSyIFv5LRhyY9hRzYJjOOteLfuZMLe+fYoyhGiApn2Ek X0SFCPJQGVglpMgtZniOhrCXxZI+KL6JflFzFjA7klt1Vm55vaB8B8L0xWhUiTq21rap HlHNh/FF/VTPvYa95OyGU2/nIHGkFeaSerDuF96ZAfIs0h4fw3crEOLIHMKHtLBK7KcN DQRBy3eSeDQHNXLtyaR6TfG9wvtn0ij2c6Cki3yOrRV9LA7YaTwgGgI/iNYuRYU96tLW g7BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zem8paSl3IEvGjH/9/Yo51pLAsOn7wi/jHVT4rCQ9Vs=; b=jJLDBYQP2VGUV/GxEgccnSiS5xbzyxYFKhGSZ6qu5LU1z36+OcL4Xap/YETvMLnejX Bzze2hpX2Gjlxvp2JaTVle97Q7Uakz5gy2pgaP6TStNv0tAgH3RaEEugUooiXmPRlutF pDp+sqJm9g4+Y7f+eHkg72Zg+uJEkURVOawfWsXzpw3Y4uHH+xxDjoBw6j94iRz4u9KA 70Zteyi+U7I/+kSnmvEC/fKlq9+EzJRBlwtbuW+fr0bSqb9qd7N5MjhVMJxlDUWFlKHe 0n3MGkXqQQebYwbTDq5hN2H27yAbr2dt2FnD0pOZzxmEKs5aqzIENdtcynsenW3mmWLD AXdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ZBIGHE2D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f4si3237964edx.287.2021.09.30.04.52.21; Thu, 30 Sep 2021 04:52:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ZBIGHE2D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350614AbhI3LvK (ORCPT + 99 others); Thu, 30 Sep 2021 07:51:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350609AbhI3LvF (ORCPT ); Thu, 30 Sep 2021 07:51:05 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24F30C06176A for ; Thu, 30 Sep 2021 04:49:23 -0700 (PDT) Received: from zn.tnic (p200300ec2f0e1600628f023c6c6559e3.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:1600:628f:23c:6c65:59e3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A9BCB1EC026F; Thu, 30 Sep 2021 13:49:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633002561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=zem8paSl3IEvGjH/9/Yo51pLAsOn7wi/jHVT4rCQ9Vs=; b=ZBIGHE2DxneHCUOEePSEe/hMa9iA15d/gfYgdDgS4pYAIXLAcc06ZbdnWjXwLlohQTgcaY YssbZ5RtNiKTqVk2uZzoCN8XEaa6ffpjtLV1N8Jnfe1TWGDW4AKK+P+0Z9lMwsDTjFCWDT OwgwR0HIws2WBvOaY8k3UjDtufGGJRs= Date: Thu, 30 Sep 2021 13:49:22 +0200 From: Borislav Petkov To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Lai Jiangshan , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , "Peter Zijlstra (Intel)" , Joerg Roedel , Mike Travis Subject: Re: [PATCH V2 04/41] x86/entry: Introduce __entry_text for entry code written in C Message-ID: References: <20210926150838.197719-1-jiangshanlai@gmail.com> <20210926150838.197719-5-jiangshanlai@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210926150838.197719-5-jiangshanlai@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 26, 2021 at 11:08:01PM +0800, Lai Jiangshan wrote: > From: Lai Jiangshan > > Some entry code will be implemented in C files. We need __entry_text Who's "we"? > to set them in .entry.text section. __entry_text disables instruments s/instruments/instrumentation/ > like noinstr, but it doesn't disable stack protector since not all > compiler supported by kernel supporting function level granular > attribute to disable stack protector. It will be disabled by C file > level. > > Signed-off-by: Lai Jiangshan > --- > arch/x86/include/asm/idtentry.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h > index 1345088e9902..6779def97591 100644 > --- a/arch/x86/include/asm/idtentry.h > +++ b/arch/x86/include/asm/idtentry.h > @@ -11,6 +11,9 @@ > > #include > > +/* Entry code written in C. */ > +#define __entry_text __noinstr_section(".entry.text") I'm assuming that __noinstr_section() is defined somewhere, maybe in patch 3, which I don't have in my mbox. Yah, the 0th message says: " compiler_types.h: Add __noinstr_section() for noinstr" Aha, I see why: you haven't CCed me on that one so I don't have it: https://lkml.kernel.org/r/20210926150838.197719-4-jiangshanlai@gmail.com I have all the remaining 40 but not that one. On your next submission, please make sure you CC x86@kernel.org so that all x86 people get the whole patchset. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette