Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] USB: xhci: dbc: fix tty registration race
To:     Johan Hovold <johan@kernel.org>,
        Mathias Nyman <mathias.nyman@intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
References: <20210928120400.20704-1-johan@kernel.org>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <87c08115-06e0-6734-887a-7ae4e97fe5ab@linux.intel.com>
Date:   Thu, 30 Sep 2021 12:24:10 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210928120400.20704-1-johan@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28.9.2021 15.04, Johan Hovold wrote:
> Make sure to allocate resources before registering the tty device to
> avoid having a racing open() and write() fail to enable rx or
> dereference a NULL pointer when accessing the uninitialised fifo.
> 
> Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
> Cc: stable@vger.kernel.org      # 4.16
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Thanks, adding to queue

-Mathias