Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Sep 2021 13:05:10 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] regulator: Add Unisoc's SC2730 regulator driver
Message-ID: <20210930120510.GW4199@sirena.org.uk>
References: <20210928073609.198975-1-zhang.lyra@gmail.com>
 <20210928113057.GJ4199@sirena.org.uk>
 <CAAfSe-vM8iG1OtQeVR1CxQtpvA8kqSs3pJ78RQQOL7GcWcTwSw@mail.gmail.com>
 <20210929122912.GO4199@sirena.org.uk>
 <CAAfSe-tJMvYyvtOArsAW9Y980y_qzUgHoaQsyqnO6W47f9jMNA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mz5eWKkhz39mMVQV"
Content-Disposition: inline
In-Reply-To: <CAAfSe-tJMvYyvtOArsAW9Y980y_qzUgHoaQsyqnO6W47f9jMNA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--mz5eWKkhz39mMVQV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 30, 2021 at 11:12:28AM +0800, Chunyan Zhang wrote:

> On different platforms, sc27xx_spi consists of different sub-devices
> with different compatible string, to avoid adding mfd_cells to
> sc27xx_spi driver each time we add a new platform support, we changed
> to use devm_of_platform_populate() which can automatically register
> sun-devices listed in devicetree.

> The above is my understand, please correct me if I'm missing something
> @Lee Jones

Right, so my pushback here is that it's not clear to me that avoiding
adding compatibles to the MFD is a strong enough goal to justify
creating ABI - it's hard to see the upsides.  This is particularly the
case here where the subdevice is really a random collection of devices
that's particularly likely to change between variants and more likely
that other OSs would want something different so it's even harder to
achieve reuse.

--mz5eWKkhz39mMVQV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFVp/UACgkQJNaLcl1U
h9A0NQf+MVIV20djUxEYTyRsu5XcsUBXOCjUH8C6aiUvI1f+91mdMR5EjZGsWxOP
Qxind1nfGXf7+41sboK/15s4xWsWpFDHq/4wBUkHdgiqoywBuYisngyieNGhVNeB
3FSJSdW0aNHNNNAjOSG0YXQRxog5XSBRSQ3s2614QFVXGFHh0DQoin2ud2rgPeZ0
H7A6BV2E0LR+w3YNs/twWw7j4aM/wkrVTCc9OfPNdX5gNC1SoK6KC6ApfZYUyT0G
k2jcq3qnQyGuadQPkpgo9X3tW7enbWzyGAL3aEN/jbaugSPsiS3pJsPizR00n5Jz
VIb/B5YtJxgs+XIw4I6aELxDkaDdhw==
=OZXI
-----END PGP SIGNATURE-----

--mz5eWKkhz39mMVQV--