Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp286983pxb; Thu, 30 Sep 2021 06:09:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuoDebVBDgarXWEkhNPv9R9EUcMp8ZEXMovoML/uc5WiADYfuCX5c1lFhdYZozCYl7yB5d X-Received: by 2002:a17:90a:8c82:: with SMTP id b2mr13199896pjo.173.1633007393083; Thu, 30 Sep 2021 06:09:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633007393; cv=none; d=google.com; s=arc-20160816; b=JDum4tNXKB95U3YJFUvAKZgvc0zBQMRL55lBPpC42C2Hsoxt6I74EOzPGVXZJVuNpO 3qr5VnNNfMJqu/RquAZ/thM9fW2WQQw7b3dnKd+I1bL0S8zxz7yIK+AA3LOxuDNDZ9tG vsKTcXm5Tb3xPbIwAnoPrvUAJG8/Jyaov0FtgD4lZ43+MDlvkxMePUlVLo/Kvus9nCbE Z9M3OymBk6T41bAXgFU+EyeWBboQ9QPb348QDp7gz60mEaYks7+1zAXSNvh0HUwya7PU krHIW2zYp/Z9piXsHkzYfPIYJtrqxcZ0bGbRR+U7jRE1SCeJg4OWDN+1KEFBFd/Wbo0S V7Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=/rpNNojemAf+CUDVO0KvRTFjd+lPVon4+9vJTdmWYEE=; b=EEHmBrz2Gts0FqNGxluaAOZWh4PqU0E+xilUyqFCfB1sFjGwcweJbXhGUXUtnwD7ym sd7l7plPMvW617Tk9m55BEzyRwI7fasfe/JlbAwfs58jKnNTuWArhDK+LNPEVwyNjE77 PW6UnY34XjTIBOJZhoBYzenYhFemQSyeRO4UsU8bjAyV2hCxIeX60T2dNTBLlA+fNG5S xNMal4nVmpK4Qdda0Jng2nkyWbXiLzrVqMl8B4SVsegWS9DfXbsru9FpG/GtKkPpRwxz vPA/fFRZ25eFh0vBLlJN5H7xIf5RVXWIJi5EW96sLiZ2jbKFkV1cuQYDwYznRSII2NCN mvaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s3Eo3qkz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c15si3710504pgi.9.2021.09.30.06.09.39; Thu, 30 Sep 2021 06:09:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s3Eo3qkz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350115AbhI3M1r (ORCPT + 99 others); Thu, 30 Sep 2021 08:27:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:33876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349808AbhI3M1q (ORCPT ); Thu, 30 Sep 2021 08:27:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A3C416136A; Thu, 30 Sep 2021 12:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633004764; bh=XMzKJ6yQ8GbX+H2Mwz1aDa/jAtUE4SY9wpVtxJIyZlg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s3Eo3qkzu0Ybzjop5jdJIvAJCw2rR6kSVz8ydyU8+d6/AEFcKt82yCpmZhMWNMR18 txTbK4AznXgsFdNvNU0XcKXpkzaPCV501bHudxqlqlHxnUOc7CBRj2dzhgheCvT+fl pTt101pLo8mKIts0d4zrPrk8olXVr9L6P4Z03+innWuMTSJYV4e1BJYP1ta75ED0zA ICYLj7QThUpt2UrNmRtkLk3p8ZAJajM2AXKObOUV2mAzAI9E3gTWvf9HB1sfd73V/n jdyp9LEQjJ7vsZL+ypBhXs1rvyp9Aw5lZ2QwHs6cQi0KAOScLV/dY/Tvkcax6rRBM1 rWw0XSyQRzYeg== Date: Thu, 30 Sep 2021 13:25:13 +0100 From: Mark Brown To: Dafna Hirschfeld Cc: kernel@collabora.com, linux-spi@vger.kernel.org, enric.balletbo@collabora.com, dafna3@gmail.com, Mason Zhang , Laxman Dewangan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, Matthias Brugger Subject: Re: [PATCH] Revert "spi: modify set_cs_timing parameter" Message-ID: <20210930122513.GX4199@sirena.org.uk> References: <20210930120700.2564-1-dafna.hirschfeld@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BtNCO5h84ExDStzY" Content-Disposition: inline In-Reply-To: <20210930120700.2564-1-dafna.hirschfeld@collabora.com> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BtNCO5h84ExDStzY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 30, 2021 at 02:07:00PM +0200, Dafna Hirschfeld wrote: > This reverts commit 04e6bb0d6bb127bac929fb35edd2dd01613c9520. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. > This revert the commit 'spi: modify set_cs_timing parameter' > and its following commit > 'spi: mediatek: fix build warnning in set cs timing'. Which is not what the commit message nor the paste of the full hash claimed :/ > Those commits cause regression on mt8173 elm device. The EC either is not > able to register or it sends numerous amount of errors: > cros-ec-i2c-tunnel 1100a000.spi:ec@0:i2c-tunnel0: Error transferring EC i2c message -71 > cros-ec-spi spi0.0: EC failed to respond in time. Do we have any analysis as to why? Do these devices use timing parameters in some way for example, or do the values written out to the device change in some way? You've provided no analysis here so it's hard to tell if this is just some random change that happens to change code generation slighly or if there's some actual reason why this might fix something. I'll note that as far as I can see there are no users of this API upstream so I'm guessing that you've got some out of tree consumer driver which uses the API, it's possible that there was some error in updating that driver to the new interface which is causing the issue. --BtNCO5h84ExDStzY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFVrKkACgkQJNaLcl1U h9BQ+wf+L0v6eP7/ZC1yGM364eVeDsmC7RZB1iQ+4emAZbeaTiv7ISlnwpWSYO9z 80HsRI6OyRoEZK23fudRrN0dV/GhiBunllTihW9w2oh/TB2mKP8Ilq7pF9ziL1Uk Wa0mXzMwdZ6KA4dX24Szlnogkwoep61uPNcjvglsxfQMdr5o210AEHt3QqVZz3gU dRi/chCDiy0GhmqlC7Ajcvb2Xx7aBoFYTZZR4ZGZj+htIo+bbwuoFCEqOGtoqxSf d/OCbLOzvu+/zvXNnoFKMinCTPcpRYx6WZW8nDM5SeJLTsQ9wpaMTHxMeRFVnY7W gLT1N00BcSOUIEGzUOwpMGbGMFFpJA== =RhSa -----END PGP SIGNATURE----- --BtNCO5h84ExDStzY--