Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932642AbWLSBo6 (ORCPT ); Mon, 18 Dec 2006 20:44:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932638AbWLSBo6 (ORCPT ); Mon, 18 Dec 2006 20:44:58 -0500 Received: from [85.204.20.254] ([85.204.20.254]:56774 "EHLO megainternet.ro" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932642AbWLSBo5 (ORCPT ); Mon, 18 Dec 2006 20:44:57 -0500 Subject: Re: 2.6.19 file content corruption on ext3 From: Andrei Popa Reply-To: andrei.popa@i-neo.ro To: Andrew Morton Cc: Linus Torvalds , Peter Zijlstra , Linux Kernel Mailing List , Hugh Dickins , Florian Weimer , Marc Haber , Martin Michlmayr In-Reply-To: <20061218172126.0822b5d2.akpm@osdl.org> References: <1166314399.7018.6.camel@localhost> <20061217040620.91dac272.akpm@osdl.org> <1166362772.8593.2.camel@localhost> <20061217154026.219b294f.akpm@osdl.org> <1166460945.10372.84.camel@twins> <1166466272.10372.96.camel@twins> <1166468651.6983.6.camel@localhost> <1166471069.6940.4.camel@localhost> <1166476297.6862.1.camel@localhost> <1166485691.6977.6.camel@localhost> <1166488199.6950.2.camel@localhost> <20061218172126.0822b5d2.akpm@osdl.org> Content-Type: text/plain Organization: I-NEO Date: Tue, 19 Dec 2006 03:44:51 +0200 Message-Id: <1166492691.6890.12.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2442 Lines: 58 On Mon, 2006-12-18 at 17:21 -0800, Andrew Morton wrote: > On Mon, 18 Dec 2006 16:57:30 -0800 (PST) > Linus Torvalds wrote: > > > What happens if you only ifdef out that single thing? > > > > The actual page-cleaning functions make sure to only clear the TAG_DIRTY > > bit _after_ the page has been marked for writeback. Is there some ordering > > constraint there, perhaps? > > > > I'm really reaching here. I'm trying to see the pattern, and I'm not > > seeing it. I'm asking you to test things just to get more of a feel for > > what triggers the failure, than because I actually have any kind of idea > > of what the heck is going on. > > > > Andrew, Nick, Hugh - any ideas? > > If all of test_clear_page_dirty() has been commented out then the page will > never become clean hence will never fall out of pagecache, so unless Andrei > is doing a reboot before checking for corruption, perhaps the underlying > data on-disk is incorrect, but we can't see it. if I do a sync and echo 1 > /proc/sys/vm/drop_caches does the reboot is still necesary ? > > Andrei, how _are_ you running this test? What's the exact sequence of steps? > > In particular, are you doing anything which would cause the corrupted file > to be evicted from memory, thus forcing a read from disk? Such as > unmounting and then remounting the filesystem? I boot linux, I start rtorrent and start the download, while it's downloading I start evolution and i check my mail(my mbox is very large, several hundered megabytes), I close evolution(I use evolution just to have another application witch uses the filesystem and the memory), I start evolution again. I start firefox. The download is complete. Rtorrent says if the hash is good or not. I do a "unrar t qwe.rar" to test that all 84 downloaded rar files are ok and see the result. > > The point of my question is to check that the data is really incorrect > on-disk, or whether it is incorrect in pagecache. > > Also, it'd be useful if you could determine whether the bug appears with > the ext2 filesystem: do s/ext3/ext2/ in /etc/fstab, or boot with > rootfstype=ext2 if it's the root filesystem. I will test. > > Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/