Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] USB: cdc-acm: fix break reporting
To:     Johan Hovold <johan@kernel.org>, Oliver Neukum <oneukum@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
References: <20210929090937.7410-1-johan@kernel.org>
 <20210929090937.7410-3-johan@kernel.org>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <b4d332bf-de58-f0a5-c403-429b1c67af1b@suse.com>
Date:   Thu, 30 Sep 2021 11:05:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <20210929090937.7410-3-johan@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzQ3Y1BVQndKaFpJa2hzY1BJaGcwZU5oZEc1WGpGbmxHV2ZwUFBYSVBIQ0hX?=
 =?utf-8?B?UlJqMHA1WU4zUGdkeDhRNCtibCtFd2JnQ0lYVzArZlYvaGwwTHYzaVVsZFFo?=
 =?utf-8?B?eEg3RVptdnpKRkJNQnkvaHo2ZW1lTElhSjdsM3RVVzljRm4vMTZSWm82SGNu?=
 =?utf-8?B?TVY4ZGlSbnRTQUduelRUUmN1RVVUZCtaczF4V2xrQ3Y5UldzY1EzYWl3UzU1?=
 =?utf-8?B?blQ2TzJLeElOQ2hVSXNXZGpMb0c4WnlSTTY1ZVRHbGdFZ2d4WmdrOWF1eElm?=
 =?utf-8?B?SnB3N3l5d09mM04yLzV3M0g2Uk9vTmsrQVFLMURpUTc2SXliR0tqN0NQWDVW?=
 =?utf-8?B?OFlTcTJFNXltUGFLd1lYb3dYYXVoRjlYUVhDMDZtUEFLTWJ3VkQ5R0VhdjBC?=
 =?utf-8?B?ZlYrSEpLbXAzNk0rdHZwcTIrSHFsQThLRVR0S0wyMkhOWVdmRTJVeFJXTk1t?=
 =?utf-8?B?anlORVRBczVic2gvUmZJTWMvYTZGNStSbFJqVmJ2bjhKc1l2QUkvRi9pN0Vy?=
 =?utf-8?B?MVhFUGJ4WkZ2bFg0MHI3eFlQa2Y0d2FtR0dZbHhMaW04QklvbmlqV0ZsN0F0?=
 =?utf-8?B?cmkvQWFTVnNmZjgwRjJvVm9vTmtRNXFON1NER3ZXOGRUMHBWZXFNMldEd3dK?=
 =?utf-8?B?L05pRGJpN0dwL2lrVURlVnROMkl2eTdWYmxWMzY2a2xYai9STEpzNUljN2pC?=
 =?utf-8?B?TkNESlNBOWovN0h3d1RlYURnWVJ0YWFSRFhUdnZiZHhQekh2T3dCVHpDTmYv?=
 =?utf-8?B?clFTV0ttVG42SEkxQ2NiVGNSRjdUU1hsQmlMU0NkVzgwOFBSVGxYZHFFd1NI?=
 =?utf-8?B?Y2YrWk85WWp6K01nS08wQStyKzNreExaWm0ya2ZlUmN0eE1tQ3A0M3lyTHJB?=
 =?utf-8?B?bmszWHQzMjE2UzhKSjRmTFk2akl4dUNuL3VDYXhUS1lGc0VNeGZ3ZG1xODZj?=
 =?utf-8?B?SitWMHBUTml5ZDI2RWNIVEloTWJVU1dzMWpJalYvdzd5dzRFaFY5WU1qVE5j?=
 =?utf-8?B?RW01c240Y3IwQVFGQ05QRE5xL2ZWWnljZVJvVGw4OGdXVmZ5V0E4cUhLRVo5?=
 =?utf-8?B?SnQxczBWdmI4MVNlbVJjS1BFU1JwUGxUMWx6MGEyN012MmhRVVJ0NmpCcFZS?=
 =?utf-8?B?aGcxK1habklyV3JHbXh4T2RTN20xYXVpSVhKZXhOcTUvakRFNURUTDBuSmhK?=
 =?utf-8?B?SU5rNWNZSHJnY1FZd1BodkJrSVhycG5SR01NeWovc1FKckxyVkk1MDVGa1RK?=
 =?utf-8?B?KzZ3aUg5cW55YzdpMVZRMlZ3ZkNyNlZDbUgxSFJEOTZjc3VOR0xGbUpEMlZG?=
 =?utf-8?B?bnI4QlorUU1SMVhvWldubkJBVXNxbUF0cTBrbTNRMlNPSE5jZFdtZUJ5YzQ4?=
 =?utf-8?B?ZEVuaWhyTUJwbUNDUjBzTGVFamIvTElVWkRHZXVVOXEyODQ0SlRaN1VwQWtj?=
 =?utf-8?B?TzdjK3BwY1psMFQ5NTU2UWlyNlZ5MUdwRGs1OWNlbXJPZk9VdWZ0eDUyZGNp?=
 =?utf-8?B?UU5uWUNwMWwrU3hKSHJkYnpYZUg0Y0RiNHAwblhSSmVxWklSMjBtK043cy9i?=
 =?utf-8?B?dUt1bzhITVZmOTdoY01kZGxSUlRRUUtxZE05LzhJL2VmTi9uVkk0cXh2NGNn?=
 =?utf-8?B?R3lUSWI2djlvUlQwT2MwZk9GV2RMemZIb0svWk1DbnFRTFdQR09FeGhCbkFI?=
 =?utf-8?B?NjVSdjFucEQ5YjRlWm5PVEV1dnFZWW1JOTE2emtaSndrUWdyTS8zLzFPN29k?=
 =?utf-8?B?MlM3WGdtU3kzOHlXZ0l2MEV2NEZPY085dHZ5NGNrSWhhRHdlcUNtbFQzdHhS?=
 =?utf-8?B?SDhVK0dJTWVGQ2hWcVNaVisvajlqMExWb1RvM2dsQXN3SCtmUTN2blZaV2ZJ?=
 =?utf-8?Q?rCjj1D6QjI0Hr?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1393d938-8398-4d74-66e3-08d983f16f7f
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 09:05:23.1722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Id9fH3zn5ATuKf0PDFVvQCaReSXjh8XLNQA4XpUgnpBFlzw7Dtt3f2ByPm/reUTeAKhTe1l1ck6SrTAyTB7+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3143
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29.09.21 11:09, Johan Hovold wrote:
> A recent change that started reporting break events forgot to push the
> event to the line discipline, which meant that a detected break would
> not be reported until further characters had been receive (the port
> could even have been closed and reopened in between).
>
> Fixes: 08dff274edda ("cdc-acm: fix BREAK rx code path adding necessary calls")
> Cc: stable@vger.kernel.org
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Oliver Neukum <oneukum@suse.com>