Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] usb: cdc-wdm: Fix check for WWAN
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        Wei Yongjun <weiyongjun1@huawei.com>
Cc:     Oliver Neukum <oneukum@suse.com>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Junlin Yang <yangjunlin@yulong.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20210929132143.36822-1-rikard.falkeborn@gmail.com>
 <20210929132143.36822-2-rikard.falkeborn@gmail.com>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <f1e62c1d-b132-45e2-a213-2b2a3e91288e@suse.com>
Date:   Thu, 30 Sep 2021 11:06:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <20210929132143.36822-2-rikard.falkeborn@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3VaTkEwd1lodnZ3VExhTkEzMEtWMHJhVXE4eGpCeHMrYWx5RFpWT0dHa2ZX?=
 =?utf-8?B?dnVNOWtNYTRGOXBIbmFOaWhUUXpqWE5adURWMHNzM255dm9OMmUwTUN4Z1do?=
 =?utf-8?B?S3RpckFHMmZEdnVhYXN3eEdaNjJwd004V2pZWktqZ3Q1d2VXNWRWaXFYWk1B?=
 =?utf-8?B?T1RIV3F6VzltYmdMS2Vydmx2MkxIZGVHd0E5UEZtRjhkMVZRN1UxRmw3a2ww?=
 =?utf-8?B?bE05ZUJzQXdBTUZUNjFCZzBrS09xVjlCSDlMSjZUREZxMWxIdjhJZGpuRFJW?=
 =?utf-8?B?UVZRSnVXY3VlVHQyamwvQ25BZXMzWFJKVGJGS3lSSERMUFpzSGpRSGlYbURP?=
 =?utf-8?B?TWZidFNFalhKVXVBV1F6U2RlemdIZ2pDL0NsWXdXNENvQ0RtUmdRR3Zab3Rn?=
 =?utf-8?B?K1QyVyswSE9YaUROZVJPdGhmbVVKRUZxUTVGL1dkaitnQWQ5Zk9BZzlOeVgv?=
 =?utf-8?B?ZkpkSmJodmMzTkI5b01BaTRiNlBoQkpoVVR0ZjNhMFR0dm1RcmNjSXhkZkZz?=
 =?utf-8?B?QVJFSWdtUnFZVHRqRG4wcDdsZ2lLVGNkczlIS3dvV3prQlJzWWcxSVA3Nkly?=
 =?utf-8?B?SE9mdE1EMkxLTlUxZ3YwL0x5OEV0WmRJVTMvR0xVbkQxNzkvMmZlR1YrNFBC?=
 =?utf-8?B?V004SjhFNXlQTlljMWpyUStxZFRkUDFMcVU2aGpodkxNWEV0ZXRYbHNxNkE3?=
 =?utf-8?B?aEFhUEJ4aEdLTEloUG5IZ3hUbm9kcFJ3bDdMamRRbUJGdGNyY3IwRUdNa2RF?=
 =?utf-8?B?cmF2ZHE4NDNmN24xODZHOUh0cXc3YTdsZHJpclBIUmVrVVU2M3R0ZmRhbDFX?=
 =?utf-8?B?MjBFTm0wNHo1aHYxaVRLVkhGRlpJTEtubVdIUUtNSWlYY3NWSXZYT0ZmUGRC?=
 =?utf-8?B?QTFJRnFlZ1Z3cC9RN1NHcllleFZCMmxPWk1EZ0xzWVRsQVJVdDNhNGhzWmVE?=
 =?utf-8?B?LzYwOTQ1STB0TVY1eStNOW1MQzc5Q2g3VC9adEJHQ2RGODI1NmM3czZRSitr?=
 =?utf-8?B?a3R3djJrem1XM1BOSFErYVJNdUhMRnNtS1VYcVBvVlFZQkloU1pZaFNmTnVw?=
 =?utf-8?B?RWJzSTBPN2tVUlhPakNubkpadWw4ekZrV3RDL0FvTmhDMDkzK1U4dGpCYzRO?=
 =?utf-8?B?bzQycHNURzJLU1lvRUhXUkZLd0I4b0dJb2x5eW01bVU4dS9FTmE4SCs1N2Z1?=
 =?utf-8?B?TDJCRmV0RXc4cHNOUmNoZE1lNG1BZWVwVFVVS1lPWThFOGxHTHJTZTY4UWFm?=
 =?utf-8?B?UDVreGRsZ3pXMmRFRStRUGtrVHlYSncybVVDVWRHbjBmcjlyN1J0T0pTNURy?=
 =?utf-8?B?TkYvUmlwbGpnMW9qM1RvV2l3V2puU3dYajAyRG8rVDRSZFlHWDkxOHIvdlEz?=
 =?utf-8?B?Q0t6SEo0YldMQkpySGVGQVFzbHgvTmYyWmNIb1dtK2NlMWtPRGZleENXTWNW?=
 =?utf-8?B?Tk5yaU9TbmRVeEVQVDVhajQyR3JnUkZ1Z05ZWmtDK2hZUkRaOUsrVmFEZHc2?=
 =?utf-8?B?bVAvOWJxdWFhWk5iLzE1M2VhcEF2Rmw2dEEvSVJ5dzBybHFkTG9YaTc2cHc4?=
 =?utf-8?B?ZDJZM2VTYVVQY0JVcmF0S3E0bmc2YXZBMXAvNmUxNFBUR0dNbkVDVlMwZ1Zh?=
 =?utf-8?B?cCs5c3NZb2srVDdycUJoTGpwQzlpR1htYjhzQlJEK090VnhYVGJkcHQyNDM1?=
 =?utf-8?B?WTJ3QzdCdDUxT3hMVFQyRlVJaEVueVI4TlZ2QzJsV1Q2VWlmR25RQUlJU0FU?=
 =?utf-8?B?dGt1VHFyR0c1akt2aWdpUDdtZnZlWmxSQ0VzVlQ2dUp1S0RZUkQ2UFRUODBB?=
 =?utf-8?B?amw1bFFFenBCVyt3ZldwUmFFbENMSmw4anllejNna3JSRGQ0RjRjOUh1MUIz?=
 =?utf-8?Q?vhiY2XQY2VBe6?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40500d12-9fcd-4a89-2613-08d983f1a12e
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 09:06:46.5558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IxAC6v0tbO3+JJJC/MSUAOzUVHRqpWoFEr3nt+a6Wo6sPoDqiE3d2F8lA5ng8v1GZY4djTJh2mCmhW4QOmbX1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3143
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29.09.21 15:21, Rikard Falkeborn wrote:
> Commit 5c912e679506 ("usb: cdc-wdm: fix build error when CONFIG_WWAN_CORE
> is not set") fixed a build error when CONFIG_WWAN was set but
> CONFIG_WWAN_CORE was not. Since then CONFIG_WWAN_CORE was removed and
> joined with CONFIG_WWAN in commit 89212e160b81 ("net: wwan: Fix WWAN
> config symbols").
>
> Also, since CONFIG_WWAN has class tri-state instead of bool, we cannot
> check if it is defined directly, but have to use IS_DEFINED() instead.
>
> Fixes: 5c912e679506 ("usb: cdc-wdm: fix build error when CONFIG_WWAN_CORE is not set")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Oliver Neukum <oneukum@suse.com>