Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: [PATCH v2 6/9] xen/x86: generalize preferred console model from PV to
 PVH Dom0
From:   Jan Beulich <jbeulich@suse.com>
To:     Juergen Gross <jgross@suse.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <9a26d4ff-80a1-e0c1-f528-31a8568d41f7@suse.com>
Message-ID: <582328b6-c86c-37f3-d802-5539b7a86736@suse.com>
Date:   Thu, 30 Sep 2021 14:19:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <9a26d4ff-80a1-e0c1-f528-31a8568d41f7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDVXN0FvYmttK3FoYnhLdDVnZjEvcHljWkoyKzRCR3ZmeWQ5WU5qMjAxY0xU?=
 =?utf-8?B?bkRabFVlV2wyOTgwZmwvaUNETlloYk0rNUp4czlka205c1Rna1lBUFN5REU0?=
 =?utf-8?B?d3RLSEx4SHo0bTJHWVgwSzhEdWpFR2FjWVNFVFJ1cjhzaGxjVW5VTFNiZ1dJ?=
 =?utf-8?B?eG1TTCt0SWFxTmJPSFhrNjVJZWF5Y3J1eHY1TzZudDBxSHgrbDltL0lzWW5H?=
 =?utf-8?B?S012eW9CeitDVk10amRpdFVtMDVtQmZsaEMvTGJXNW4rWHFzbFYvTWpCcWZN?=
 =?utf-8?B?T0xwM1p4cXFBaXFHeWRyazZCMi9rS2VvaG91YWdTNUlXejRzMENjZlBVRnRS?=
 =?utf-8?B?VjF3MlEvYmxTVysyUFMxaEpDUEFTRUhNQ1hlY3JrZmFVZ0JyMlJzT0NLZHdY?=
 =?utf-8?B?RC9wWTFCSlNwSTgxYjROdTFxWHYzN0NTYVh0MjlPSHNnU2xTVUEzZjNxMnp4?=
 =?utf-8?B?YjFQNkdnNFU4NVBXOWFCcFpiaHNXY3Z1MHA1R2NDam9yQzd0WlhMeTE1aE1R?=
 =?utf-8?B?RG9BOUFHQXI1RXc4d2lCNytGNVJ5UU5WNDMyeHV0OXRPcUFqL2FjZFR2MURC?=
 =?utf-8?B?R01WdTE5bkNZeHowYXc2Q0FjbnJYU1hKc21ad2tzZTA5cGc4Z2tHblEvQWZr?=
 =?utf-8?B?aWYxUXZobldiVzRkWTFxY1lxNnk1UWJPaTI4d1BGdnQwa3I3WlBxKy9nZ0h4?=
 =?utf-8?B?M2Q0djk5VEVCSFpsT2RPTE5WczZ1d044eUlYN29kcG9CS0plYnpvVWpvenAz?=
 =?utf-8?B?UEtjckQySTN1K21GeEROSzVoZFN0NHFuR2lCS2pBdmRRMUFKRk1WczdBUnZ4?=
 =?utf-8?B?SktlSU9QR21WZ1FiSlJLQVU2L2trWWRCaDE0SktTWFlTaUw2aEVUT1ZLRnRt?=
 =?utf-8?B?OGRnbmQzUHQ0MW50Q09XaUtZaWZMYVRQdWtLdGNWcDBBOVB3cHplQkFSM1Zl?=
 =?utf-8?B?QmdrL3ZKd0NGaWNDTWRkcTFsOUU4VDNCYzBxSVQrNEdlNlE3YUlBaTV2aG15?=
 =?utf-8?B?R2lwNnNFZEVmQkxGQ05vSXFPSXRGR1N1Ykk2UTJiT3RUS09TeStmS0NHRnMz?=
 =?utf-8?B?aXBMM1RrUEtES1RycUt2NHpoMTluVDZkK29jK0NpYXkwRWdEM29SMDI0RUt6?=
 =?utf-8?B?Z204ajBsSjJPTUpPRVF3aWpuVmN1cnpvTjZXdisxSi9qSkNMMVgyMk1zNU5B?=
 =?utf-8?B?NEJOUXprWVl4TkpvaGQ5Rm9McHMzR0Y2NUxlRk1mUHVGaE9RVkpNYjBzQlVM?=
 =?utf-8?B?Uk9FVHdoMzNXNGVMNmZleHhMcUJQc2tXd3pNVzlCTU9scUhzZExFZWFob3Ni?=
 =?utf-8?B?WFg5YWM4a3JDT1F1U0JaM0pDeCtaSTlUQW9QUnFYSEdleVRKMnYvd3lkZCtk?=
 =?utf-8?B?cktnOXJpMEFWRWlOdGhERzYySjBDU1YxcjZJOVVBdU5BdFRJRjA1cGU3RTMv?=
 =?utf-8?B?bTZiT3U4N2xHNkFKZnhHUitqY2Rqa3lLUW00bWVpRVNlbW13cnZHd2t4K3JF?=
 =?utf-8?B?ZHB5anl0bzRxV0pidGYrRTRGODU5TlR2c0doTWpRUFg4dnJSYzA5a0xCSkpm?=
 =?utf-8?B?OTdseEVYcE9vR1IxOUovT0E2SDZ3SzdwVXpMVmlTQytURU03MEZRS1NvZVNq?=
 =?utf-8?B?VFlwY2V3N3RqSmV2NzBRbjlCRFhvaDdtcm1jbjVSeHkveE9ISDlxbXFJWHNr?=
 =?utf-8?B?VmdQaHA5YzZjT3liV01VQ3lYUmlUelJlM2dQdDFmU1Z1ZThmd0tnSk9mMWNk?=
 =?utf-8?Q?WnplLGizjskCuU8kEBAwvLH7omgqzT9JRbHTl+K?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02da42aa-3468-4345-7ae0-08d9840c86af
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 12:19:18.5366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3uiHMhrvh9IV9SsMOI2PpOt83c2MzEK6QEEyOxwjY3MhC52dEuLOvmdSm1mfolXaM4F39Y166Q3PEag7ZTjOVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Without announcing hvc0 as preferred it won't get used as long as tty0
gets registered earlier. This is particularly problematic with there not
being any screen output for PVH Dom0 when the screen is in graphics
mode, as the necessary information doesn't get conveyed yet from the
hypervisor.

Follow PV's model, but be conservative and do this for Dom0 only for
now.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
---
Prior to 418492ba40b2 ("x86/virt/xen: Use guest_late_init to detect Xen
PVH guest") x86_init.oem.arch_setup was already used by PVH, so I assume
the use of this hook is acceptable here.

Seeing that change, I wonder in how far setting xen_pvh to true only in
xen_hvm_guest_late_init() can really work: This hook, as its name says,
gets called pretty late; any decision taken earlier might have been
wrong. One such wrong decision is what gets added here - preferred
consoles won't be registered when taking that path. While adding a 2nd
call there might work, aiui they would better be registered prior to
parse_early_param(), i.e. before "earlyprintk=" gets evaluated.

I also consider tying "detecting" PVH mode to the no-VGA and no-CMOS-RTC
FADT flags as problematic looking forward: There may conceivably be
"legacy free" HVM guests down the road, yet they shouldn't be mistaken
for being PVH. Most of the XEN_X86_EMU_* controlled functionality would
seem unsuitable for the same reason; presence/absence of
XENFEAT_hvm_pirqs (tied to XEN_X86_EMU_USE_PIRQ) might be sufficiently
reliable an indicator. Question there is whether the separation
introduced by Xen commit b96b50004804 ("x86: remove XENFEAT_hvm_pirqs
for PVHv2 guests") came early enough in the process of enabling PVHv2.
Plus I'm not sure a HVM guest without pass-through enabled couldn't be
run with this off (i.e. by relaxing emulation_flags_ok() and having the
tool stack not request this emulation in such cases).

I think the approach here might be equally applicable for DomU, albeit
potentially pointless (i.e. dropping the conditional might make sense
even if simply benign there): A PVH DomU ought to never come with a VGA
console. Yet even then a dummy one may still get registered and would
take precedence over hvc?

--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -3,6 +3,7 @@
 #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
 #include <linux/memblock.h>
 #endif
+#include <linux/console.h>
 #include <linux/cpu.h>
 #include <linux/kexec.h>
 #include <linux/slab.h>
@@ -18,6 +19,7 @@
 #include <asm/xen/hypervisor.h>
 #include <asm/cpu.h>
 #include <asm/e820/api.h> 
+#include <asm/setup.h>
 
 #include "xen-ops.h"
 #include "smp.h"
@@ -274,6 +276,16 @@ bool xen_running_on_version_or_later(uns
 	return false;
 }
 
+void __init xen_add_preferred_consoles(void)
+{
+	add_preferred_console("xenboot", 0, NULL);
+	if (!boot_params.screen_info.orig_video_isVGA)
+		add_preferred_console("tty", 0, NULL);
+	add_preferred_console("hvc", 0, NULL);
+	if (boot_params.screen_info.orig_video_isVGA)
+		add_preferred_console("tty", 0, NULL);
+}
+
 void xen_reboot(int reason)
 {
 	struct sched_shutdown r = { .reason = reason };
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -28,7 +28,6 @@
 #include <linux/mm.h>
 #include <linux/page-flags.h>
 #include <linux/highmem.h>
-#include <linux/console.h>
 #include <linux/pci.h>
 #include <linux/gfp.h>
 #include <linux/edd.h>
@@ -1392,12 +1391,7 @@ asmlinkage __visible void __init xen_sta
 #endif
 	}
 
-	add_preferred_console("xenboot", 0, NULL);
-	if (!boot_params.screen_info.orig_video_isVGA)
-		add_preferred_console("tty", 0, NULL);
-	add_preferred_console("hvc", 0, NULL);
-	if (boot_params.screen_info.orig_video_isVGA)
-		add_preferred_console("tty", 0, NULL);
+	xen_add_preferred_consoles();
 
 #ifdef CONFIG_PCI
 	/* PCI BIOS service won't work from a PV guest. */
--- a/arch/x86/xen/enlighten_pvh.c
+++ b/arch/x86/xen/enlighten_pvh.c
@@ -36,6 +36,9 @@ void __init xen_pvh_init(struct boot_par
 	pfn = __pa(hypercall_page);
 	wrmsr_safe(msr, (u32)pfn, (u32)(pfn >> 32));
 
+	if (xen_initial_domain())
+		x86_init.oem.arch_setup = xen_add_preferred_consoles;
+
 	xen_efi_init(boot_params);
 }
 
--- a/arch/x86/xen/xen-ops.h
+++ b/arch/x86/xen/xen-ops.h
@@ -118,6 +118,8 @@ static inline void __init xen_init_vga(c
 }
 #endif
 
+void xen_add_preferred_consoles(void);
+
 void __init xen_init_apic(void);
 
 #ifdef CONFIG_XEN_EFI