Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c52ca248-f555-e5a7-4fb8-f6efdc06e6c6@kontron.de>
Date:   Thu, 30 Sep 2021 15:00:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH 2/3] dt-bindings: net: phy: mscc: vsc8531: Add LED mode
 combine disable property
Content-Language: en-US
To:     Frieder Schrempf <frieder@fris.de>,
        "David S. Miller" <davem@davemloft.net>,
        devicetree@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>
Cc:     Baisheng Gao <gaobaisheng@bonc.com.cn>,
        Rob Herring <robh@kernel.org>
References: <20210930125747.2511954-1-frieder@fris.de>
 <20210930125747.2511954-2-frieder@fris.de>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20210930125747.2511954-2-frieder@fris.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTAyVXJkWkxReitGOGMwN043ZEs1UlgxZFgxME9iaEJNWVkwWVVhQ29JUnpI?=
 =?utf-8?B?dFYvM1hGV2JoM0lDbmRlblg0NUp3cmREM1BBdFdteTJCMUxkNVVxY1dmVlFX?=
 =?utf-8?B?Z1NGMmpQL3Rhd1lyYkJtbW5uUlB4QkR3SUlyZGtoZTJzWTJHSERqbDFFMW02?=
 =?utf-8?B?S3EraTdvOGQ4b3NvcW9WMTBWTjI1bGI2ZUhSOURMQ2svcHUwOXVEcFZoMWl6?=
 =?utf-8?B?dkxYT3dJNVplUC9Gck1OeU5JVTRIL2JpZDNMQm9TU3BKVFNjNEtvb09TTzRm?=
 =?utf-8?B?dWc1K2syOEtTaklYdUw1ekxNcUJYU1owekxZdUZJSzRxUmJ0dUNrS0xBL1FR?=
 =?utf-8?B?akJpeUxLTDc4M2ZpaHpIODR4Wm9BOVZwYlYwRzdiZGIwRHNoN1RVVnp3cUlQ?=
 =?utf-8?B?TTMwR1NGd3hPbTlSOWE4dHlhaVpLTTJJYkhPcmVjSE82Um5VQTZXNldQa1JG?=
 =?utf-8?B?TXlxZkZRcFpPMFhuSmI3Z2c4Rm5VdEd6K003RFFFQTBpK0duNVZMWjkyTTdt?=
 =?utf-8?B?SEx6dGlTeStNLzQ5bGFKQUR6enhpV1BUTVBtSmo5RTBSemdtOW8xTVhuT3VR?=
 =?utf-8?B?SnVMUk5GZWR2eWxxWWc4cm95VnlQSmY2M0t0a3dQYlA3RjIycHIrQTAwandw?=
 =?utf-8?B?K3NsbWlicnpXRDEvdVRxbGh3cUhCVmVaREFxdEo0Y0t4QVc1aEFvbHNsQzZB?=
 =?utf-8?B?VE5rYlkwZXJNZktpZkpCd0pRZXB3amtZcm5KYXBWWm9GMHJoSCtFU1lUbzNj?=
 =?utf-8?B?blAvT1M2MVRJVmhxUi95S0JXTUFZNG5MUlhENGJ0UGtmcjF3NFFDKzIzZVBh?=
 =?utf-8?B?YUhWb3RiK3l5K1ZlNlN2a25mK2tYNVF5MW5UZjg1bklEUGdzT0hmZlBVSXBO?=
 =?utf-8?B?L1JzZzRqRkFIVXl0QjJ2anE1cDEwUm9oTi9MQklWSEZjUllVdktzL0N5YnJl?=
 =?utf-8?B?bFg0WEFDell2a29mTHRaYnI4WUdCbk5ab3VubnhpOVZkSzVqckU0eEM1amZN?=
 =?utf-8?B?ZWZxOHk2VjU5ZEk1U3N5elNGT2hjS1NjUmlneFVrQzBsRTllNTUyNWhnY0Vh?=
 =?utf-8?B?VGM4bzdldEVYTW5iSTJvLzh2dHpFemtablVIdXFNU2pXRWpiZTh4UTc0L0xT?=
 =?utf-8?B?dUlPZmw4ZiszVVlNcUpqUElqMzBCS1ZPenJuSWxjY2liQnYzTnRyU0NCMlFq?=
 =?utf-8?B?cWp1S3QvZTNCNG1Qak5qSGFDcklhampuQzZKZnNPVU91cWxyM2YyTHVRNmdX?=
 =?utf-8?B?OUZoK3FuSEZ6cW0rYXM4Q2Jxb0hyOUtUdU03czQ2RVRYM21JdGNpUWZEM0ZE?=
 =?utf-8?B?ZVZHbFByWE5xSVduSkNHN1VtNlhtV1pmNW4zbm9TUnNVOEVEVVgzWFdmdjlo?=
 =?utf-8?B?YnJmQnVrVHdobWI3Mlh3NEwvaEplV2FITkFXU3JoSUJYK0l5Ui9ZeHg0OU5m?=
 =?utf-8?B?cGZHeGF3OGxOS1ZMajVaSkdjMkZNdjRSNk1seHpvdWE4ejNZcFdneXFpd01Y?=
 =?utf-8?B?amw3azJ2WXFkT05zZE9IVkJMcVhiYTlaK2tWTHBOa0ErMG5zQnM2NlExOWxO?=
 =?utf-8?B?c0VVb2tjT2ltNnptWUYzdU0wQXNpR2U0cVB2Z2M3UGdxY2xlN2ZuNTNWM3dM?=
 =?utf-8?B?SWQ2UG1vZFY0TGpyY0NWWnUyckNTclZIaFhmT2pCR3BqRHdjSFcrMjZnbHlG?=
 =?utf-8?B?MkVFM2VnaW81NE1pcTAzTFVNRzhmcnQyZVpaZ29PRWFCd1FKNTk0NUEyOXRL?=
 =?utf-8?Q?AuAbVKw2gWA6Wv18eo507PsZu5XHufvfQm+skJr?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: a2247940-95f3-48c6-f76f-08d984124dee
X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 13:00:40.3229
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mYL5wjhzzVxzsCuMg4WcMyf7zpC5ZHYP/zDitTstwEAHzOwYKKoBdfaioEuB3FSOW6jk1Ov/6Tn+CWCOqvPbEuBXvNF3Q2CTlKxQWbQWiIM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB4436
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 30.09.21 14:57, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> Add the new property to disable the combined LED modes to the bindings
> documentation.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>  Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> index 0a3647fe331b..1ca11ab4011b 100644
> --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> @@ -31,10 +31,13 @@ Optional properties:
>  			  VSC8531_LINK_100_ACTIVITY (2),
>  			  VSC8531_LINK_ACTIVITY (0) and
>  			  VSC8531_DUPLEX_COLLISION (8).
> +- vsc8531,led-[N]-combine-disable	: Disable the combined mode for LED[N].
> +			  This disables the second mode if a combined mode is selected.
>  - load-save-gpios	: GPIO used for the load/save operation of the PTP
>  			  hardware clock (PHC).
>  
>  
> +

Sorry, this extra newline shouldn't be here of course.

>  Table: 1 - Edge rate change
>  ----------------------------------------------------------------|
>  | 		Edge Rate Change (VDDMAC)			|
>