Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210930113527.49659-1-mie@igel.co.jp>
In-Reply-To: <20210930113527.49659-1-mie@igel.co.jp>
From:   Zhu Yanjun <zyjzyj2000@gmail.com>
Date:   Thu, 30 Sep 2021 22:39:56 +0800
Message-ID: <CAD=hENdLYFGUaYWHbbwPd9kte5pHY6Vs8zjiDn0P8_AeeovCkA@mail.gmail.com>
Subject: Re: [PATCH] Provider/rxe: Allocate rxe/ib objs by calloc
To:     Shunsuke Mie <mie@igel.co.jp>
Cc:     Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        RDMA mailing list <linux-rdma@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 30, 2021 at 7:35 PM Shunsuke Mie <mie@igel.co.jp> wrote:
>
> Some rxe/ib objects are allocated by malloc() and initialize manually
> respectively. To prevent a bug caused by memory uninitialization, this
> patch change to use calloc().

Thanks a lot.

Zhu Yanjun

>
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> ---
>  providers/rxe/rxe.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c
> index 3533a325..788a1bbd 100644
> --- a/providers/rxe/rxe.c
> +++ b/providers/rxe/rxe.c
> @@ -104,7 +104,7 @@ static struct ibv_pd *rxe_alloc_pd(struct ibv_context *context)
>         struct ib_uverbs_alloc_pd_resp resp;
>         struct ibv_pd *pd;
>
> -       pd = malloc(sizeof(*pd));
> +       pd = calloc(1, sizeof(*pd));
>         if (!pd)
>                 return NULL;
>
> @@ -225,7 +225,7 @@ static struct ibv_mr *rxe_reg_mr(struct ibv_pd *pd, void *addr, size_t length,
>         struct ib_uverbs_reg_mr_resp resp;
>         int ret;
>
> -       vmr = malloc(sizeof(*vmr));
> +       vmr = calloc(1, sizeof(*vmr));
>         if (!vmr)
>                 return NULL;
>
> @@ -382,7 +382,7 @@ static struct ibv_cq *rxe_create_cq(struct ibv_context *context, int cqe,
>         struct urxe_create_cq_resp resp = {};
>         int ret;
>
> -       cq = malloc(sizeof(*cq));
> +       cq = calloc(1, sizeof(*cq));
>         if (!cq)
>                 return NULL;
>
> @@ -594,7 +594,7 @@ static struct ibv_srq *rxe_create_srq(struct ibv_pd *pd,
>         struct urxe_create_srq_resp resp;
>         int ret;
>
> -       srq = malloc(sizeof(*srq));
> +       srq = calloc(1, sizeof(*srq));
>         if (srq == NULL)
>                 return NULL;
>
> @@ -1167,7 +1167,7 @@ static struct ibv_qp *rxe_create_qp(struct ibv_pd *ibpd,
>         struct rxe_qp *qp;
>         int ret;
>
> -       qp = malloc(sizeof(*qp));
> +       qp = calloc(1, sizeof(*qp));
>         if (!qp)
>                 goto err;
>
> @@ -1659,7 +1659,7 @@ static struct ibv_ah *rxe_create_ah(struct ibv_pd *pd, struct ibv_ah_attr *attr)
>                 return NULL;
>         }
>
> -       ah = malloc(sizeof(*ah));
> +       ah = calloc(1, sizeof(*ah));
>         if (ah == NULL)
>                 return NULL;
>
> --
> 2.17.1
>