Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp561355pxb; Thu, 30 Sep 2021 11:52:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRxLJf88hgbDIAmThBHzzy/u+OLFPUwlBATEe/5Lr13j2ZYcPYntzadFg1O2jOfj4473kY X-Received: by 2002:a17:90a:e7ca:: with SMTP id kb10mr14755518pjb.33.1633027933451; Thu, 30 Sep 2021 11:52:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633027933; cv=none; d=google.com; s=arc-20160816; b=RzP79Q2b5bUgY72MOhqr0qHKgwR+eoXqgKMWOSn523KUBUPnKnFWLWherhkOiIGkEa 4GdwLoGGDaZgtv8GoNQDeGOAdviiWVpHoTzX22Vi4pl1RvV32jG7EV5hm69wP3VuYeTO CK/JOHcaLmtBzku1on/r2snP9R3TEYjmBSjVmxyQ4x+svKZwm4oHgeo+B5AkbqG5iluZ TxPaNoIO3fdwhRoRuUViCeTGZAg7p4rdAdWIIe7n3yz6m6paOzkZMghUq6mOD+G8S74Z 5wj9gaRbGoOqaO85elXeh//GQwIc1eyRj1tvhh5abfa0qS9qZneIzePIzzgWJWgGMmQJ Djkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=877Ha71iHssO25CJKc+gSb8Lag+SixQw7G9TABKqwwg=; b=CSZG33NKr5qf/ioZL8pmV2z4x0mph1qspMM3RuFJQrq4TBmoPF3OUqWXtk0dw5AqQS DNyrlLSxajxNk6fKeQa/+v2GnqyTY6jrTc2ib8d7/MUagPTxiYysAsmOgZZkGlKTePUm MqAPYQq65DRRLplKxLTs3ycwF0kEVE0g39/GyPy5UKOPcOea4XXqfk+oo61zOyt0KB8h DZXS/azTc4bunBbJtzBG9qwgd5fwqo/f+UF+nIMq4DdOe/JT6lzMcKNIC1+ps8+7XuMf KROss9CC+vkNtt08Hphg8IqYS3Q8bMY/CVKCk7/zqkrCmBS9OZzPUt9oSEjdOoGZgbWz lxCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si4458865pls.254.2021.09.30.11.51.59; Thu, 30 Sep 2021 11:52:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343595AbhI3PZm (ORCPT + 99 others); Thu, 30 Sep 2021 11:25:42 -0400 Received: from mga04.intel.com ([192.55.52.120]:55863 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343577AbhI3PZl (ORCPT ); Thu, 30 Sep 2021 11:25:41 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="223323356" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="223323356" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 08:23:58 -0700 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="555816408" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 08:23:57 -0700 Received: from andy by smile with local (Exim 4.95-RC2) (envelope-from ) id 1mVxub-007Bh5-Jg; Thu, 30 Sep 2021 18:23:53 +0300 Date: Thu, 30 Sep 2021 18:23:53 +0300 From: Andy Shevchenko To: Daniel Palmer Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250_dw: Mark acpi match table as maybe unused Message-ID: References: <20210930124950.3069638-1-daniel@0x0f.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210930124950.3069638-1-daniel@0x0f.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 09:49:50PM +0900, Daniel Palmer wrote: > When building kernels without ACPI support the table is declared > but is not used because ACPI_PTR() turns it into a NULL. Okay. > Add the __maybe_unused attribute to stop the compiler whining. And incorrect fix. See my patches regarding to the topic (`git log --grep ACPI_PTR`) and do accordingly, i.e. drop ACPI_PTR() for good. -- With Best Regards, Andy Shevchenko