Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [smartpqi updates PATCH V2 08/11] smartpqi: fix boot failure
 during lun rebuild
To:     Don Brace <don.brace@microchip.com>, hch@infradead.org,
        martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
        linux-scsi@vger.kernel.org
Cc:     Kevin.Barnett@microchip.com, scott.teel@microchip.com,
        Justin.Lindley@microchip.com, scott.benesh@microchip.com,
        gerry.morong@microchip.com, mahesh.rajashekhara@microchip.com,
        mike.mcgowen@microchip.com, murthy.bhat@microchip.com,
        balsundar.p@microchip.com, joseph.szczypek@hpe.com,
        jeff@canonical.com, POSWALD@suse.com, mwilck@suse.com,
        pmenzel@molgen.mpg.de, linux-kernel@vger.kernel.org
References: <20210928235442.201875-1-don.brace@microchip.com>
 <20210928235442.201875-9-don.brace@microchip.com>
From:   john.p.donnelly@oracle.com
Message-ID: <700a1f15-5d26-31b5-1a2e-b733883fcac3@oracle.com>
Date:   Thu, 30 Sep 2021 13:24:08 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20210928235442.201875-9-don.brace@microchip.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1A2VnBWbXVWajhIaGJlZ0dlM3FseGhsSkJCVmhWc0xZRlFIZ2M1WkVRL0NL?=
 =?utf-8?B?aVpnN2thZmVFUlZWeHk4ZFBsN1JwdEF2SmNpSHZvNUtlTDZRbXFINDUxblkz?=
 =?utf-8?B?bldlNnhTMVRWWTZWUFJiWUNuOHVEUllVbWRiaEdhUWhZRm9vOWgzN3JUaUh0?=
 =?utf-8?B?Q29TeVIwb0ZFYVZWUUNiTlV6STVOWUwyRWduZ0hlU2x0TzFib0hxTVNWTEpk?=
 =?utf-8?B?OVhLdEhvRjhDS0U3Q2wwQ1lPNFpITE9BdnQ5R3M1cWNUcnhUVTM3QmV3ME5M?=
 =?utf-8?B?TWJxMkpWaUFORVpWQXdlVitQZ0NKL1YzOHlIRitXRlhDZHBhSEJtUHd6Z053?=
 =?utf-8?B?OE91bXpEelV3YnI5bW9WelBhMTNCNEQxVWx1ZEdCMnZzRmlCK2N0b0F2c0Vu?=
 =?utf-8?B?WVQxc3ZLVUZiRktiVERRK2JteTZib01zMi9Ob2Z0MVl4SjhzZUl5Qjd0Q0s4?=
 =?utf-8?B?WnliZG9YeEpEY2ZCNnZWM0pYTkZxVkwrK2h1QWlNa0k0OWJyMkV3SjExQVQ4?=
 =?utf-8?B?WHEwUE1ITkdTUWxiQkdCSGczQktSR1hGTzlKd0xQTEZhaEw1T1MyZHB4SU5n?=
 =?utf-8?B?NFRoeHlWd3hJYUVsVTh3Nno3Y0Z5ZXpZMlhyMHFHN1VpdmpmMXNZbzFRTHIx?=
 =?utf-8?B?Vm13Nitteno2bzBMWHhuV0ZmSzltaER0QThnVVVxMjB3TU5WaDRpZnpqeGRR?=
 =?utf-8?B?SFdON0k5bnFRV3JxMUwzQnFJTnUyT29ia1BkcGZkMmV0QXROYWJaYURCaWt0?=
 =?utf-8?B?RnJ6UWx6SUJQNWd6TWR0SmZFdzVaRVl6Z3BYMU16cVY0SWx2MzB0NnJaRTJW?=
 =?utf-8?B?eVBuUWF2aW41QWwzL0lTL1IzalU5NERCTEwvWFdvV3pEakpQbXpMNkZURjk1?=
 =?utf-8?B?WWhmajMwdUxmOVVHU09Cdm45Qk5tL2U4R3dRd1pablhhQmZIYWNaOVM4cmtB?=
 =?utf-8?B?RWtqbmE1bkZnRGlTT0tCVzRKaHI4NVpma3BpTmV5TWhsU1B6a29WZmE1U0JQ?=
 =?utf-8?B?QXpBZHNNMEh4anM2cmxzTkphRms4WTM5eU53WHZlei96T3phc2lCbTNCbWhC?=
 =?utf-8?B?TFFiQlNvSlhvTWNzNmh0dUJtc2NaeGZ0cXdTWWI1KzVJTWxGeGVnNTIveW44?=
 =?utf-8?B?a0J1djVpQTc1R2NRN29vbXVnY3NmY1ptN0tBRmxYSDNWc3h4cEZSdTBxVndn?=
 =?utf-8?B?UXd3aEZLR1ZqR2ZlbzJ4SFhzcHJ6cHRha2dpcGo2MDRxcGVUblZiekh5bnJ1?=
 =?utf-8?B?WFpHUUhMemYwYjBxMDdoQWVXdUNUV0d5elROTVVFYjBkTWhpcjBFaXJVMjVi?=
 =?utf-8?B?UXpWc2VJTXZKKzhBajV4b3JQQUVPZFZCM3U0SVQ0S3I0eHptelJ2S3ZuM0hw?=
 =?utf-8?B?SnJuNmdEVGNyNnFML2htTU82VUd6bkdjTGtFMjJKUC9mTmt6Ny90VzZtcFF4?=
 =?utf-8?B?b3J2S2hzSFZVdGlGWEMrdVF0U253NVF2Wk5hQVVjS1NKaERkdUxJdEpNb3o4?=
 =?utf-8?B?TkYxNjEvWGpTUXAxanNpZ0sweWVHNUNReVVyaDdzUytKVDA5Wm84Q3pPYTAw?=
 =?utf-8?B?aXhFZWZlenBKcC9nZUlHK1lrZ3dRY0xVT2Z6TUV5VXhGbzBXZFoydE10SElq?=
 =?utf-8?B?NTFPdjliUDVCenRlREZiVFdKdDRrdlEwYXR1ZDJsWU1pcEkwVC9GdDIrYmx5?=
 =?utf-8?B?dFlaelZ6RDRTOHNxVlRIMXFiSjJQZ1QwUEVzYm5qSTN0RnhGMER2LzV1OEZu?=
 =?utf-8?Q?6IVJtxsVfUVL6YQzDkLlxX114t8rvfunmCvKECs?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b7f8e4a-7b00-4623-610c-08d9843f8147
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 18:24:13.7416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WH+cKUt3M00xpbbzTlOYlJL1xnBZupzHGPJM7uJEyPqcD3KzlVhZuoKpaP/xKDhmZHjs1J2PWQ0uiuOi2dYXn8iXhCG9pOGW/NRevc28Rh0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB2032
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10123 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109300112
X-Proofpoint-GUID: Z1fsUfCMVoeqFx6gGVuSq4xKp7EZotcT
X-Proofpoint-ORIG-GUID: Z1fsUfCMVoeqFx6gGVuSq4xKp7EZotcT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/28/21 6:54 PM, Don Brace wrote:
> From: Mike McGowen <Mike.McGowen@microchip.com>
> 
> Move the delay in the register polling loop to
> the beginning of the loop to ensure there is always
> a delay between writing the register and reading it.
> 
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Signed-off-by: Mike McGowen <Mike.McGowen@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>


Acked-by: John Donnelly <john.p.donnelly@oracle.com>


> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index 1e27e6ba0159..c28eb7ea4a24 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -4278,12 +4278,12 @@ static int pqi_create_admin_queues(struct pqi_ctrl_info *ctrl_info)
>   
>   	timeout = PQI_ADMIN_QUEUE_CREATE_TIMEOUT_JIFFIES + jiffies;
>   	while (1) {
> +		msleep(PQI_ADMIN_QUEUE_CREATE_POLL_INTERVAL_MSECS);
>   		status = readb(&pqi_registers->function_and_status_code);
>   		if (status == PQI_STATUS_IDLE)
>   			break;
>   		if (time_after(jiffies, timeout))
>   			return -ETIMEDOUT;
> -		msleep(PQI_ADMIN_QUEUE_CREATE_POLL_INTERVAL_MSECS);
>   	}
>   
>   	/*
>