Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp602462pxb; Thu, 30 Sep 2021 12:51:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB9/qpUdmOdViNZi+gs6O1pSjhVaQJlX+5XYbOQ1VFByg0Mpv7qvoE1QQOvWMsxYRDRk74 X-Received: by 2002:a17:906:6403:: with SMTP id d3mr1263157ejm.37.1633031475572; Thu, 30 Sep 2021 12:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633031475; cv=none; d=google.com; s=arc-20160816; b=NUp0n6TkGfM41oy0r09mkaILp9/Oy1lm6gADfOnhRnDvrbg+zHENzZHGzqPDnhX9Xr HBbXN6AHGJj5QMp68fxUY69qhSvxMKnxebW9FtIiNi9CTXPfY5wMpodLBIj6z1s+nwU9 B0YH6oY1veeEyn6QPNal3a/OnTdOxcQ8ctKIvlpOLA/3DZGIhSaEvBt9+uz7Cr3nhEkI NPp1QsUPAQwxUslIUsdDEM0wTd4GNacg+P0D/e63D/kjUB+0WjPLvOP9jl8MAsI2GUKS yILK9TbRDXAndOp0lwCmDKx5o/gYWu71d1dIQQuyUjEOvt+ulEv8MMGh2ex2JD8ghgjx mn3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=sq8sxX34+Grk9aluOB8rkcRM/zE/YFO/Um/RRIXvef8=; b=uvN8nN0/fQxf+4ySIq4QaWPk1xJDNhvh58B8EVydhue2KcJIXaMBG1yA7S78bVgMrN 34x/tb3wVBBSZWs+/cGHaB+8nQnnzm3mdqm11EnpYBDqIbgalJQSOf+71RfNJptT+QCS gTtyvQHPmscLivQnpVOVQTO3w3yZUS5saDavoGTKRRIp6oBOZgQ3PGrvRITtnc0I8baf Dq8hNRMns6vZeKKy3FogOAcFXAUETipBDujnNUbzrk4MlmeYwIHd/4cLh/TH4vQn1yW9 Bd5MzvY48xyeQsR9euJxSu2WT36QC3fkjcXWMaDIQ58Az/9I9MTEVEvIQn/s8TKdlPHn s5lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b="s/T3Wxfq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n1si4726988ejg.619.2021.09.30.12.50.49; Thu, 30 Sep 2021 12:51:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b="s/T3Wxfq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346175AbhI3TGn (ORCPT + 99 others); Thu, 30 Sep 2021 15:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346154AbhI3TGm (ORCPT ); Thu, 30 Sep 2021 15:06:42 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DE95C06176A for ; Thu, 30 Sep 2021 12:04:59 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id c4so4714278pls.6 for ; Thu, 30 Sep 2021 12:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sq8sxX34+Grk9aluOB8rkcRM/zE/YFO/Um/RRIXvef8=; b=s/T3WxfqzLIySudeP/owpLxq0XbQ9h42h5F7XrkwCn4prX8sTpXGFoMMBQEd83MEIO PqCfeU5PCR/yXXo8r2wkJsenE9iYQW3XUGx9MxaLkqME25QYBbLFpQJYiWOn4hiRACoh TJTllOTyNgPfQ7b9UG0eAMROQIsdnsOOQLeGFOHh4nt4wRQ+vrnlctfEQ08G98STFuWP qLdkCHCNKhyiGBu0trjL4UwUD50kT9W2dH5iUiz2nPBj+9HEjuN51lacErFVKXtN9JSC xcQDxkXyP+/M/tLt4zoE3m/gxpHZUzIDNDdNOIfZ/PDoN/MMbSNvUBl5RG6cxna3nM0m Z6+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sq8sxX34+Grk9aluOB8rkcRM/zE/YFO/Um/RRIXvef8=; b=n7WvoUieneKLnm9dCgFISzZ6i9NuXhEWwy9h9ipuTYQR1dkTNa2ZRD+8agTW3v6HUi fSw9SO87k6vk8gWhKZ7iJBHxCMujjbebOnGEUwgVwxqtv92/3xVZo6PoMY/z5v/oeMKL MaknkFXIYV8nUL7WAD/GLFMkywSKRTEu8kUh/WtRj0B/IZVRlOefKMrBJb+gJ9vzuyEx siTuZqUWv/5ZUOvRxcv49I+K14RsPe7rPru7libkv9WOoyBZDkGz0tbCfzUTFYC+c3Yd Bn4MHYXeNvsneBM+i5LWMlmo1Gw0NhIt60i89rweZXLhDchnPbNBleELJHVLlX01RpMF qAgg== X-Gm-Message-State: AOAM533gdpULnU4B5DXPi2S3CWOqpQq43gVnKiXodour9+BVoKjn2+Iy 1EqbLpwPbzipRvrwKgggPGNaH+xzOOKD0DVvOAEiSw== X-Received: by 2002:a17:90b:3ec3:: with SMTP id rm3mr7268323pjb.93.1633028698606; Thu, 30 Sep 2021 12:04:58 -0700 (PDT) MIME-Version: 1.0 References: <20210930010511.3387967-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930010511.3387967-2-sathyanarayanan.kuppuswamy@linux.intel.com> In-Reply-To: From: Dan Williams Date: Thu, 30 Sep 2021 12:04:48 -0700 Message-ID: Subject: Re: [PATCH v2 1/6] driver core: Move the "authorized" attribute from USB/Thunderbolt to core To: Yehezkel Bernat Cc: Kuppuswamy Sathyanarayanan , Greg Kroah-Hartman , Borislav Petkov , X86 ML , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Andreas Noever , "Michael S . Tsirkin" , Michael Jamet , "Rafael J . Wysocki" , Mika Westerberg , Jonathan Corbet , Jason Wang , Andi Kleen , Kuppuswamy Sathyanarayanan , LKML , Linux PCI , USB list , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 11:25 AM Yehezkel Bernat wrote: > > On Thu, Sep 30, 2021 at 6:28 PM Dan Williams wrote: > > > > On Thu, Sep 30, 2021 at 4:20 AM Yehezkel Bernat wrote: > > > > > > On Thu, Sep 30, 2021 at 4:05 AM Kuppuswamy Sathyanarayanan > > > wrote: > > > > > > > > no functional > > > > changes other than value 2 being not visible to the user. > > > > > > > > > > Are we sure we don't break any user-facing tool with it? Tools might use this to > > > "remember" how the device was authorized this time. > > > > That's why it was highlighted in the changelog. Hopefully a > > Thunderbolt developer can confirm if it is a non-issue. > > Documentation/ABI/testing/sysfs-bus-thunderbolt does not seem to > > answer this question about whether authorized_show and > > authorized_store need to be symmetric. > > Apparently, Bolt does read it [1] and cares about it [2]. Ah, thank you! Yeah, looks like the conversion to bool was indeed too hopeful. > > [1] https://gitlab.freedesktop.org/bolt/bolt/-/blob/130e09d1c7ff02c09e4ad1c9c36e9940b68e58d8/boltd/bolt-sysfs.c#L511 > [2] https://gitlab.freedesktop.org/bolt/bolt/-/blob/130e09d1c7ff02c09e4ad1c9c36e9940b68e58d8/boltd/bolt-device.c#L639