Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp617294pxb; Thu, 30 Sep 2021 13:13:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeaXo8Lhh1yI3syGJAGBYyjY+dzLV4a0hydF92aVTi+UZAZOVCoCfG9X9feGfxNoY+KXwF X-Received: by 2002:a05:6a00:1142:b0:43f:75ae:5084 with SMTP id b2-20020a056a00114200b0043f75ae5084mr7424419pfm.6.1633032796065; Thu, 30 Sep 2021 13:13:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633032796; cv=none; d=google.com; s=arc-20160816; b=uRNCfod4A1QnvI/+T7oQMKCOD/FT6ZB3mRzliPBAC8XhajQJ08fuWniqZOvl4csfdk d3OOVVEQhoI4gQYSwH90wIBsO/7TsembWsyozVk4PCiw3ThISILMK1T7Pszm8XpQ+9ab d6M6nbYrPxPEtf/ysg5z7o8BUAAVr1/S3GNfke9dHYCNZoMkqXw1UAEvt+jZLenkSCjt vp2Z410k+cczYqerFTUvhZSUSDjG5/Npkj+3urwwfQ/YsPNnzVATV48OXs0ZmK2NP/fh dSliBKSKgUFNUFAI5UzFjd7aHPRsUqvR9Hqlbz8KnP4nkPGF7BbvWaWIt+5T1Q9Ue0L9 xDcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=fNl0c2wQy+Z+r6yaY4In778hjm56K+CLdVg2tfv45I8=; b=DZFAKRGhcop9RVwdliMfr8MUzRgIz3L5Wp3Z+A29it+CypFNTV5G3U6CCAuOC1uT8u ma2SwGJS7hTai6+WPoAiXt0BXB5GkoUVW9RQjnDWgqxl79X3O207qNEb6xplywoGTO6t 4CXsHQT+7sgc70Iu4GzZESMSGVCSKkL/SSeIgXgYuXVmtf6hrt7gGZJcKbSxYCl8ctGO BSOX5LvemTc3tCm5fI6N2IvHu8+KqvP8iuxoUyoAKfLsX8aqS3cRVKNC0jolCw4TVlWs cJsOjdBlZXdCwnif5uIR055Ooe7uUV1erBQZck0DbSV+kxw0SxpWGIReZlauGA1xe9ex 7sMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x1si4773818pjd.127.2021.09.30.13.13.01; Thu, 30 Sep 2021 13:13:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347542AbhI3TwM (ORCPT + 99 others); Thu, 30 Sep 2021 15:52:12 -0400 Received: from mga06.intel.com ([134.134.136.31]:34250 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345816AbhI3TwE (ORCPT ); Thu, 30 Sep 2021 15:52:04 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="286294774" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="286294774" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 12:50:16 -0700 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="480065078" Received: from rnmathur-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.212.105.173]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 12:50:15 -0700 Subject: Re: [PATCH v2 1/6] driver core: Move the "authorized" attribute from USB/Thunderbolt to core To: Dan Williams , Yehezkel Bernat Cc: Greg Kroah-Hartman , Borislav Petkov , X86 ML , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Andreas Noever , "Michael S . Tsirkin" , Michael Jamet , "Rafael J . Wysocki" , Mika Westerberg , Jonathan Corbet , Jason Wang , Andi Kleen , Kuppuswamy Sathyanarayanan , LKML , Linux PCI , USB list , virtualization@lists.linux-foundation.org References: <20210930010511.3387967-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210930010511.3387967-2-sathyanarayanan.kuppuswamy@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: Date: Thu, 30 Sep 2021 12:50:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/21 12:04 PM, Dan Williams wrote: >>> That's why it was highlighted in the changelog. Hopefully a >>> Thunderbolt developer can confirm if it is a non-issue. >>> Documentation/ABI/testing/sysfs-bus-thunderbolt does not seem to >>> answer this question about whether authorized_show and >>> authorized_store need to be symmetric. >> Apparently, Bolt does read it [1] and cares about it [2]. > Ah, thank you! > > Yeah, looks like the conversion to bool was indeed too hopeful. > IIUC, the end result of value "2" in authorized sysfs is to just "authorize" or "de-authorize". In that case, can the user space driver adapt to this int->bool change? Just want to know the possibility. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer