Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH 1/1] driver core: use NUMA_NO_NODE during
 device_initialize
To:     =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>
CC:     <hch@infradead.org>, <linux-kernel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <stefanha@redhat.com>,
        <oren@nvidia.com>, <linux-pci@vger.kernel.org>
References: <20210930142556.9999-1-mgurtovoy@nvidia.com>
 <YVXMifT1hdIci1cp@rocinante>
From:   Max Gurtovoy <mgurtovoy@nvidia.com>
Message-ID: <edbc96e3-20de-d8f1-7b65-29f4c8e9408b@nvidia.com>
Date:   Thu, 30 Sep 2021 17:51:36 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YVXMifT1hdIci1cp@rocinante>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 14:51:42.5182
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ac64dda-e88c-4da7-2203-08d98421d11f
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT038.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2511
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/30/2021 5:41 PM, Krzysztof Wilczyński wrote:
> Hi Max,
>
>> Don't use (-1) constant for setting initial device node. Instead, use
>> the generic NUMA_NO_NODE definition to indicate that "no node id
>> specified".
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>   drivers/base/core.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/core.c b/drivers/base/core.c
>> index e65dd803a453..2b4b46f6c676 100644
>> --- a/drivers/base/core.c
>> +++ b/drivers/base/core.c
>> @@ -2838,7 +2838,7 @@ void device_initialize(struct device *dev)
>>   	spin_lock_init(&dev->devres_lock);
>>   	INIT_LIST_HEAD(&dev->devres_head);
>>   	device_pm_init(dev);
>> -	set_dev_node(dev, -1);
>> +	set_dev_node(dev, NUMA_NO_NODE);
> We might have one of these to fix in the PCI tree, as per:
>
>    https://elixir.bootlin.com/linux/v5.15-rc3/source/drivers/pci/pci-sysfs.c#L84
>
> Would this be of interest to you for a potential v2?

sure no problem. Lets get some reviews first and then I'll send v2 with 
this patch as well.


> 	Krzysztof