Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] m68k: introduce a virtual m68k machine
To:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        linux-rtc@vger.kernel.org, Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
References: <20210323221430.3735147-1-laurent@vivier.eu>
 <20210323221430.3735147-3-laurent@vivier.eu>
 <a9c75ae7-6023-6b6c-260f-a0d6841ea4fa@vivier.eu>
 <CAMuHMdW49S_81Oip2p+yUO5YUL1-V3_K_C1WEXux7mQWcb-mKA@mail.gmail.com>
 <c28b0c92-a997-6978-890f-4222f4bb8cc6@vivier.eu>
 <9f7ad0df-b58c-1b24-5c48-5ee6478260dd@physik.fu-berlin.de>
From:   Laurent Vivier <laurent@vivier.eu>
Message-ID: <7748de16-1087-1039-a1cc-5a94dc293dbb@vivier.eu>
Date:   Thu, 30 Sep 2021 23:01:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <9f7ad0df-b58c-1b24-5c48-5ee6478260dd@physik.fu-berlin.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 30/09/2021 à 22:56, John Paul Adrian Glaubitz a écrit :
> Hi Laurent!
> 
> On 4/28/21 14:15, Laurent Vivier wrote:
>>> I have tested and reviewed your patch, great work!
>>> I'm confident this can make v5.14, with the small nits fixed.
>>
>> Thank you for your review.
>>
>> I will answer to some of your comments and update accordingly my patch.
> 
> It looks like this patch somehow fell off the table, didn't it?
> 
> I was hoping to be able to build a virt kernel for Debian/m68k by default
> in the near future.

Yes, I started to update my work according to the comments from Geert but didn't have time to finish.

Especially I tried to remove the LEGACY_TIMER_TICK, but it doesn't work, and as it has been tested
like this by you and most of the other m68k targets uses it I think I will let the patch with it.

I'm going to update my patch to have a v2, at least to have fresh reviews.

Thanks,
Laurent