Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 00:04:12 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Daniel Palmer <daniel@0x0f.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250_dw: Mark acpi match table as maybe unused
Message-ID: <YVYmTL8WsgYnxPwc@smile.fi.intel.com>
References: <20210930124950.3069638-1-daniel@0x0f.com>
 <YVXWiQWGkzmp6O1A@smile.fi.intel.com>
 <CAFr9PXkgDaXPb+h3TFmS4VVzzmPqjJJj0Y4cd_ZTUgqMbNZUSA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFr9PXkgDaXPb+h3TFmS4VVzzmPqjJJj0Y4cd_ZTUgqMbNZUSA@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Oct 01, 2021 at 12:31:34AM +0900, Daniel Palmer wrote:
> On Fri, 1 Oct 2021 at 00:24, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > And incorrect fix. See my patches regarding to the topic
> > (`git log --grep ACPI_PTR`) and do accordingly, i.e. drop
> > ACPI_PTR() for good.
> 
> Something like 349bff48ae0f5f8aa2075d0bdc2091a30bd634f6?
> 
> Doesn't this mean the ACPI table ends up in kernels that will never use ACPI?

Yes. Is it a problem (*)? If so, you need to use ifdeffery, since __maybe_unused is
not for the ID tables.

*) while justifying this you also need to show why it's a problem specific
to the ACPI IDs and not a problem for OF ones, which we have tons of in the
Linux kernel without any guards (ifdeffery).

-- 
With Best Regards,
Andy Shevchenko