Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [smartpqi updates PATCH V2 06/11] smartpqi: avoid failing ios for
 offline devices
To:     Don Brace <don.brace@microchip.com>, hch@infradead.org,
        martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
        linux-scsi@vger.kernel.org
Cc:     Kevin.Barnett@microchip.com, scott.teel@microchip.com,
        Justin.Lindley@microchip.com, scott.benesh@microchip.com,
        gerry.morong@microchip.com, mahesh.rajashekhara@microchip.com,
        mike.mcgowen@microchip.com, murthy.bhat@microchip.com,
        balsundar.p@microchip.com, joseph.szczypek@hpe.com,
        jeff@canonical.com, POSWALD@suse.com, mwilck@suse.com,
        pmenzel@molgen.mpg.de, linux-kernel@vger.kernel.org
References: <20210928235442.201875-1-don.brace@microchip.com>
 <20210928235442.201875-7-don.brace@microchip.com>
From:   john.p.donnelly@oracle.com
Message-ID: <c042f1af-678c-f635-9020-3d66ad755901@oracle.com>
Date:   Thu, 30 Sep 2021 13:23:27 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20210928235442.201875-7-don.brace@microchip.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnhDRGZSMUxCUlB0Vy9USko4OXVZY0J1SkQ5MTVZeFJvSHJhRE1XRnlGUG9q?=
 =?utf-8?B?dFNvTTdNVHhWR0diTURaczVER1ViZFdXbWxuWG40UndyaE80QVRyUktCYVpL?=
 =?utf-8?B?b0U1Ny9jaHVaTlpFUWtzeGVENXJ2dGFNNlVaQXpTcmRsM1V1cUZITVZOWkFX?=
 =?utf-8?B?cDh4bTBsMGpGN3JiU0xvYi9QZVNzSXpHbmFnSHZDQjJ4RmJQaENPaUM3WEgr?=
 =?utf-8?B?N3g5eXIrVkFJcUROckdOOENTMFlCOXF5a3d4WFNNdGxMUnc4QlZuekkxZW83?=
 =?utf-8?B?S25EQVBjY3VXNkdrWXpYR3pzZVRkR1hCejFkeTRGVlNVTCt6M2RVbHc1Sk5S?=
 =?utf-8?B?b1grZEZUVDd4VFdXNzM1UUlYQmRqV2ZUaURpRTlQUjNhNC93L3NQRzNqYU9C?=
 =?utf-8?B?NGV1MDc2dDBGU216Qzc1d0VhY1VvbVA2V2dZK0ZrWnJ6eUY1OFFsMWJOR0kw?=
 =?utf-8?B?S2Y0S3lMTGRFajNrbVZJZkN3RU1EOTJMVG9tTjBoWUsxRnhsZUVSc3lEQ0Za?=
 =?utf-8?B?MHZFaDR6UWRrdUVESGZZTG91Nk10T3R5RndXM0xTazdZd2lsMkUwMW82M1ov?=
 =?utf-8?B?L0VpZmIwdnI1dkgxdWowbEtVc3NXemZmeDkxUjVZdUxwQ3BCZVJqOEdXMzZi?=
 =?utf-8?B?d0xtd3JJcnFrRVNQNmVHaGxPbi9jRjdrQTlUd28yNEtvMmo3M1dybG4waXFq?=
 =?utf-8?B?bUVMazZDdVZ1NmRmRGlYVTVCNGlhMFRjUzlsVnQxMVhwYmx0MTdUL1FkOWoy?=
 =?utf-8?B?dHlkY1N5am5pNHcxNWF4TTU3VXFXTGk1MmxzNXZuQlhnMDJUZkFIRGFNOGU3?=
 =?utf-8?B?UGhkT1RXNUxjbElYdzFDa0l3bWJzcG41RTN3akx1K3gyWTRBTENUNUhNeTJJ?=
 =?utf-8?B?eGFUZTNSeTBJQnI2V2VUREMwMDNKa3UrVzNWVFV4eElFcVRBeHhvbU5KcTBO?=
 =?utf-8?B?ZFBOOWljc1F4YzZ4d3hJOU9QNkh4dTRIdXhPdHZkRGdZV2o3V1hWdk4vOXhL?=
 =?utf-8?B?dmt1ZXJtRjljaU0zdlc4OXh0VW1sencyazhsL1pxMThrTGtKVk5rN0xVNUNY?=
 =?utf-8?B?K0ZScTV6QWlKQ0h1RXljb2ZYazZ1MjZ0MHNLTk9kRlBmUnA3aHM0ZVIxa2VP?=
 =?utf-8?B?VGd4Y0JZUVFZelYwZlcvNDdFakdHSitHU3diQkp5OXhOYjFJRmhLbjREWGFy?=
 =?utf-8?B?b0o1UktqcFhhTWNjQnBtcVpTSlVvazdtb2FzdUtrVFdyY25KWTV3encwbkE1?=
 =?utf-8?B?OWRuRlJoZDlldXNUTndtbjBLRlRDamVtZktGR1JMcUwzV0RKaDBJTHdCRDV3?=
 =?utf-8?B?aUR1ekVib3BmZUpZVWR2Z2lzUXgvUGVtTlI2RUlXTzIyRldkZVBMVVAzYzFs?=
 =?utf-8?B?TmhWemlibW4xODJEYm5ZN0RRRkpmdFhsZS9INDh3alQxMzMyY2EyajF4MVFV?=
 =?utf-8?B?RzNhOExHK2RtT0h5ZDZ6L0FaUjlIUGc4akpkOHRDU1ZJbkJkL01Ka1JzS2ZE?=
 =?utf-8?B?Ly9tcE9nNkgyTWgvamNKTDNiSXk0bTE5NUw1RHQvZFJpOUhvQUI0SGJnN0Jk?=
 =?utf-8?B?WXgxQTVtQzViSUhFZXJyQWI4QjFkTHZBVXJ5VWNraFkvdXc5a2MvQzZOWlAz?=
 =?utf-8?B?Z2I0emd6bjNOUWhtQjNkMUVGZ1MxZFdzV1JCckNiMmRvNEZjKzUyUW9HelFB?=
 =?utf-8?B?NDhCYWE2ampxd211QUcxa29PZUJkRmJuYjZTTTM3cnp4RnRiNTZueEZaQlVo?=
 =?utf-8?Q?G/yOH+36EeUg/xyenorQG/jHv/aFNiRpl+FqIfw?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d8ee392-dcfe-4fb4-646e-08d9843f691b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 18:23:33.1870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qPbzFV2ISgpvTmzc0al4Dgd9K+va5f3GSRR8t2WkcEGGcQfsDRBmlIs2lIqqy/lSDNpGdR9zX+DZgjrEP8n4Upx8e+pIoIxmYR/fv5o3C38=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5539
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10123 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109300112
X-Proofpoint-GUID: NwmNP4pk4YdKMrnK3o_R2MP_9w9Uu7dy
X-Proofpoint-ORIG-GUID: NwmNP4pk4YdKMrnK3o_R2MP_9w9Uu7dy
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/28/21 6:54 PM, Don Brace wrote:
> From: Mahesh Rajashekhara <mahesh.rajashekhara@microchip.com>
> 
> Prevent kernel crash by failing outstanding I/O request
> when the OS takes device offline.
> 
> When posted IOs to the controller's inbound queue are
> not picked by the controller, the driver will halt the
> controller and take the controller offline.
> 
> When the driver takes the controller offline,
> the driver will fail all the outstanding requests which
> can sometime lead to an OS crash.
> 
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Signed-off-by: Mahesh Rajashekhara <mahesh.rajashekhara@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>

Acked-by: John Donnelly <john.p.donnelly@oracle.com>


> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index 838274d8fadf..c9f2a3d54663 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -8544,6 +8544,7 @@ static void pqi_fail_all_outstanding_requests(struct pqi_ctrl_info *ctrl_info)
>   	unsigned int i;
>   	struct pqi_io_request *io_request;
>   	struct scsi_cmnd *scmd;
> +	struct scsi_device *sdev;
>   
>   	for (i = 0; i < ctrl_info->max_io_slots; i++) {
>   		io_request = &ctrl_info->io_request_pool[i];
> @@ -8552,7 +8553,13 @@ static void pqi_fail_all_outstanding_requests(struct pqi_ctrl_info *ctrl_info)
>   
>   		scmd = io_request->scmd;
>   		if (scmd) {
> -			set_host_byte(scmd, DID_NO_CONNECT);
> +			sdev = scmd->device;
> +			if (!sdev || !scsi_device_online(sdev)) {
> +				pqi_free_io_request(io_request);
> +				continue;
> +			} else {
> +				set_host_byte(scmd, DID_NO_CONNECT);
> +			}
>   		} else {
>   			io_request->status = -ENXIO;
>   			io_request->error_info =
>