Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [smartpqi updates PATCH V2 09/11] smartpqi: fix duplicate device
 nodes for tape changers
To:     Don Brace <don.brace@microchip.com>, hch@infradead.org,
        martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
        linux-scsi@vger.kernel.org
Cc:     Kevin.Barnett@microchip.com, scott.teel@microchip.com,
        Justin.Lindley@microchip.com, scott.benesh@microchip.com,
        gerry.morong@microchip.com, mahesh.rajashekhara@microchip.com,
        mike.mcgowen@microchip.com, murthy.bhat@microchip.com,
        balsundar.p@microchip.com, joseph.szczypek@hpe.com,
        jeff@canonical.com, POSWALD@suse.com, mwilck@suse.com,
        pmenzel@molgen.mpg.de, linux-kernel@vger.kernel.org
References: <20210928235442.201875-1-don.brace@microchip.com>
 <20210928235442.201875-10-don.brace@microchip.com>
From:   john.p.donnelly@oracle.com
Message-ID: <30179417-5aef-5055-c6ee-6aca0d5985c3@oracle.com>
Date:   Thu, 30 Sep 2021 13:24:31 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20210928235442.201875-10-don.brace@microchip.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnU5UkY2aDFqUldvdnVzWDZBdFg0SmxJMVlQTGJHeEtrTDlsV3pvUlhpM24r?=
 =?utf-8?B?WTRCSDhCZ2hzNWYrTXluMk81T1hwRlgwSnBqdjFvYjZOSldzVjV1N0loK2tX?=
 =?utf-8?B?K0hRSTJ5dUN1bnBvOWQ4bXVFQ3l1Uzc2TlQ5d2FIZkFMRVZlV0U4RW52TjhF?=
 =?utf-8?B?bnhEbjcrWFYwOEhCNmtXVHREK3hyb3VyeHdBMjlBNlgxN3lGZVA4OVZCR2N0?=
 =?utf-8?B?NVo1ODFEbzE4RW9HdkE4dXFVWlJZME9IUm9BOTlEbkl0aXVQNmMxYTJSSnhp?=
 =?utf-8?B?Nm1IYXg5aXhXN0tsQ0ljM2paeWxCdGcydkV0cG1jcDIvazdYRGNTSDF2M2Q0?=
 =?utf-8?B?b2szQ2ZTME52bk8vY1ZTKzBjQ3Mvdk5wTVNSa25NZC9WV2lzeGRzaDBmM3k4?=
 =?utf-8?B?WmJpL0d6R0dDYjRWcWVhSm9kVUtHelNYVGFqY2hMdXZaV05nQWF2by93RGZu?=
 =?utf-8?B?RCt4Yk1kU0tVb01yRTVNU08zaDRSb0JpT0tFUi9mTmhwVDl2UjBXekdDZlFO?=
 =?utf-8?B?Z3lDK05FMTNrOElnT1ZkVHJ2eXk4UVhma3dzTVNOQi9CVDljRVBBNlNkbVpi?=
 =?utf-8?B?RnJIdHpXQ2h2STNBM2NqK2pmaWVuVFRENWlkanM4N2xZRFVJKytGYzRzTWNN?=
 =?utf-8?B?Z1B0NVhLZm1RaC9vZkZFOVFrK2lmdEUwUnFGeG1MemlpRmUvcUM4aFhsSkdO?=
 =?utf-8?B?cklZeTExejNkUmYwOVFLNkFJc2xIT3NrZGJ4V1FNbTNLWkJudkpGaDVJQU9J?=
 =?utf-8?B?S2t6dHI4MStpeEtkU3VsUnNJNGV1RDhZamRrTVV2eVZmemRrZTUwWnFXZG9p?=
 =?utf-8?B?SVFrRFRHL1dIRFVuaXJtS1dlUUFzTWxTV2lVanErZlVVYzdMSEhxZWRkUlpr?=
 =?utf-8?B?MXR1UW5ZVTIvbkNMaXlFdnkrTEswY3BtNTcyM0dmSEprSzgvN2hEYVo3dVZa?=
 =?utf-8?B?SkRNNEZXcVd3RnJDNlM3YjFrVTZIOHNSVnViM3VtSjY4VVJKUkhkdEtscktN?=
 =?utf-8?B?S2U1UXZMWm5oMVM3dUlxcGcvQ0kySVFOTWpxditqZkk0NkVZc1d1QkNiVkt5?=
 =?utf-8?B?RkZpZCtONTM3cWJZVFg5Y0tla21namFyM2FVMDVYb0NTTmM3bnp3Uk5jZjhz?=
 =?utf-8?B?RmVIODRhSUc2czR4d0FMeU9oZkxqNmpjTG5PNGh0Z3pIRFBlUUFvYzhQdUpa?=
 =?utf-8?B?cnpWK001QTJpSEFGVmhQd0Jsa29UWDd1TjR1d0hkZzRvVFkrc0tnWHRBVlUy?=
 =?utf-8?B?T2RSbnVLWnQwNFU4b1RFME1ldER4d2dBVE9XNEFYSEdMd3ljNGFJZ0RuUWY1?=
 =?utf-8?B?MlVkTnVDMjlYRnhkVWdaLzlSRVFjM0FZQm9HeWJnc2p5YXUyYURtcUk4V3ZN?=
 =?utf-8?B?TkxqRy93ZHZYZDRvRjl3UU5MQVNKbnJYcmZ3NnVJQkF4VnZMYndlZmRWSk45?=
 =?utf-8?B?ZnVWMEthc2VwenU0QTZUOCtjMXlTRWFNaWVjdk5hVXFuL0RWSjZNWTlyTzBG?=
 =?utf-8?B?dnNwWmF2bFlIRUNRZkRwTWVwSjJOZ1UxdFdtWG5HOHg4bFZkQ2t0VFNWbHh6?=
 =?utf-8?B?OUs5RXo4Q3FYOW9CTEJqR25zbDBuVmxjR0NrQ1FSU1BGaEdHMU0wb2VMZ0p5?=
 =?utf-8?B?a0ZNNTd5b0h2eU11L0JYMm1FYTJJQ1V6dTZzSmpQZDVuQnlTNERGbGphWndh?=
 =?utf-8?B?UUVZcytCbzJPVDAzeU43QXdCdmExWFpyNzJiQ2gzZURHM1RETG1PSFA4cFlV?=
 =?utf-8?Q?7ptsgQ/iTNE5P0u9YBX6/PwiIWU+M/BKxL5iT+U?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76746dff-b0b9-4597-5abd-08d9843f8f07
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 18:24:36.8539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ePo+WthlEOrj9/R5I2pL2hkHwOZcFBuumeGNj2rcRRu2Ap81BxP7W9MhuUDNXeRJyd515bAUuYhsawjCWCdF98nyT6CGB4uP3ndkSqc6ESY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB2032
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10123 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109300112
X-Proofpoint-GUID: ZWTNv8sA27PR1O4fXmYcdSqQGCbQB2wV
X-Proofpoint-ORIG-GUID: ZWTNv8sA27PR1O4fXmYcdSqQGCbQB2wV
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/28/21 6:54 PM, Don Brace wrote:
> From: Kevin Barnett <kevin.barnett@microchip.com>
> 
> Stop the OS from re-discovering multiple LUNs for
> tape drive and medium changer.
> 
> Duplicate device nodes for Ultrium tape drive and
> medium changer are being created.
> 
> The Ultrium tape drive is a multi-LUN SCSI target.
> It presents a LUN for the tape drive and a 2nd
> LUN for the medium changer.
> Our controller FW lists both LUNs in the RPL
> results.
> 
> As a result, the smartpqi driver exposes both
> devices to the OS. Then the OS does its normal
> device discovery via the SCSI REPORT LUNS command,
> which causes it to re-discover both devices a 2nd time,
> which results in the duplicate device nodes.
> 
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
> Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>

Acked-by: John Donnelly <john.p.donnelly@oracle.com>


> ---
>   drivers/scsi/smartpqi/smartpqi.h      |  1 +
>   drivers/scsi/smartpqi/smartpqi_init.c | 23 +++++++++++++++++++----
>   2 files changed, 20 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi.h b/drivers/scsi/smartpqi/smartpqi.h
> index c439583a4ca5..aac88ac0a0b7 100644
> --- a/drivers/scsi/smartpqi/smartpqi.h
> +++ b/drivers/scsi/smartpqi/smartpqi.h
> @@ -1106,6 +1106,7 @@ struct pqi_scsi_dev {
>   	u8	keep_device : 1;
>   	u8	volume_offline : 1;
>   	u8	rescan : 1;
> +	u8	ignore_device : 1;
>   	bool	aio_enabled;		/* only valid for physical disks */
>   	bool	in_remove;
>   	bool	device_offline;
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index c28eb7ea4a24..8be116992cb0 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -6297,9 +6297,13 @@ static int pqi_slave_alloc(struct scsi_device *sdev)
>   		rphy = target_to_rphy(starget);
>   		device = pqi_find_device_by_sas_rphy(ctrl_info, rphy);
>   		if (device) {
> -			device->target = sdev_id(sdev);
> -			device->lun = sdev->lun;
> -			device->target_lun_valid = true;
> +			if (device->target_lun_valid) {
> +				device->ignore_device = true;
> +			} else {
> +				device->target = sdev_id(sdev);
> +				device->lun = sdev->lun;
> +				device->target_lun_valid = true;
> +			}
>   		}
>   	} else {
>   		device = pqi_find_scsi_dev(ctrl_info, sdev_channel(sdev),
> @@ -6336,14 +6340,25 @@ static int pqi_map_queues(struct Scsi_Host *shost)
>   					ctrl_info->pci_dev, 0);
>   }
>   
> +static inline bool pqi_is_tape_changer_device(struct pqi_scsi_dev *device)
> +{
> +	return device->devtype == TYPE_TAPE || device->devtype == TYPE_MEDIUM_CHANGER;
> +}
> +
>   static int pqi_slave_configure(struct scsi_device *sdev)
>   {
> +	int rc = 0;
>   	struct pqi_scsi_dev *device;
>   
>   	device = sdev->hostdata;
>   	device->devtype = sdev->type;
>   
> -	return 0;
> +	if (pqi_is_tape_changer_device(device) && device->ignore_device) {
> +		rc = -ENXIO;
> +		device->ignore_device = false;
> +	}
> +
> +	return rc;
>   }
>   
>   static int pqi_getpciinfo_ioctl(struct pqi_ctrl_info *ctrl_info, void __user *arg)
>