Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 30 Sep 2021 19:28:18 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Gibson <david@gibson.dropbear.id.au>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "hch@lst.de" <hch@lst.de>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "jean-philippe@linaro.org" <jean-philippe@linaro.org>,
        "parav@mellanox.com" <parav@mellanox.com>,
        "lkml@metux.net" <lkml@metux.net>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "lushenming@huawei.com" <lushenming@huawei.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "yi.l.liu@linux.intel.com" <yi.l.liu@linux.intel.com>,
        "Tian, Jun J" <jun.j.tian@intel.com>, "Wu, Hao" <hao.wu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>
Subject: Re: [RFC 06/20] iommu: Add iommu_device_init[exit]_user_dma
 interfaces
Message-ID: <20210930222818.GI964074@nvidia.com>
References: <20210919063848.1476776-1-yi.l.liu@intel.com>
 <20210919063848.1476776-7-yi.l.liu@intel.com>
 <YVPxzad5TYHAc1H/@yekko>
 <BN9PR11MB5433E1BF538C7D3632F4C6188CA99@BN9PR11MB5433.namprd11.prod.outlook.com>
 <YVQJJ/ZlRoJbAt0+@yekko>
 <20210929125716.GT964074@nvidia.com>
 <YVUqYsJTMkt1nnXL@yekko>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YVUqYsJTMkt1nnXL@yekko>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Tn8raxUckz2dbkx8nuEjoHZ6t7mHCKoyinxsTbJa+r9zcqMTXeur0xTd8Gj9?=
 =?us-ascii?Q?dWhvfND380QXCDP5cWNuoIV4vAkxg5xMKfVL/iHCufk52qJzCGB08+KlVYAv?=
 =?us-ascii?Q?it1ARA6oSnaZ7F+8DmFthkGXcIGnHy8Ks3BgDcll234Xn+dEgHJmhgy37W4g?=
 =?us-ascii?Q?fKc4mE1xsbZPPx/kNvM3ByJnOQW0PtnhpEQwxFkoJtJM8EZLdDwxWvcT/Ql2?=
 =?us-ascii?Q?b2Rx9Yl54NPnAxMd//xnhKfFkRJ+Q/14x6QKk2KUJk3hRLBwzgBjV3r70fYj?=
 =?us-ascii?Q?IPl8CG4vqMS4bl2pnH50c72B6n08lgo45Tnk28keSI7F1V4GCT4SA5GzdfpY?=
 =?us-ascii?Q?5Y6HsOYVTYR1RAKTT8YbAEb2C1hw6wcHmYW5v2kYyPWYptUjadpGbXhP5GSc?=
 =?us-ascii?Q?+7OirYvBBrHNG7IlPqieqG76F4Ezpb0rYKnreb8o0rZlZgSwPmZ4jPPclzDB?=
 =?us-ascii?Q?axdDIG8ERVaq9BgObUQd+v//l5JBef/ZATrRuJU5+2Xq2bbN0o9i9HqVBh+4?=
 =?us-ascii?Q?OdtEVJYf8zvNMkQMOpUnJ2ZLOQ8TMTYBubUgmDJ0+oO0bE6HBj5dOLgrhkoZ?=
 =?us-ascii?Q?Dqd+9JkNsNIQjrzy6aMm97ctdDrGi4vcVzDwrmnPsoS3bX7NgP6r8jXijGQI?=
 =?us-ascii?Q?fN1/vtcVcKle5G5CwrBcdKtzBAfrN2ohnreXS6ar7lbFF5M0NPfk+K0HuPY1?=
 =?us-ascii?Q?lwySW+QF9WIi6d60XfteVkdYYzzMU1j6S4Vq1qngIqIInOT6PsDsCxbThTNt?=
 =?us-ascii?Q?mopq6YXFyZ+1UrvcPj11mAZ+ZHM1i5e9QAYbow4XbqN7Kmhl1RxtHCGmMxmQ?=
 =?us-ascii?Q?at4SHeP0hMd4eGRWDmKp71GKtL7WfePARqWKi4SdA2aQ3bAJNZvksiLGMHyK?=
 =?us-ascii?Q?H7BDGo3wBY2Ru/yaM3o3q1VQ6gRZF06FyBNa4qETp6qalWJcsifTfWerw4Ot?=
 =?us-ascii?Q?xYk7VOuBcLBxAN4OaRvxGn3DL9C+GufjFvB4q6BZhVh3p7q/WLocAEOGkuS3?=
 =?us-ascii?Q?IO0nUWfQ/ZY0on8OcSBuXXbh2ZLK1jp3DJWIgtzeHwkKbcVGDG4QMMpRwm6Q?=
 =?us-ascii?Q?g0DRuWCCqDfzXiVVmAGKChEOv//cY+KSMioLX+ULjSt9SDKA0GpXhcv49cqh?=
 =?us-ascii?Q?ZXM+Q/3eS2tQ7Dxvm6oTADVE2ukR46/+agq+RlahQII1Gp/1WtM1sTbb7TQ6?=
 =?us-ascii?Q?pXQ090XKhYMioWRoLDKcU7RlLo13dX4ZSKSSYdhZrgfG+gWW96B+2OUkv/TH?=
 =?us-ascii?Q?BNVZTDFWXbGfIy0KOWGYrLCTFq8U6xUuJhGiWKB8w0EZc4NNG0vrD9WFqsZc?=
 =?us-ascii?Q?PjjkA4rb1WZaB7MI3JKXG69w41P5Desnncbfo6HMeHEEsQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7450b203-f7d4-4a4a-1e06-08d984619a99
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 22:28:19.2604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nN6hZFGOll0NfB3g7ZE6n9zol6xYK2CEDJMfeWd36go/xQKKv9WiMxDXgpdPvA8q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5364
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 30, 2021 at 01:09:22PM +1000, David Gibson wrote:

> > The *admin* the one responsible to understand the groups, not the
> > applications. The admin has no idea what a group FD is - they should
> > be looking at the sysfs and seeing the iommu_group directories.
> 
> Not just the admin.  If an app is given two devices in the same group
> to use *both* it must understand that and act accordingly.

Yes, but this is true regardless of what the uAPI is, and for common
app cases where we have a single IO Page table for all devices the app
still doesn't need to care about groups since it can just assign all
devices to the same IO page table and everything works out just fine.

For instance qemu without a vIOMMU does not need to care about
groups. It opens a single iommufd, creates a single IO page table that
maps the guest physical space and assigns every device to that IO page
table. No issue.

Only if qemu is creating a vIOMMU does it need to start to look at the
groups and ensure that the group becomes visible to the guest OS. Here
the group fd doesn't really help anything

Jason