Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 11:08:23 +1000 (AEST)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Laurent Vivier <laurent@vivier.eu>
cc:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        linux-rtc@vger.kernel.org, Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH 2/2] m68k: introduce a virtual m68k machine
In-Reply-To: <7748de16-1087-1039-a1cc-5a94dc293dbb@vivier.eu>
Message-ID: <1050733c-5260-3c1e-1ecc-7d3b58683a88@linux-m68k.org>
References: <20210323221430.3735147-1-laurent@vivier.eu> <20210323221430.3735147-3-laurent@vivier.eu> <a9c75ae7-6023-6b6c-260f-a0d6841ea4fa@vivier.eu> <CAMuHMdW49S_81Oip2p+yUO5YUL1-V3_K_C1WEXux7mQWcb-mKA@mail.gmail.com> <c28b0c92-a997-6978-890f-4222f4bb8cc6@vivier.eu>
 <9f7ad0df-b58c-1b24-5c48-5ee6478260dd@physik.fu-berlin.de> <7748de16-1087-1039-a1cc-5a94dc293dbb@vivier.eu>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="-1463811774-367684304-1633050487=:28"
Content-ID: <94a4401a-2129-40e4-8afe-bdc757dcb59d@nippy.intranet>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-367684304-1633050487=:28
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <6fff8fad-f51b-369f-2e92-39ef9fdeac33@nippy.intranet>

On Thu, 30 Sep 2021, Laurent Vivier wrote:

> Le 30/09/2021 =C3=A0 22:56, John Paul Adrian Glaubitz a =C3=A9crit=C2=A0:
> >=20
> > On 4/28/21 14:15, Laurent Vivier wrote:
> >>> I have tested and reviewed your patch, great work!
> >>> I'm confident this can make v5.14, with the small nits fixed.
> >>
> >> Thank you for your review.
> >>
> >> I will answer to some of your comments and update accordingly my patch=
=2E
> >=20
> > It looks like this patch somehow fell off the table, didn't it?
> >=20
> > I was hoping to be able to build a virt kernel for Debian/m68k by defau=
lt
> > in the near future.
>=20
> Yes, I started to update my work according to the comments from Geert but=
 didn't have time to finish.
>=20
> Especially I tried to remove the LEGACY_TIMER_TICK, but it doesn't work,=
=20

There was an RFC patch from Arnd to convert the mac platform from=20
LEGACY_TIMER_TICK to GENERIC_CLOCKEVENTS:
https://lore.kernel.org/linux-m68k/20201008154651.1901126-14-arnd@arndb.de/
Arnd used a periodic clockevent device. I have a developmental branch=20
based on that patch.

Alternatively, I have a branch that implements a oneshot clockevent=20
device. This delivers GENERIC_CLOCKEVENTS and NO_HZ. For this I used VIA 1=
=20
timer 1 in free-running mode for the clocksource and VIA 1 timer 2 in=20
one-shot mode for the clockevent device. (But this does require some QEMU=
=20
improvements because there's no oneshot-mode in mos6522.c in mainline=20
QEMU.)

Anyway, it can be done. If you want to pursue it, perhaps we can=20
collaborate.

> and as it has been tested like this by you and most of the other m68k=20
> targets uses it I think I will let the patch with it.
>=20
> I'm going to update my patch to have a v2, at least to have fresh=20
> reviews.
>=20
> Thanks,
> Laurent
>=20
---1463811774-367684304-1633050487=:28--