Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 10:07:54 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: use wildcards
 on What definitions
Message-ID: <YVaQohW0ykARCJJh@matsya>
References: <cover.1631782432.git.mchehab+huawei@kernel.org>
 <416f4a746c116147abb08fb0155a6a4ed065dfd7.1631782432.git.mchehab+huawei@kernel.org>
 <9a379f0a-e076-844c-fb5d-130359e36754@linux.intel.com>
 <20210916184757.4f0b3cbf@coco.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210916184757.4f0b3cbf@coco.lan>
Precedence: bulk

On 16-09-21, 18:47, Mauro Carvalho Chehab wrote:
> Hi Pierre,
> 
> Em Thu, 16 Sep 2021 11:36:33 -0500
> Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> escreveu:
> 
> > On 9/16/21 3:59 AM, Mauro Carvalho Chehab wrote:
> > > An "N" upper letter is not a wildcard, nor can easily be identified
> > > by script, specially since the USB sysfs define things like.
> > > bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
> > > to convert it into a Regex.
> > > 
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>  
> > 
> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> Thanks!
> 
> > 
> > I also realized that we have a similar with the 'master' case
> > 
> > more sysfs-bus-soundwire-master
> > What:		/sys/bus/soundwire/devices/sdw-master-N/revision
> > 		/sys/bus/soundwire/devices/sdw-master-N/clk_stop_modes
> > 		/sys/bus/soundwire/devices/sdw-master-N/clk_freq
> > 		/sys/bus/soundwire/devices/sdw-master-N/clk_gears
> > 		/sys/bus/soundwire/devices/sdw-master-N/default_col
> > 		/sys/bus/soundwire/devices/sdw-master-N/default_frame_rate
> > 		/sys/bus/soundwire/devices/sdw-master-N/default_row
> > 		/sys/bus/soundwire/devices/sdw-master-N/dynamic_shape
> > 		/sys/bus/soundwire/devices/sdw-master-N/err_threshold
> > 		/sys/bus/soundwire/devices/sdw-master-N/max_clk_freq
> > 
> > If there is an update we should modify this as well for consistency with
> > sdw-master-<N>?
> 
> It is on patch 15/30:
> 
> 	https://lkml.org/lkml/2021/9/16/198
 we should have been cced :(

Thanks to b4, I was able to grab this and apply as well

-- 
~Vinod