Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/1] iio/scmi: Add reading "raw" attribute.
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     jbhayana@google.com, lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vasyl.Vavrychuk@opensynergy.com
References: <20210927132202.17335-1-andriy.tryshnivskyy@opensynergy.com>
 <20210927132202.17335-2-andriy.tryshnivskyy@opensynergy.com>
 <20210930173316.3a111130@jic23-huawei>
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
Message-ID: <efca1c2c-f000-df20-171e-34f7e97877e4@opensynergy.com>
Date:   Fri, 1 Oct 2021 10:12:38 +0300
In-Reply-To: <20210930173316.3a111130@jic23-huawei>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWxRL00xREJwdjllcEJXdThIM2VoUVFDaDVranBhVkRTUk04c3pDK3VVNmFt?=
 =?utf-8?B?UURidGtRRFhBNTVIdm9Eb0ZUZFRQNVFDQzBzeFAyNzVJTHZFQVFjQUNoN2Q3?=
 =?utf-8?B?ZVVmQ1BnNTRqbGxLbGkxMWRlNXN4TGN0akdtMFJzWktlRXJJbE9MN3dQYnU2?=
 =?utf-8?B?MTU3azlpQjdra2pzRzlESk5VNFJXT2NzSHEwU1dUckpJYlQ2N1NaSVN3V2py?=
 =?utf-8?B?ZllyMk9ObVBCSEVxMHRBSXhGVktSYVVYb1RzOEltTHE4SlNOemFtbm5zQlNQ?=
 =?utf-8?B?TS93ZXhPZUppVXgrZ2ExdEtJblFZdUFxaVVCdXFPVVlPY2lBMlhIcDBqd3dp?=
 =?utf-8?B?LzJoRUx0MmxNY1RibFJHaDNHNnpZWGQzM3lCVVQxQ3AzM2UwK01KamNqaFBK?=
 =?utf-8?B?bnFMMjhMR1E4aDZFTm1KazkrcEVZZXRIWG15Y2VBeE9LaUhlNDJWbEUzbS9E?=
 =?utf-8?B?ci9heHFpbnQ4dGxFdXNlUnlBY291WHJpU2x6aDdLb2E4RHR1aVJMc0Jjc2dH?=
 =?utf-8?B?ZmpXWU1BWnhPM2xHd1NTWjVMQkZHaWZFNUxreXFlYWZRWkYrU0U2K3R4TUZD?=
 =?utf-8?B?U2IxZ1Bnem5ZMFNSUW9Ub1Z6NjRhVldUSXpzVXViQXFTdVNkZGU3eEgvVE5T?=
 =?utf-8?B?MlYvWXMvWmdMWThRdTcyUjUvb3NXRzIyUzdVWEk5U05XQ294M0w0NjNHdWlm?=
 =?utf-8?B?YjZqZE8rOG1FT2VRb0w3aHhyNnFORU84R2l2OTNWeWk3dlZDT0hoYnpDWFVk?=
 =?utf-8?B?TkdhRTYvQjdJalIwdVNzVlZsaUQ3cFc3cURyYTJCUFZRclFrTzBJdmEyRjRi?=
 =?utf-8?B?WXhCQ3FOZTBrQnFQb0lIKzkxQWE0NWVDTTMrVGxSVS8rOFFYcFdLcVZ0WW1T?=
 =?utf-8?B?U0VZRjZTMGl1VFkrQ0JPS203ajliT0NOZXVUVW1ZRDE0VEMyOHRrTkdtZysy?=
 =?utf-8?B?R0lYRWJhemtjOWZHMkhWUDVwakw2UDc1QkZUQlhlczl2TkhRc2Nhb3JFSzVU?=
 =?utf-8?B?R211Rk9pV2JSa2hMZkZGQVNRbE5WUUZJTzEySmt5cjV5MnNOelV0WGJ6TWZt?=
 =?utf-8?B?YTJiSS9CQnBKVTdMRHZFQWlCa1djdTVCbitVR1pVajNVbTlYaU1HMmxwNGw1?=
 =?utf-8?B?S1BmM2pLRGVkNGVzK3dpazV0TW1ieVZkcnRod2RobkVkOGUrWjBTUWFGQ0NL?=
 =?utf-8?B?RzkzeThVQTBJL1ZFWkR3TXprdCtaY0xNellDUWUzWXNQTVptSzdZWFN3ZWFT?=
 =?utf-8?B?d0dnYnNmQy81dEtOUDdnV3hCMHRMY2hXYU15Uk1oQnY4cmZxcUhYL1dMcHlM?=
 =?utf-8?B?WG9IOEhQVVNEUzlJVkFvck5DblE0TFdnQXNUcGRiNkFCcDlHZFlaWTdsR0hv?=
 =?utf-8?B?YkJYOGxIa3NoZ1k4L2R1ZEEvbTZJdzJkSVVHMU8yUVZOVjJiNzY3LzJxdDJK?=
 =?utf-8?B?MWJNcHM5d1ZQcks4aUhHOVUyclp2MWtsMHF3R1dsWmpna2hzS01oYVJPbW41?=
 =?utf-8?B?V0hDejBwR2pjOHlVaHpPQkpZWVdRTGVNdVowREorcVB6UmpOSFpkamVQZVV2?=
 =?utf-8?B?QkdHTHNFYVA0dVdhc0NWaWt6cWVvUnBwUWw0K1RnWWlVdUV1MVVzZTFlY1RW?=
 =?utf-8?B?N1pZQzFuRk5QWVE4STAwK2cxUjMycjdjTUQ1Wi94RUZudjJaK053RS9rY0lM?=
 =?utf-8?B?Z25XdlNpM0VlZ3ViRjhtbmcxU0dlTEdEak9hRSs0SjlTSVNhYmMycSszZ08v?=
 =?utf-8?Q?9D97g+FrDLeIZZlBoGEu5Ya90KU6AZ/EKscFTcM?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25ca4106-74b3-433a-66d6-08d984aada8e
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 07:12:39.6707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x2xQMGgJJKktlzAwgOX/oTBpDsxqTiANScWtnWqCgxXbXbbvDYZpPEmTjzbP340YaFGs7i7+F+KezsNLxeVkDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5047
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jonathan,

Thank you for review!

Regards,
Andriy.

On 30.09.21 19:33, Jonathan Cameron wrote:
> CAUTION: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> On Mon, 27 Sep 2021 16:22:02 +0300
> Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com> wrote:
>
>> Add IIO_CHAN_INFO_RAW to the mask and implement corresponding
>> reading "raw" attribute in scmi_iio_read_raw.
>>
>> Signed-off-by: Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
> Hi Andriy,
>
> Looks good to me, but I'll leave it on list to get feedback form the
> driver maintainer for this one.
>
> Feel free to poke if no reply in next 2 weeks.
>
> Thanks,
>
> Jonathan
>
>> ---
>>   drivers/iio/common/scmi_sensors/scmi_iio.c | 45 +++++++++++++++++++++-
>>   1 file changed, 44 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/common/scmi_sensors/scmi_iio.c b/drivers/iio/common/scmi_sensors/scmi_iio.c
>> index 7cf2bf282cef..c6a9dc6ad140 100644
>> --- a/drivers/iio/common/scmi_sensors/scmi_iio.c
>> +++ b/drivers/iio/common/scmi_sensors/scmi_iio.c
>> @@ -286,6 +286,9 @@ static int scmi_iio_read_raw(struct iio_dev *iio_dev,
>>        struct scmi_iio_priv *sensor = iio_priv(iio_dev);
>>        s8 scale;
>>        int ret;
>> +     int err;
>> +     u32 sensor_config;
>> +     struct scmi_sensor_reading readings[SCMI_IIO_NUM_OF_AXIS];
>>
>>        switch (mask) {
>>        case IIO_CHAN_INFO_SCALE:
>> @@ -300,6 +303,45 @@ static int scmi_iio_read_raw(struct iio_dev *iio_dev,
>>        case IIO_CHAN_INFO_SAMP_FREQ:
>>                ret = scmi_iio_get_odr_val(iio_dev, val, val2);
>>                return ret ? ret : IIO_VAL_INT_PLUS_MICRO;
>> +     case IIO_CHAN_INFO_RAW:
>> +             sensor_config = FIELD_PREP(SCMI_SENS_CFG_SENSOR_ENABLED_MASK,
>> +                                        SCMI_SENS_CFG_SENSOR_ENABLE);
>> +             err = sensor->handle->sensor_ops->config_set(
>> +                     sensor->handle, sensor->sensor_info->id, sensor_config);
>> +             if (err) {
>> +                     dev_err(&iio_dev->dev,
>> +                             "Error in enabling sensor %s err %d",
>> +                             sensor->sensor_info->name, err);
>> +                     return err;
>> +             }
>> +
>> +             err = sensor->handle->sensor_ops->reading_get_timestamped(
>> +                     sensor->handle, sensor->sensor_info->id,
>> +                     sensor->sensor_info->num_axis, readings);
>> +             if (err) {
>> +                     dev_err(&iio_dev->dev,
>> +                             "Error in reading raw attribute for sensor %s err %d",
>> +                             sensor->sensor_info->name, err);
>> +                     return err;
>> +             }
>> +
>> +             sensor_config = FIELD_PREP(SCMI_SENS_CFG_SENSOR_ENABLED_MASK,
>> +                                        SCMI_SENS_CFG_SENSOR_DISABLE);
>> +             err = sensor->handle->sensor_ops->config_set(
>> +                     sensor->handle, sensor->sensor_info->id, sensor_config);
>> +             if (err) {
>> +                     dev_err(&iio_dev->dev,
>> +                             "Error in enabling sensor %s err %d",
>> +                             sensor->sensor_info->name, err);
>> +                     return err;
>> +             }
>> +             /* Check if raw value fits 32 bits */
>> +             if (readings[ch->scan_index].value < INT_MIN ||
>> +                 readings[ch->scan_index].value > INT_MAX)
>> +                     return -ERANGE;
>> +             /* Use 32-bit value, since practically there is no need in 64 bits */
>> +             *val = (int)readings[ch->scan_index].value;
>> +             return IIO_VAL_INT;
>>        default:
>>                return -EINVAL;
>>        }
>> @@ -381,7 +423,8 @@ static void scmi_iio_set_data_channel(struct iio_chan_spec *iio_chan,
>>        iio_chan->type = type;
>>        iio_chan->modified = 1;
>>        iio_chan->channel2 = mod;
>> -     iio_chan->info_mask_separate = BIT(IIO_CHAN_INFO_SCALE);
>> +     iio_chan->info_mask_separate =
>> +             BIT(IIO_CHAN_INFO_SCALE) | BIT(IIO_CHAN_INFO_RAW);
>>        iio_chan->info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SAMP_FREQ);
>>        iio_chan->info_mask_shared_by_type_available =
>>                BIT(IIO_CHAN_INFO_SAMP_FREQ);
>