Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 09:54:04 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Adam Ford <aford173@gmail.com>
Cc:     linux-omap@vger.kernel.org, hns@goldelico.com,
        aford@beaconembedded.com,
        =?UTF-8?B?QmVub8OudA==?= Cousson <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz
 variants
Message-ID: <20211001095404.41f73d88@aktux>
In-Reply-To: <20210109170103.1249838-1-aford173@gmail.com>
References: <20210109170103.1249838-1-aford173@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat,  9 Jan 2021 11:01:03 -0600
Adam Ford <aford173@gmail.com> wrote:

> Previously, the 1GHz variants were marked as a turbo,
> because that variant has reduced thermal operating range.
> 
> Now that the thermal throttling is in place, it should be
> safe to remove the turbo-mode from the 1GHz variants, because
> the CPU will automatically slow if the thermal limit is reached.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2:  The orignal patch had the wrong file added. Add the omap36xx.dtsi
> 
hmm, I somehow expected that there is a revert of this thing going
through. But now, the turbo-mode is still missing and I understood the
revert is only in Nikolaus' trees. The 1Ghz mode was working for some
time but does not anymore. Is it just me or do others also have the
same problems?

Regards,
Andreas

> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> index 05fe5ed127b0..20844dbc002e 100644
> --- a/arch/arm/boot/dts/omap36xx.dtsi
> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> @@ -72,7 +72,6 @@ opp1g-1000000000 {
>  					 <1375000 1375000 1375000>;
>  			/* only on am/dm37x with speed-binned bit set */
>  			opp-supported-hw = <0xffffffff 2>;
> -			turbo-mode;
>  		};
>  	};
>