Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 01 Oct 2021 09:00:48 +0200
Message-ID: <s5h8rzdjkkf.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Chris Chiu <chris.chiu@canonical.com>
Cc:     tiwai@suse.com, kailang@realtek.com, hui.wang@canonical.com,
        jhp@endlessos.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - Enable headphone mic on Dell Latitude laptops with ALC3254
In-Reply-To: <20211001062856.1037901-1-chris.chiu@canonical.com>
References: <20211001062856.1037901-1-chris.chiu@canonical.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 01 Oct 2021 08:28:56 +0200,
Chris Chiu wrote:
> 
> The headphone mic is not working on Dell Latitude laptops with ALC3254.
> The codec vendor id is 0x10ec0295 and share the same pincfg as defined
> in ALC295_STANDARD_PINS. So the ALC269_FIXUP_DELL1_MIC_NO_PRESENCE will
> be applied per alc269_pin_fixup_tbl[] but actually the headphone mic is
> using NID 0x1b instead of 0x1a. The ALC269_FIXUP_DELL4_MIC_NO_PRESENCE
> need to be applied instead.
> 
> Use ALC269_FIXUP_DELL4_MIC_NO_PRESENCE for particular models before
> a generic fixup comes out.
> 
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>

Thanks, applied.


Takashi