Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] iio/scmi: Add reading "raw" attribute.
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     jbhayana@google.com, lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vasyl.Vavrychuk@opensynergy.com
References: <20210922065235.12891-1-andriy.tryshnivskyy@opensynergy.com>
 <20210922065235.12891-2-andriy.tryshnivskyy@opensynergy.com>
 <20210925154310.2f31c032@jic23-huawei>
 <18401c96-a88e-c7fa-8f20-56605945891d@opensynergy.com>
 <20210930162618.0c53ec33@jic23-huawei>
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
Message-ID: <94494815-8835-1faa-441a-ed89358f8048@opensynergy.com>
Date:   Fri, 1 Oct 2021 09:59:54 +0300
In-Reply-To: <20210930162618.0c53ec33@jic23-huawei>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjNHVFNvcm5JVGpIUDk4c1N0NElLR3d0Uitrd2E5SE95eWdZblVhTXM3OHQ0?=
 =?utf-8?B?cGZScVZOMktJVDNGUzhVSjUwd1ZKbTluallNSzU3V1NBMjVqYzRFNjVMSmpk?=
 =?utf-8?B?ZGNZWjd4aWdJQ3FIY2JGS1pwSlZHT2RsNTV3bHN6ZGMxeEFzRFEwRHpkOEIz?=
 =?utf-8?B?TU01R3dVbVZKRis4K010WDZMR2I0eWJVSEduWit4Wk1OU082ejhuYmZxWUl0?=
 =?utf-8?B?OWpudnpubUNuMkR2S3NVLzdkcG92SC9taFVzdEZkZURqVnNhbnQwSVdDZmMy?=
 =?utf-8?B?ajV5QnUwellWTW5PL2tZT1lZVHFNOXJzdG9sY214Q3dVWUw4VFNkV1l1Ynpt?=
 =?utf-8?B?ZGdRZ25pL2RaNWlOemJrL05CV3pBNmF2MFVYaHcyMm5oN3BqeUFOeTNWcUlE?=
 =?utf-8?B?ODUzdGRBU1BIOS9pb1pRVWJZSWR3aENRY3FDMEtUMHlsMFR0aDN6Q0w5V0J4?=
 =?utf-8?B?bXNXWGU5VHJzTjRyc2lWTmkrbTFvQ3RESFFWRDBkZmlpbHAvNjBoejQveE9y?=
 =?utf-8?B?STVBS3hCQ3RWWk00NE5HeUNsUndXNmlMRk0yekJsY2FXWmdJSkY1ZkMxY2JT?=
 =?utf-8?B?WW1DLzJrNFhTNWVreVNXaHlqQVJnYUUwTnVONUkyeUs5QTBSYmRxMXBMcnBJ?=
 =?utf-8?B?d0dZbXg0MjlzWWJkKzlLYTlQNTA1Y1VXUWRMNXJ0b3FQZzhwZkdXZEFlQVM0?=
 =?utf-8?B?VHdSREt4UEMvelJaZ0UzUUUxWllvZ1pWNFJqQ1djZTlieW1RbHlucWVubk1H?=
 =?utf-8?B?d2RkS00zMzlwQ2VQTUNMaFFqbVBFTzY2cnFQU09ienRYN2RKdldIdEE1UjM2?=
 =?utf-8?B?T1Axci9pZlZIN2l0SlRjZGhXWUYxdU10Uys0Szgyend6elBUc0VYYkhLbTg1?=
 =?utf-8?B?dHdsYXhuVm5CR01uM2kzU3lvM1UzVkxRb2pnLzJRWE8vYlhhZHl5eFNyZDBJ?=
 =?utf-8?B?R3NOUkhKeTZDZDl4NVNHdDdtaFlqTmpqVnVSNFFzcEtLYkwvZnRrcmwwVDBl?=
 =?utf-8?B?Q2cwTW9xR1ZRb01BcUVYU3JHbVdNS3B6MEZVV2lZZHJmWW1YRW51OHQ4R3dJ?=
 =?utf-8?B?UDErQWR1RDM5YlV6S0ZlMnZDSXNsM2NCMHlXQ3QzaGRPU1FvSTMxamk3alY3?=
 =?utf-8?B?YVV4aGRtR2RWeGQ0bTg1a3pmU0FHQktmaHFFbUE5N3kxYlQwWVFNVURyWEVn?=
 =?utf-8?B?V1F4VnFLeUhGM3dRaVRXL0t5THJDa1J6YTZ1YnJqeUhyV0MraDFEUXpkRWEr?=
 =?utf-8?B?b3kzOEw2RGdadTB1VGF4TUlsWHF5S3Z6Z1FteHJyZUFZblFwb1c1bnFvWnYv?=
 =?utf-8?B?ZURhVVFtK2xsK0lLeWZaZ010V25JRkFFdk1LQzhrSGk1NEtlN3kzTGNRZjhm?=
 =?utf-8?B?K1lzdUZ4clVpRHBZNTVrTEVNNzFYRThDcTIvS2NKdjJMKzNraFY2d09aUVdz?=
 =?utf-8?B?UkJYbWxnRTV4VHBjWm9Wam9SSXJKQzVFZ2hXZVhObVBBend4NVAyRjZwd05F?=
 =?utf-8?B?aVk4aHJjWngycXB0aVVJMUxKQ3RMdktpTE5zalZST1N1Uk9mdFFuMnB1dkw5?=
 =?utf-8?B?NTFDSDlHdU1wc01NUWJZOXBCenNkc25NT0JGOHpKeEpkbUpyTHRtVUo3ZG1i?=
 =?utf-8?B?ank4c25jT0I4U1FLVFBDRmdEQ0FVOFlRT0dQbkhrVjMyc1J1QjVhVktpamtD?=
 =?utf-8?B?Z2ZWNFkzODMwRk5NZVN6Sk1rY2E5OWJqMEo1VDJqVDRWNDhySU5yd0RnTEQ4?=
 =?utf-8?Q?GqFsnYtt29ziWgGsKzXppsilCxPQou5FQ1aIzpw?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9353fe1f-4b7f-4c65-c849-08d984a913a8
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 06:59:56.5422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rimQTRaLfH/BnLValqWY0regH5DCNpMYP7o++lz51U9vOqMQmFlDkAbOqMskYuYPfjtE47XxNgxd1ZH3fUs/CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4934
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>>>> +             /* Use 32-bit value, since practically there is no need in 64 bits */
>>>> +             *val = (u32)readings[ch->scan_index].value;
>>> We should check it fits and if doesn't return an error rather than pretending all was fine.
>>>
>> What kind of error to return in the case it does not fit - ENOEXEC (Exec format error) ?
> That one is a bit obscure.
>
> I'd go with either -ERANGE I think as we are reflecting that the clamp to 32 bit
> is not representable.

Thanks for hint. Later I've found -ERANGE also and used it in my next patch versions.