Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     Jeremy Linton <jeremy.linton@arm.com>,
        Hamza Mahfooz <someguy@effective-light.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Robin Murphy <robin.murphy@arm.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in
 add_dma_entry
Thread-Topic: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in
 add_dma_entry
Thread-Index: AQHXpSuO4AOhY9kToEi8I4sPqFaslaujtKEAgBn4OYCAAFQpAA==
Date:   Fri, 1 Oct 2021 09:21:13 +0000
Message-ID: <20211001092112.ndi43juysd2vg6zm@skbuf>
References: <20210518125443.34148-1-someguy@effective-light.com>
 <fd67fbac-64bf-f0ea-01e1-5938ccfab9d0@arm.com>
 <20210914154504.z6vqxuh3byqwgfzx@skbuf> <20211001041959.GA17448@lst.de>
In-Reply-To: <20211001041959.GA17448@lst.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ajtcWiutTWak/KUAXK0/MlwtRKJdRumfocK869j2wEJFYcMneFt1iRC+v0?=
 =?iso-8859-1?Q?9n1LMny7Nqi8QwGWb7B2o8zbhR+m2FYs14kmeoeMmDVMNA+aXRV/Ov4/k6?=
 =?iso-8859-1?Q?9R8UAI6e/0Q/hUzN6ap11HraX/xK3CmBv/1WwaOU0fnJEQf+G+kp/pTqpS?=
 =?iso-8859-1?Q?WmsFyu1wdv3LdIeLG1JefmlyPynjYO6NYpygsAnmbYsMmhgB/w+4Djm2ZW?=
 =?iso-8859-1?Q?R6YpxJZgn7E68n5ijQflhZCAIVLVoGTWX/8NjomJapKTIPVC/3DCr9DmgH?=
 =?iso-8859-1?Q?ilG5R3XatiKF/k61ix+YuJWlQKwEmSSliKLd/GVOR+h3AbIJMkbsWs403I?=
 =?iso-8859-1?Q?31XqXVRP/TWl0s8lZX8w1f1qM2eC6znBckUuu41KDm7HqczBO24EZvWrzp?=
 =?iso-8859-1?Q?N0OZzOuuZvqHiO47/X+bj9HRtTSLETw0/UpiqDNW0L4egbn6x48/kioNjx?=
 =?iso-8859-1?Q?+eWDHx+XREF/gdgZULWekC5ULbz73D30GkEYVTlvViJ3S3cuAPr45JaBoW?=
 =?iso-8859-1?Q?eLaRnBj6k353mSPYnkqd+yNIEGUk93d6r7oPSXROr6qOsvdS/qFZXWuJo3?=
 =?iso-8859-1?Q?TpkVTTVQs4uGlwxDQIDOzpCJl6vi7NoNXdnCvjXG8QltddAFACaU/IZ0eE?=
 =?iso-8859-1?Q?mEg5QXbLUn/s7pGxLDNaGmr80QPRqyE8jhcQORbXopw3pOyIqGGbrOVyOT?=
 =?iso-8859-1?Q?F2rmZpuoxGgbAw/RpRFI+uOhxCHULqq8reLa7mZnInltFO39+UR2EsJ7so?=
 =?iso-8859-1?Q?7lqmm7TUvxZUqwsB03VO0ETI6QSTyMg35cfV5ITAon3Vr+CWwfSR8KLz2X?=
 =?iso-8859-1?Q?AA9KcTSZimyctVcv8SCEwhSdyys1Lb1qEC5hVZrEU6iMj12MIXC5KchMM6?=
 =?iso-8859-1?Q?25JtXgISV63K8GxHSz3f5lzDrsOkuW8Z6NLbV01TynktvgslgPzHFBfUpe?=
 =?iso-8859-1?Q?ZelAFAvTDXKJCzQeqxjxmVmBz6lR+ne9DDF6klL/oj5GSsIAoj1ajhgyxS?=
 =?iso-8859-1?Q?i6AtkuZjLuxsRl0teZYslPQ5ZEyt3qZGh2BVhheEM1Q64y5FodtyHLTi7G?=
 =?iso-8859-1?Q?R3JOQ49sjryt9axhZQ4tLXSxhcyN6xs8bT58YW1gYvGm+xPxylyQ2ldNJ0?=
 =?iso-8859-1?Q?mcqC7nPM3ILRRXBvL89BGp6Gib6zFsTthMmpzZdUwdXaFBe2ZBy4n7YCG+?=
 =?iso-8859-1?Q?wdWHZvGEwQ0qnxvIBd5oH0/zasoq1BGNrgciYq6qXTGlGd2NLngfUY24Pj?=
 =?iso-8859-1?Q?10W4c3ccXHrvibYHNko9gN5N1PzOmaedzayqNjf3IGHBVDDvnHUo1tbrNL?=
 =?iso-8859-1?Q?/cDpC1HDu/j3TqWsC74GNYjNvW25NRadys3hFKSvIMixw9g2IaZUNIRsCb?=
 =?iso-8859-1?Q?Tdb4c+s3AN?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <8EB46456DFEC83449F1712382451EE3F@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM4PR0401MB2308.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bae6da4f-4a09-4a37-a92a-08d984bcd076
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2021 09:21:13.5201
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +aqPwjlCDwV/Z3vipSFBf2SImQtf9u+e9EN5T17xteEaNooZTCGlvXJa/tQjnbguO5G/Y0ANXr9ETbNjQRhklQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7956
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 01, 2021 at 06:19:59AM +0200, Christoph Hellwig wrote:
> On Tue, Sep 14, 2021 at 03:45:06PM +0000, Ioana Ciornei wrote:
> > [  245.927020] fsl_dpaa2_eth dpni.3: scather-gather idx 0 P=3D20a732000=
0 N=3D20a7320 D=3D20a7320000 L=3D30 DMA_BIDIRECTIONAL dma map error check n=
ot applicable=B7
> > [  245.927048] fsl_dpaa2_eth dpni.3: scather-gather idx 1 P=3D20a732003=
0 N=3D20a7320 D=3D20a7320030 L=3D5a8 DMA_BIDIRECTIONAL dma map error check =
not applicable
> > [  245.927062] DMA-API: cacheline tracking EEXIST, overlapping mappings=
 aren't supported
> >=20
> > The first line is the dump of the dma_debug_entry which is already pres=
ent
> > in the radix tree and the second one is the entry which just triggered
> > the EEXIST.
> >=20
> > As we can see, they are not actually overlapping, at least from my
> > understanding. The first one starts at 0x20a7320000 with a size 0x30
> > and the second one at 0x20a7320030.
>=20
> They overlap the cache lines.  Which means if you use this driver
> on a system that is not dma coherent you will corrupt data.

This is a driver of an integrated ethernet controller which is DMA
coherent.

I added a print just to make sure of this:

--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -567,6 +567,7 @@ static void add_dma_entry(struct dma_debug_entry *entry=
)
                pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
                global_disable =3D true;
        } else if (rc =3D=3D -EEXIST) {
+               pr_err("dev_is_dma_coherent(%s) =3D %d\n", dev_name(entry->=
dev), dev_is_dma_coherent(entry->dev));
                err_printk(entry->dev, entry,
                        "cacheline tracking EEXIST, overlapping mappings ar=
en't supported\n");
        }


[   85.852218] DMA-API: dev_is_dma_coherent(dpni.3) =3D 1
[   85.858891] ------------[ cut here ]------------
[   85.858893] DMA-API: fsl_dpaa2_eth dpni.3: cacheline tracking EEXIST, ov=
erlapping mappings aren't supported
[   85.858901] WARNING: CPU: 13 PID: 1046 at kernel/dma/debug.c:571 add_dma=
_entry+0x330/0x390
[   85.858911] Modules linked in:
[   85.858915] CPU: 13 PID: 1046 Comm: iperf3 Not tainted 5.15.0-rc2-00478-=
g34286ba6a164-dirty #1275
[   85.858919] Hardware name: NXP Layerscape LX2160ARDB (DT)


Shouldn't this case not generate this kind of warning?

Ioana=