Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <18de5e10-f41f-0790-89c8-3a70d48539be@kontron.de>
Date:   Fri, 1 Oct 2021 11:20:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH 1/3] net: phy: mscc: Add possibilty to disable combined
 LED mode
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>, Frieder Schrempf <frieder@fris.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org,
        Bjarni Jonasson <bjarni.jonasson@microchip.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Russell King <linux@armlinux.org.uk>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        =?UTF-8?Q?Marek_Beh=c3=ban?= <marek.behun@nic.cz>
References: <20210930125747.2511954-1-frieder@fris.de>
 <YVZQuIr2poOfWvcO@lunn.ch>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <YVZQuIr2poOfWvcO@lunn.ch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NldnWnJCcmFCSW8yWHBPalQwWUFoblZlMFBKM29vR0w1VVMweStNTlFWYVpM?=
 =?utf-8?B?Z05YYUVpYUlLdFlYZ1lzY2dMcW40UlM4ZUQ2SEFtcXR6WFFpay93NXd4MG5Q?=
 =?utf-8?B?b2pPWWVuQXBET0lvSitTYTNMK3pIck5SM3BuU3kvV0tTL2oyRFVrT3gvWGVJ?=
 =?utf-8?B?OWxPNjhDeERyV0wrcmRtZUM5UkFUVDgxdXFzU3Jwa0NjV3ZkdWUyWjZNWVNP?=
 =?utf-8?B?akRCTkg2bTRPV2FRUVp1NUlGRXpwbCtMcWtaT3BSOFdWOVgvNXhvMDFKelFs?=
 =?utf-8?B?MldCWnAxYlVSMlV3RnVlNEF2LzBRbmVWdVpTU09sMGxiQVpRVjlFSkx1VnYz?=
 =?utf-8?B?RnRtWWJjdjlQNG9VeUFHNHNUZWRYenZ4ZXZ5MmMvZEh5cjU5dEZ2ZUVUVDZt?=
 =?utf-8?B?ZzhKN0tlb2lTdmdHNEpDUVQ3cHF2VmhLcU0vbzBDTGVlYTlSOXJVdm5FWHA3?=
 =?utf-8?B?SlREQm1JVExvRjFGWW5vTzJvb1lVQ2FlNmJIdUk0T2tiSURIRFptRDlwQlRE?=
 =?utf-8?B?anJ1TzFmMWxZZDZwcDl4cjlEdXFZb0dGdDV6T1JJdXVqY0djU1AraWtEamJq?=
 =?utf-8?B?WWZEN2V2ZEUzQXBHeFI1cWM2L1hBUlFPK3pnY3hjUWVvOEp2KzZ4SmpZWWE1?=
 =?utf-8?B?R2VkZFBTbHpDTEZCSWNtUlFmZXRmK2VaODBwKzdMWW1GTm9nV1VVeWdMUXU5?=
 =?utf-8?B?SUJ5OVpuZmIrVW1YR3drQmgvMGIvUitIdXd5aWM4T1M4WjRvR1g1bjhhbXN6?=
 =?utf-8?B?U0hZYzd6d0hiN3RzK3hvZVFWMlllemtiS1k3Q3RDbHpOZC9WUEhPQ2JwKzZN?=
 =?utf-8?B?cjdaVFRtcVJTcVpBSjRJWmJPYW4vNTdFMFRBNVczb1hqSmJMUDRnajhRRU5h?=
 =?utf-8?B?UnFIdU9HYjYrcmJzNjcrckdUWFZKY2x4VW1oQVo2RWptMm5sYThqVGlpSmdK?=
 =?utf-8?B?ZzBxakdqYzNNQ2xZNnV1ZXFOeElFeUJhVHkwbzQ0VFVka2NyZ2ZGM1V0MEkv?=
 =?utf-8?B?bHNlTm5GSnF5eWlhS3krTVR0bEZwVmhFeXh2RXRBa1J4SFM5VkFiMGR1OXZR?=
 =?utf-8?B?Q21lUTZZVGJkRi8zU1U1R3hiM29vekxVaHQ3RTFNbm5qS2dmUjNkYnNQYkJB?=
 =?utf-8?B?SHFDVk5mcWdJV0dDUTUxUkxnWjdBUVR6WlhHRSs3VW42M29OUkZNWGlnWmVy?=
 =?utf-8?B?bXkvRmdjZnZMUG9JL1RRVHNGWFBwb2I4U2lJa1lHemdYcG9ua0FZK2pHV2ZJ?=
 =?utf-8?B?UUNjSlhCWGYrb3ZZbmZFSCs4QTUwc2tkdnAxdFR3clA4M1d5bjZud2REVU9P?=
 =?utf-8?B?K1E4eWRLcUJTQlF6ZVJXdFBrSURVQ21wTVJKeUxpNkFyaGtReC9SRmFxNjBq?=
 =?utf-8?B?SXJlUHR1TVJFdmJQODRVUzhsRDlhcmVDVXhNTUdsZ3VhU1FncHpPV2JhTEo0?=
 =?utf-8?B?TVNwNzg1QjlZanJ1Ung3ZEhWblZ1MTNnTXVvNmtLc2txaktCY2JtRFJWZGJi?=
 =?utf-8?B?aHFaWjIyVjBHRituVitTdDM2d3BxVS9CUG9YQ2M3TC8vOTMzeGk4ZDVhYzJH?=
 =?utf-8?B?YUx1aGlBWVMvaCtxUk5TOEU4S0RwbjYyN1pJdFgwbllEVDA4MHp1RnEzNFpT?=
 =?utf-8?B?eEV5RS8xc05pWUNSNCt0NG05UlUwYitxcGZvaXJuNmFweUZDazI4ajBxVXpX?=
 =?utf-8?B?aDdPKzQvZXoyNDRCNlFZSWhnY2tFalkrNjRwUk1LRTlibFcyVkdNRDc5VEtX?=
 =?utf-8?Q?kMT0ZT9zPva5F6yMTSA/5iWJCZhvVkVU14wZoT3?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 96aa0ff7-b5cd-4fb1-bdb5-08d984bcbe66
X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 09:20:43.4097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q2YTdeuE2Pa4Mm6L1ONeWBXNjRKuLB/iG8rwyY8dQfn/TWmptMIB+NuCWr6u4r0QOt/Zq088YLoRUkt2ZDZe8XXQkiZVOmoZ2ChTywjkV6Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2865
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01.10.21 02:05, Andrew Lunn wrote:
> On Thu, Sep 30, 2021 at 02:57:43PM +0200, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> By default the LED modes offer to combine two indicators like speed/link
>> and activity in one LED. In order to use a LED only for the first of the
>> two modes, the combined feature needs to be disabled.
>>
>> In order to do this we introduce a boolean devicetree property
>> 'vsc8531,led-[N]-combine-disable' and wire it up to the matching
>> bits in the LED behavior register.
> 
> Sorry, but no DT property. Each PHY has its own magic combination of
> DT properties, nothing shared, nothing common. This does not scale.
> 
> Please look at the work being done to control PHY LEDs using the Linux
> LED infrastructure. That should give us one uniform interface for all
> PHY LEDs.

+Cc: Marek

I guess you are referring to this: [1]?

If so, the last version I could find is a year old now. Is anyone still
working on this?

I understand, that the generic approach is the one we want to have, but
does this really mean adding PHY led configuration via DT to existing
drivers (that already use DT properties for LED modes) is not accepted
anymore, even if the new API is not yet in place?

If anyone (Marek?) would be willing to revive this series, I could maybe
try to find some spare time to rework the mscc PHY LED configuration on
top of this and do some tests.

[1] https://patches.linaro.org/patch/255422/