Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz
 variants
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20211001095404.41f73d88@aktux>
Date:   Fri, 1 Oct 2021 11:59:14 +0200
Cc:     Adam Ford <aford173@gmail.com>, linux-omap@vger.kernel.org,
        aford@beaconembedded.com,
        =?utf-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C0A84970-0AAC-42E7-8E0F-4D165F0C9551@goldelico.com>
References: <20210109170103.1249838-1-aford173@gmail.com>
 <20211001095404.41f73d88@aktux>
To:     Andreas Kemnade <andreas@kemnade.info>
Precedence: bulk


> Am 01.10.2021 um 09:54 schrieb Andreas Kemnade <andreas@kemnade.info>:
>=20
> On Sat,  9 Jan 2021 11:01:03 -0600
> Adam Ford <aford173@gmail.com> wrote:
>=20
>> Previously, the 1GHz variants were marked as a turbo,
>> because that variant has reduced thermal operating range.
>>=20
>> Now that the thermal throttling is in place, it should be
>> safe to remove the turbo-mode from the 1GHz variants, because
>> the CPU will automatically slow if the thermal limit is reached.
>>=20
>> Signed-off-by: Adam Ford <aford173@gmail.com>
>> ---
>> V2:  The orignal patch had the wrong file added. Add the =
omap36xx.dtsi
>>=20
> hmm, I somehow expected that there is a revert of this thing going
> through. But now, the turbo-mode is still missing

tagging by turbo-mode means the OPP is *disabled* by default and
needs to be enabled actively.

> and I understood the
> revert is only in Nikolaus' trees.

It is just a revert for the gta04a5 because I think it is the only board
which is affected (maybe it would need SmartReflex in operation to
fine tune the OPPs compared to the generic table). Therefore I have
a patch which adds turbo-mode to the gta04a5.dts

> The 1Ghz mode was working for some
> time but does not anymore. Is it just me or do others also have the
> same problems?

That would be interesting to know.

BR,
NIkolaus

>=20
>=20
>> diff --git a/arch/arm/boot/dts/omap36xx.dtsi =
b/arch/arm/boot/dts/omap36xx.dtsi
>> index 05fe5ed127b0..20844dbc002e 100644
>> --- a/arch/arm/boot/dts/omap36xx.dtsi
>> +++ b/arch/arm/boot/dts/omap36xx.dtsi
>> @@ -72,7 +72,6 @@ opp1g-1000000000 {
>> 					 <1375000 1375000 1375000>;
>> 			/* only on am/dm37x with speed-binned bit set */
>> 			opp-supported-hw =3D <0xffffffff 2>;
>> -			turbo-mode;
>> 		};
>> 	};
>>=20
>=20