Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 13:16:20 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Orlando Chamberlain <redecorating@protonmail.com>
Cc:     lee.jones@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART
Message-ID: <YVbf9J3jgAmBY+ch@smile.fi.intel.com>
References: <20211001084905.4133-1-redecorating@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211001084905.4133-1-redecorating@protonmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Oct 01, 2021 at 08:51:46AM +0000, Orlando Chamberlain wrote:

Thanks for your contribution! My comments below.

> The MacBookPro16,2 has a UART controller with pci id 8086:38a8. Added

PCI ID

> this device to the intel_lpss_pci driver. This allows access to its
> Bluetooth controller.

> The name of this device is not known, however as it appears to only be
> found on the one model (MacBookPro16,2), labelling it with that
> model's name should be sufficient to identify it. (Unless some folks
> from Intel know what to call it and what its section should be called.)

No need to put this paragraph into commit message (see below).

> Records here indicate that this device is only present on the one model:
> https://linux-hardware.org/?id=pci:8086-38a8-8086-7270
> 
> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
> ---
>  drivers/mfd/intel-lpss-pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index c54d19fb184c..e02bb7026520 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -253,6 +253,8 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
>  	{ PCI_VDEVICE(INTEL, 0x34ea), (kernel_ulong_t)&bxt_i2c_info },
>  	{ PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
>  	{ PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },

> +	/* MacBookPro16,2 */

Use

	/* ICL-N */

here.

> +	{ PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
>  	/* TGL-H */
>  	{ PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
>  	{ PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },

-- 
With Best Regards,
Andy Shevchenko