Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1181083pxb; Fri, 1 Oct 2021 05:25:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBAQ6lShiJcHF9iJ0p4rKPeqHNJQnqdw8eksdx+oAuXt6lqu1BY5akxxh1REZ33L7ekUkT X-Received: by 2002:a17:903:248f:b029:128:d5ea:18a7 with SMTP id p15-20020a170903248fb0290128d5ea18a7mr9508189plw.83.1633091157047; Fri, 01 Oct 2021 05:25:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633091157; cv=none; d=google.com; s=arc-20160816; b=WYbq9MG0lR7RK4y0rJcRvX5oA5mEu5wB3UBccew7Cp/hALm83VHTs//dAgLl9M+J4O Sf03nMT42PBh/1kCZSQzFRSkwn/fWpXMIa51btvoxYeMdykaNuAQrr63z6PEBBj4O6Y9 0o+/bENsBCDvqjLGO7LVjoDHzBBBmhwzN7CebDok++NN5LEA3+4LHAz/ajr0d1E62cCW Xqe6LCxBeplgejnajehPEGZx12BjVpzmpdkvSvBlBmEyhiO07UacwoZkeY5cOIPHU3ni NEBceOnA7OYurpPgAd8VJtx6OJ+nGZEuTpkgyj2hNNfehrkiwRPzuoCIMExzR3ufp2V4 CMPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v8cWsPtrzvY71v6Zmd9DiVej33b6z0WO4FPNeqblz/k=; b=FcKOTfOXgucv5fmpKsuEm6dJrjFUSSQoGrfZpBIwMZhyi8yqDO5Jzq2P21tGi0lTF8 Gk0cfwJ6xBh8LOB1HPJfv8LseAGA8tJ3RhhmR/um/v9AZAJQAwsuVjwjWrk3CXRAXud3 5qpiCdHEBNgaPgp6i+j7frNy/gqJV88f/0+a7KVqtqmLSZZuQ+taf0a8WyUFGd3ZCshI Yfxr4zPA1vBGJ+JIiYeHHxwB9g6jtYMpRGCL1o1ofqjiWW1zYNOkcDgkRq3VtO9I6ixO L1Aa1G6BZ50rEIPRglomIoi/ixJMHMffg7OFO7WcM1oOjSdfWqKrSdycdaZyhph4hEgK amSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oq0EJTGm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i186si7348472pfg.200.2021.10.01.05.25.38; Fri, 01 Oct 2021 05:25:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oq0EJTGm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353453AbhJAK0S (ORCPT + 99 others); Fri, 1 Oct 2021 06:26:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:60498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbhJAK0S (ORCPT ); Fri, 1 Oct 2021 06:26:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 61D5A6103D; Fri, 1 Oct 2021 10:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633083874; bh=d2B3aqMqCeg19jkk4r/VHqci8GXUvcnxdV2Hf+/w4Og=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oq0EJTGmH24SIL3sllAtZp7cphGmYZyf40/foG2HbPnUXk/plxpKAGr/YaiCcfOiF TRKJWDcOtQ+ziqW6RhhLTD2V6yqe/oLEsZqYjSfDHJyvEE7rXKEB0esqK8Hvv7mMeI TGd3F6hTPp/8DhoUDoi9veNWHyHBLijbkcDRtvdjM9ZD4j61+qUAtTNYKjHnN8LHnu +yVsdC2VnAVRHRqS88R27Xwrrv2hPFhxWLyBqSixR3m4ry3zerYCgb/CD6MsN/It4N o7J2ROHkwGASNURqiuqiWUPNMD1uodpKhwOhuKbqheyfTdpSR7zKUqbQSEoPkTJdzH jjBjbRs3GUsrQ== Date: Fri, 1 Oct 2021 15:54:30 +0530 From: Vinod Koul To: Cai Huoqing Cc: Kishon Vijay Abraham I , Heiko Stuebner , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip-inno-usb2: Make use of the helper function devm_add_action_or_reset() Message-ID: References: <20210922130024.745-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210922130024.745-1-caihuoqing@baidu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-09-21, 21:00, Cai Huoqing wrote: > The helper function devm_add_action_or_reset() will internally > call devm_add_action(), and gif devm_add_action() fails then it will > execute the action mentioned and return the error code. So > use devm_add_action_or_reset() instead of devm_add_action() > to simplify the error handling, reduce the code. Applied, thanks -- ~Vinod