Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1224894pxb; Fri, 1 Oct 2021 06:18:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMPaj/g4zOPREosGaYo7lP9gDOdUlD6qx3N8bsxjVKNNMnccdpZbIM6vy8omYVdYTONOT0 X-Received: by 2002:a17:906:2506:: with SMTP id i6mr2037240ejb.186.1633094315693; Fri, 01 Oct 2021 06:18:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633094315; cv=none; d=google.com; s=arc-20160816; b=WzKur1flUhC/ie12xmqYuUXI3+R1/wJkFP2tVnhM5tnmagbyU7QxO0SUkC5StA/613 jO6d8YXgceaGBY+1dplmzIb4X8NHbtFFT4uT/s3ysNPg+U0v4/kYCT6JmCtmsQDBS+Rn I/iNWOSFAX6157z8Yl/IAVPHEVTGDI5iHEFF3cOg1j/fv8/y9mIrEGDtUMbdhU/oWeXP 4vB4MeZNcpO4xdS2uvQ4bqG23VlOaO9/RpOQGc0FA5WmhTlcltIxDuz/9fb+gt2YTwii JMmrl+fVVSCVB2hZylilfSsZicwYS6hOWSYNNP3aIB0sRfWXhXU81olSoMlmYVq/6Ycz whzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tLM81yc0/7+B7uHrmMgKEmO5b6UgFGAaiCJVMuEeJXM=; b=EzVc4Eir69xkZrLf8WoQelS5jF7OH5ZoFjTnKXjtt93nYJPd9w7h4+bo4A9NjhzgR4 sKt2LBw2CMoSuAq6veAE16XoHHFHTX5x2p9bW7yy8D+lIS3kkHTgrCyyCOzmnXWvdvQS Z1mL/bz9zrDSRhjKXVhH+S9VRI5ufsTwnDa6iqPi3NUkasx84RoF4zWNPFZK813ZbQmq H+66H+Da/dxbYP1LtzylNHBGX/fR5eV2z7U6jYz4X5rdp3b3KxYV0YXoj+zTOQiWic11 lIp68l0LYTRLJqshxz8HSF0g3OcFtCqVWDMwFjsJWpZPMzimYK00tewLvjLnFVwiHM2o bZEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Ml3NHsy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d12si6691292edx.556.2021.10.01.06.18.09; Fri, 01 Oct 2021 06:18:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Ml3NHsy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238647AbhJANAS (ORCPT + 99 others); Fri, 1 Oct 2021 09:00:18 -0400 Received: from mail.skyhub.de ([5.9.137.197]:38158 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230432AbhJANAR (ORCPT ); Fri, 1 Oct 2021 09:00:17 -0400 Received: from zn.tnic (p200300ec2f0e8e00c9205f48360a92d6.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:8e00:c920:5f48:360a:92d6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 326D41EC008F; Fri, 1 Oct 2021 14:58:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633093112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=tLM81yc0/7+B7uHrmMgKEmO5b6UgFGAaiCJVMuEeJXM=; b=Ml3NHsy7CUwTkPrFBFlA3X5jnQTTIVigF8AFuKzUJu+/yBEuWERTM1FzxWNdPoGh0e07xu 3MKpvdaOoqomyjfHk+HKYrnjcMljpN3s0N0IDgOtlQvBwitx2PF2f7RCu2GNvYDxAlQV2K AXemiTsJ3J7ZWPnVwAVqMpeIe7rSANk= Date: Fri, 1 Oct 2021 14:58:28 +0200 From: Borislav Petkov To: Joerg Roedel Cc: Tom Lendacky , linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Brijesh Singh Subject: Re: [PATCH] x86/sev: Fully map the #VC exception stacks Message-ID: References: <113eca80a14cd280540c38488fd31ac0fa7bf36c.1633063250.git.thomas.lendacky@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 01, 2021 at 01:50:24PM +0200, Joerg Roedel wrote: > Yeah, I think the right fix is to export cea_map_percpu_pages() and move > the cea_map_stack() macro to a header and use it to map the VC stacks. I'll do you one better: Put the #VC stack mapping into percpu_setup_exception_stacks(), where it naturally belongs and where the other stacks are being mapped instead of doing everything "by hand" like now and exporting random helpers. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette