Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932764AbWLSKcz (ORCPT ); Tue, 19 Dec 2006 05:32:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932763AbWLSKcz (ORCPT ); Tue, 19 Dec 2006 05:32:55 -0500 Received: from noname.neutralserver.com ([70.84.186.210]:20611 "EHLO noname.neutralserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932761AbWLSKcy (ORCPT ); Tue, 19 Dec 2006 05:32:54 -0500 Date: Tue, 19 Dec 2006 02:02:34 +0200 From: Dan Aloni To: Linux Kernel List Cc: linux-scsi@vger.kernel.org, Mike Christie Subject: [PATCH] scsi_execute_async() should add to the tail of the queue Message-ID: <20061219000234.GA5330@localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.13 (2006-08-11) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - noname.neutralserver.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - monatomic.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 34 Hello, scsi_execute_async() has replaced scsi_do_req() a few versions ago, but it also incurred a change of behavior. I noticed that over-queuing a SCSI device using that function causes I/Os to be starved from low-level queuing for no justified reason. I think it makes much more sense to perserve the original behaviour of scsi_do_req() and add the request to the tail of the queue. Signed-off-by: Dan Aloni diff -p -urN a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c --- a/drivers/scsi/scsi_lib.c 2006-12-19 01:48:50.000000000 +0200 +++ b/drivers/scsi/scsi_lib.c 2006-12-19 01:49:35.000000000 +0200 @@ -421,7 +421,7 @@ int scsi_execute_async(struct scsi_devic sioc->data = privdata; sioc->done = done; - blk_execute_rq_nowait(req->q, NULL, req, 1, scsi_end_async); + blk_execute_rq_nowait(req->q, NULL, req, 0, scsi_end_async); return 0; free_req: -- Dan Aloni XIV, http://www.xivstorage.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/