Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 21:22:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Orlando Chamberlain <redecorating@protonmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Add support for MacBookPro16,2 UART
Message-ID: <YVdR4bdpr9/E+GNf@smile.fi.intel.com>
References: <20211001084905.4133-1-redecorating@protonmail.com>
 <YVbf9J3jgAmBY+ch@smile.fi.intel.com>
 <YVdP9PwNrjmKxKac@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YVdP9PwNrjmKxKac@google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Oct 01, 2021 at 07:14:12PM +0100, Lee Jones wrote:
> On Fri, 01 Oct 2021, Andy Shevchenko wrote:
> > On Fri, Oct 01, 2021 at 08:51:46AM +0000, Orlando Chamberlain wrote:

...

> > > +	/* MacBookPro16,2 */
> > 
> > Use
> > 
> > 	/* ICL-N */
> > 
> > here.
> 
> Why is that?

It's a standard way of representing PCH/SoC in the comments in this driver:
- MacBookPro16,2 is not a name of the PCH/SoC
- MacBookPro16,2 is possible not the solely hardware of this chip

Why not to mention this name in the commit message?

-- 
With Best Regards,
Andy Shevchenko