Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] scsi: ufs: Stop clearing unit attentions
To:     dgilbert@interlog.com, Adrian Hunter <adrian.hunter@intel.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, martin.petersen@oracle.com
Cc:     Bart Van Assche <bvanassche@google.com>
References: <20210930195237.1521436-1-jaegeuk@kernel.org>
 <20210930195237.1521436-2-jaegeuk@kernel.org>
 <12ba3462-ac6b-ef35-4b5e-e0de6086ab51@intel.com>
 <f2436720-16d5-58da-abcc-20fa1ed01fb9@intel.com>
 <5e087a0f-7ae0-41d1-c1f1-e5cc0ad2d38f@acm.org>
 <f4f81b75-9b0b-7734-ebfa-14bd1b935c54@interlog.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <07821a06-0b51-8f11-868c-913726ee393a@acm.org>
Date:   Fri, 1 Oct 2021 10:40:24 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <f4f81b75-9b0b-7734-ebfa-14bd1b935c54@interlog.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/1/21 10:21 AM, Douglas Gilbert wrote:
> On 2021-10-01 12:59 p.m., Bart Van Assche wrote:
>> On 9/30/21 11:52 PM, Adrian Hunter wrote:
>>> Finally, there is another thing to change.  The reason
>>> ufshcd_suspend_prepare() does a runtime resume of sdev_rpmb is because the
>>> UAC clear would wait for an async runtime resume, which will never happen
>>> during system suspend because the PM workqueue gets frozen.  So with the
>>> removal of UAC clear, ufshcd_suspend_prepare() and ufshcd_resume_complete()
>>> should be updated also, to leave rpmb alone.
> 
> Somewhat related ...
> 
> Since there was some confusion among the members of T10 of what precisely
> the RPM bit meant, in SPC-6 revision (draft), a new "HOT PLUGGABLE" two
> bit field was introduced into the standard INQUIRY response:
> 
>                  Table 151 — HOT PLUGGABLE field
> 
> Code   Description
> 00b    No information is provided regarding whether SCSI target device is hot
>         pluggable.
> 01b    The SCSI target device is designed to be removed from a SCSI domain as
>         a single object (i.e., concurrent removal of the SCSI target ports,
>         logical units, and all other objects contained in that SCSI target
>         device (see SAM-6)) while that SCSI domain continues to operate for
>         all other SCSI target devices, if any, in that SCSI domain.
> 10b    The SCSI target device is not designed to be removed from a SCSI
>         domain while that SCSI domain continues to operate.
> 11b    Reserved
> 
> That field is bits 5 and 4 of byte 1 of the response.
> 
> Perhaps we should be adding provision for this new field.

Hi Doug,

It is not clear to me how hot-plugging is related to UFS devices? I am not aware
of any support for hot-plugging in the UFS driver. RPMB = Replay Protected Memory
Block. The definition of RPMB according to Wikipedia is "a means for a system to
store data to the specific memory area in an authenticated and replay protected
manner, and can only be read and written via successfully authenticated read and
write accesses". It is not clear to me how hot-plugging and RPMB are related? What
am I missing?

Thanks,

Bart.