Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1514344pxb; Fri, 1 Oct 2021 12:18:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+cR8GAVsWungvzkdU8Q5/lYt0xJYhWRYxVsszOYW7fkbGbw/grpFy6RvgsQO4f0/DaptZ X-Received: by 2002:a17:907:1b1b:: with SMTP id mp27mr8148907ejc.538.1633115883324; Fri, 01 Oct 2021 12:18:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633115883; cv=none; d=google.com; s=arc-20160816; b=O9MtHrfgf7JQZ+ntJwBXRkAEVhmcI9Knz/5ibFxas+Ho/aKVPnKiS7cbVVm0jwMTql 8GAL2GvSq2vZbygR+JFUfIbBUiHs+6b7vlRnzSRAcTkeiFp+5yohvqbhGUWLrbsbCKgn yUmHTHuKGW71IsOLyAL3m8twLZ0UNDLt/fIdMsezc5CLUs0aA09ajP1UquoA92C0sQGd HvTB2oubnsevPUFN33fWsyIpox5ZLlQViHZnIfUgff28gr8XIW0r/v9cxCz2XS/d++nk /o/H/M+JL0rIblKshA4UM366Kphn+HTKXup0zCJw0+M2595UR70mMEgjH3uxgdkRsuYR WCRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Cgb1fv9bVHuTkgMTj6y+AuXZB8St2QvICjLbrmVDGMY=; b=OXP/u6e9wnJs0ycIvXZS9mPOyBGvHUqjKpTrFD+1xl5tpwJVsbCHDv24j28sWii1sx QsYRSjpfXZifI1A5ihPKEGLE4V8LMqKVxoWWyhNrHJDjDV7YPkqkqN5JN8E5bGHh9rpa eMMIlTaLMRjkwJpEuFIacUsNCrVwAPKMZL1BByOkNAREOt+t6nxvSE4iak4KsefqfxE6 joevIpOFvzZ9WAK4WzfYtjpzpxpyuVv5So9+D7z4OIDmdEISxET3tOgqLgAGT64rpDh1 yhwiw1c/6iBZqbv/mu+voQlBEWFEvVjWaAUXli3BPoczjd14IlXwFAZn2CT1iAYNZdtl FABw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zm3si8877957ejb.363.2021.10.01.12.17.37; Fri, 01 Oct 2021 12:18:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355969AbhJATDP (ORCPT + 99 others); Fri, 1 Oct 2021 15:03:15 -0400 Received: from mga04.intel.com ([192.55.52.120]:30129 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355327AbhJATDO (ORCPT ); Fri, 1 Oct 2021 15:03:14 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10124"; a="223640002" X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="223640002" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 12:00:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,339,1624345200"; d="scan'208";a="619340954" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga001.fm.intel.com with SMTP; 01 Oct 2021 12:00:51 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 01 Oct 2021 22:00:50 +0300 Date: Fri, 1 Oct 2021 22:00:50 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sean Paul Cc: Fernando Ramos , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible Message-ID: References: <20210924064324.229457-1-greenfoo@u92.eu> <20211001183655.GW2515@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211001183655.GW2515@art_vandelay> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 01, 2021 at 02:36:55PM -0400, Sean Paul wrote: > On Fri, Sep 24, 2021 at 08:43:07AM +0200, Fernando Ramos wrote: > > Hi all, > > > > One of the things in the DRM TODO list ("Documentation/gpu/todo.rst") was to > > "use DRM_MODESET_LOCAL_ALL_* helpers instead of boilerplate". That's what this > > patch series is about. > > > > You will find two types of changes here: > > > > - Replacing "drm_modeset_lock_all_ctx()" (and surrounding boilerplate) with > > "DRM_MODESET_LOCK_ALL_BEGIN()/END()" in the remaining places (as it has > > already been done in previous commits such as b7ea04d2) > > > > - Replacing "drm_modeset_lock_all()" with "DRM_MODESET_LOCK_ALL_BEGIN()/END()" > > in the remaining places (as it has already been done in previous commits > > such as 57037094) > > > > Most of the changes are straight forward, except for a few cases in the "amd" > > and "i915" drivers where some extra dancing was needed to overcome the > > limitation that the DRM_MODESET_LOCK_ALL_BEGIN()/END() macros can only be used > > once inside the same function (the reason being that the macro expansion > > includes *labels*, and you can not have two labels named the same inside one > > function) > > > > Notice that, even after this patch series, some places remain where > > "drm_modeset_lock_all()" and "drm_modeset_lock_all_ctx()" are still present, > > all inside drm core (which makes sense), except for two (in "amd" and "i915") > > which cannot be replaced due to the way they are being used. > > > > Changes in v2: > > > > - Fix commit message typo > > - Use the value returned by DRM_MODESET_LOCK_ALL_END when possible > > - Split drm/i915 patch into two simpler ones > > - Remove drm_modeset_(un)lock_all() > > - Fix build problems in non-x86 platforms > > > > Fernando Ramos (17): > > drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/i915: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() drm/vmwgfx: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/shmobile: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/nouveau: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() part 2 > > drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() > > drm: cleanup: remove drm_modeset_(un)lock_all() > > doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup > > > > Thank you for revising, Fernando! I've pushed the set to drm-misc-next (along > with the necessary drm-tip conflict resolutions). Ugh. Did anyone actually review the locking changes this does? I shot the previous i915 stuff down because the commit messages did not address any of it. -- Ville Syrj?l? Intel