Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1635881pxb; Fri, 1 Oct 2021 15:34:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8uKBdRc6VDq2TQP7upUtAGNoTaiL1WCi5/ULQyyBV/0i6WJJiksIfZYctwgbMPYpiRVxr X-Received: by 2002:a17:90a:2ecb:: with SMTP id h11mr16018828pjs.196.1633127698487; Fri, 01 Oct 2021 15:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633127698; cv=none; d=google.com; s=arc-20160816; b=Varc88GJCxTPW17iuSeNpuv4GWFCnGOn9HShFB9Bd5VQDy9pmQ4UzCt0/OO+k4+7+H e/lMMfRgAYBVIYzxH+pKmkdpHyy7VNim2R52vBd3IShW1g6oCI+sZq8ZQyDAtJGLjoDs 11/1/Rb6DAlnu6iWjiQnV/0irYjdfy96AhfGXT4msHyHmLF5hM2KN8fR9GSnYUhFiOKi pwKVrchNwcqWgrVs5Bntq47wwlTzW8a8FkqSRk9/ny4jW1UUAP4YHi+SbcmU0JRbpAss y4BD2rfPGsWolp4zO/qZwuAgdxOvotM+YuLGiHlVbLQGFNy6ZJg9DU9Qwuxva1MuTAww mh1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+8IKtMaCVQ+JXaAvMN15Sl0zFef2Kdk/JGGA0JXWEZ4=; b=bx9+vgoypkAQA9fihliWdR+yqvbc6APItH7SyR6sC8vMPFv36+7olPyPZuzAofxe6Y dfwY0S8C0hqsFCb1/9rNB5jk9gF8Xe4sSy651Su0GZ1uLEoDsBrLFPNtxT+O+UQ1zHzp K/E54AnX051x742LUEwJRFAhXJ6TSChTpJk9PyacQq1sidk2egzALtO+B5+/Fh0M4mps 8128noBjKC8ycua3smeBRztU8yRAnEUGBi23JVZO3MqFowvmeQFdXXYKhzkhKElhebQW bLKECJq9m/bg6scMMqbzbeh0YRr3rgSgIK/znU0Yl/mK8TDYTXL02MhlarQxiinM3hXL XT7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 75si8881766pga.225.2021.10.01.15.34.42; Fri, 01 Oct 2021 15:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355213AbhJAVbb (ORCPT + 99 others); Fri, 1 Oct 2021 17:31:31 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:45259 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbhJAVba (ORCPT ); Fri, 1 Oct 2021 17:31:30 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 66E0FE0006; Fri, 1 Oct 2021 21:29:43 +0000 (UTC) From: Alexandre Belloni To: linux-rtc@vger.kernel.org, Colin King , Romain Perier , Nobuhiro Iwamatsu , linux-arm-kernel@lists.infradead.org, Daniel Palmer Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH][next][V2] rtc: msc313: Fix unintentional sign extension issues with left shift of a u16 Date: Fri, 1 Oct 2021 23:29:41 +0200 Message-Id: <163312374938.6051.17877024620555330727.b4-ty@bootlin.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210928134654.991923-1-colin.king@canonical.com> References: <20210928134654.991923-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Sep 2021 14:46:54 +0100, Colin King wrote: > From: Colin Ian King > > Shifting the u16 value returned by readw by 16 bits to the left > will be promoted to a 32 bit signed int and then sign-extended > to an unsigned long. If the top bit of the readw is set then > the shifted value will be sign extended and the top 32 bits of > the result will be set. > > [...] Applied, thanks! [1/1] rtc: msc313: Fix unintentional sign extension issues with left shift of a u16 commit: f3606687b447c41d28a011c98373b62b1cd52345 Best regards, -- Alexandre Belloni