Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1641519pxb; Fri, 1 Oct 2021 15:45:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxb5vNhLzIl+jEFj4w/cUQmUq777NwkJdQQhz9/KivgQrP+QrTIUxOA/coU7pq7DrZ/2hEu X-Received: by 2002:a50:cfcd:: with SMTP id i13mr177578edk.24.1633128339091; Fri, 01 Oct 2021 15:45:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633128339; cv=none; d=google.com; s=arc-20160816; b=EmPMJjDdxn08669d808SF7uM4qzHAMrwu9C8HkmilL4J9QQl+1Maub8UUUgW0Vk0GZ 2a/0rsfHnqBe5f7OfOy3LRmnsPoI9gUphN17TykXWT3XG0BXoxJNr88C+7zjGF1CosOJ unUOpfgp1PxZrQfWUBosr7E/tcy1blZsSQvSJ+CIes5LBHeO65REJK6Zt9zBdu+spOfo k6psTf4jzLSvyuBMcLC1IctRTHQw/trjvaF4GN5C6thHVY5inX3MIcwpPR0/Zi9bJ/HK w5IV9rkef7yzoCjALS0Xff2tkjTKRPZTQZg5Cdxx+DZAecXTgXSWGKzTecfZZ76BU+0B OGmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=XXgMIfOKyq97KypYEc7j/J6+r5ZXueX7YTNTMv8Ua2k=; b=MRk2GRcxgNEwLcOtHE/gEtGhKIiH9iZnQbhNVxufkjoeH9pPScz7HlIgw+BFBI33+S EyUiGw8BD8aXDSlt2pZ6OklH6/nRThV4T43iVY79qVdzOK/kMgK+R08bhp/ja0XplRR7 qP4oO+QHNlogPXqoBF7RXbgMPEybpl03qyPNUwsyLozHOAWlPNTHcs6In8Ij/Rem/G0p 4pADv+SmaEL2Da+53+PaQRx3MMfCcTRy4fp/HAdpW61mUpgMESKWrKBZOB9JpFBjbs2o EBSlL/S+Fn2f1tR0Q206OkH4tbp4pq6wJlYjAHVPkYTo9RASiOW9jx4rVYTQdXgdZwGF HY0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GP6c6KY/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hx14si6238793ejc.326.2021.10.01.15.45.13; Fri, 01 Oct 2021 15:45:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GP6c6KY/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbhJAWhw (ORCPT + 99 others); Fri, 1 Oct 2021 18:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbhJAWhu (ORCPT ); Fri, 1 Oct 2021 18:37:50 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDBB1C06177E for ; Fri, 1 Oct 2021 15:36:05 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id m3so43656394lfu.2 for ; Fri, 01 Oct 2021 15:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XXgMIfOKyq97KypYEc7j/J6+r5ZXueX7YTNTMv8Ua2k=; b=GP6c6KY/Hlx3hOXso9m3i2E+F1E0V2AdrpKUg8AEQxKtOaY+FO58/XnO0SKfPDMHr8 iw+SY3OJmPMlUpQXaXWLKiprCx1hAZotQVTx82SdjQzQ1yy3jU1k/2bKNoSGNCVcQxoy zX3f1jIyTnXX4WW7L7D5qoP/YqCjZuo2ZbkpENj+Mdj9pZRgxgSMKMNNoaqVB8gXNXkZ FgwyFwAowACaKNNE6fyqzDpJVfaxn3AZzdA6K1pyzmFYNvu04m6Kev5k2MR/Uny1e/AW 8u2TBcePVhtki9Qk+gsuNFQ/r7pvLwuDMOEfJxdrovAdX7y9QMlcntbhven5PDXzvbtk 7yyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XXgMIfOKyq97KypYEc7j/J6+r5ZXueX7YTNTMv8Ua2k=; b=6/SkI96veXmOLg0cyjFQ+j8jzeE5cWP9S6E5/EdzuIEdYj7i/lcF4AUdkuefhy3cmd srT0CeSLcd4LAgklF+mJQlc9qsSXeaKt9L3fpE3TOh8jaYN4Cr11GhkcVr9UYdWg4BSe VGehdYIT9EA7ldCjHUatkV6CaMT3cuWF+T2ASXLkCLIZRE6YeZv+M3CgKQvsxx9oxkkl /qpIyg4fcfG8/mzeFT7nuBfxbNC1oCByhHc+Gnum+MPELWTGcfmptiE5eCthLyMeH5F6 rL6NTUkOPk4hMYjROLgnbzeO6lbqXsIM+76C0AAIupHcQTM0Pcycnmeja52dqoTAgAgM SoxQ== X-Gm-Message-State: AOAM532MurxgORBMOYMUaH/GXHxbD81hWyj9RV4vwLa9IntM0eKywjlb Q1xONrVkLLLs9SsdEexscnmwlNxURbT8lQ== X-Received: by 2002:a05:651c:150b:: with SMTP id e11mr509102ljf.289.1633127763821; Fri, 01 Oct 2021 15:36:03 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id x15sm584308lfe.129.2021.10.01.15.36.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 15:36:03 -0700 (PDT) Subject: Re: [PATCH v2] drm: msm: adreno_gpu.c: Add and use pr_fmt(fmt) To: zhaoxiao , robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: jordan@cosmicpenguin.net, saiprakash.ranjan@codeaurora.org, jonathan@marek.ca, airlied@redhat.com, smasetty@codeaurora.org, konrad.dybcio@somainline.org, akhilpo@codeaurora.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20210826022316.9559-1-zhaoxiao@uniontech.com> From: Dmitry Baryshkov Message-ID: Date: Sat, 2 Oct 2021 01:36:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210826022316.9559-1-zhaoxiao@uniontech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/08/2021 05:23, zhaoxiao wrote: > Use a more common logging style. > > Signed-off-by: zhaoxiao Your subject tells about pr_fmt(), while the patch itself changs printk()s to pr_info(). Could you please fix the commit subject and expand/correct commit message? > --- > v2:Remove the line: #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > drivers/gpu/drm/msm/adreno/adreno_gpu.c:23:9: warning: 'pr_fmt' macro redefined [-Wmacro-redefined] > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > ^ > include/linux/printk.h:348:9: note: previous definition is here > #define pr_fmt(fmt) fmt > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index 9f5a30234b33..f10e9e04c13b 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -753,7 +753,7 @@ void adreno_dump_info(struct msm_gpu *gpu) > struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu); > int i; > > - printk("revision: %d (%d.%d.%d.%d)\n", > + pr_info("revision: %d (%d.%d.%d.%d)\n", > adreno_gpu->info->revn, adreno_gpu->rev.core, > adreno_gpu->rev.major, adreno_gpu->rev.minor, > adreno_gpu->rev.patchid); > @@ -761,12 +761,12 @@ void adreno_dump_info(struct msm_gpu *gpu) > for (i = 0; i < gpu->nr_rings; i++) { > struct msm_ringbuffer *ring = gpu->rb[i]; > > - printk("rb %d: fence: %d/%d\n", i, > + pr_info("rb %d: fence: %d/%d\n", i, > ring->memptrs->fence, > ring->seqno); > > - printk("rptr: %d\n", get_rptr(adreno_gpu, ring)); > - printk("rb wptr: %d\n", get_wptr(ring)); > + pr_info("rptr: %d\n", get_rptr(adreno_gpu, ring)); > + pr_info("rb wptr: %d\n", get_wptr(ring)); > } > } > > @@ -780,7 +780,7 @@ void adreno_dump(struct msm_gpu *gpu) > return; > > /* dump these out in a form that can be parsed by demsm: */ > - printk("IO:region %s 00000000 00020000\n", gpu->name); > + pr_info("IO:region %s 00000000 00020000\n", gpu->name); > for (i = 0; adreno_gpu->registers[i] != ~0; i += 2) { > uint32_t start = adreno_gpu->registers[i]; > uint32_t end = adreno_gpu->registers[i+1]; > @@ -788,7 +788,7 @@ void adreno_dump(struct msm_gpu *gpu) > > for (addr = start; addr <= end; addr++) { > uint32_t val = gpu_read(gpu, addr); > - printk("IO:R %08x %08x\n", addr<<2, val); > + pr_info("IO:R %08x %08x\n", addr<<2, val); > } > } > } > -- With best wishes Dmitry