Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932106AbWLSOcS (ORCPT ); Tue, 19 Dec 2006 09:32:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932178AbWLSOcS (ORCPT ); Tue, 19 Dec 2006 09:32:18 -0500 Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10]:47822 "EHLO pd2mo3so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106AbWLSOcR (ORCPT ); Tue, 19 Dec 2006 09:32:17 -0500 Date: Tue, 19 Dec 2006 08:32:04 -0600 From: Robert Hancock Subject: Re: Linux 2.6.20-rc1 In-reply-to: <20061219124130.GN5010@kernel.dk> To: Jens Axboe Cc: Alistair John Strachan , Jeff Garzik , Linus Torvalds , Linux Kernel Mailing List Message-id: <4587F7E4.8000609@shaw.ca> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit References: <200612142144.26023.s0348365@sms.ed.ac.uk> <4581C73F.6060707@garzik.org> <200612142233.10584.s0348365@sms.ed.ac.uk> <20061219124130.GN5010@kernel.dk> User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 30 Jens Axboe wrote: > Just noticed that most of the mails I wrote on this thread were > apparently without linux-kernel cc'ed (dunno who removed the cc). So > I'll write a small summary - the problem is that hddtemp includes some > fragile code to check the sense info, and this commit: > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=f38621b3109068adc8430bc2d170ccea59df4261 > > broke it. hddtemp expects 14, but it now sees 12. IMHO hddtemp is buggy > and should be fixed, the best option is simply to kill the sense checks > as I think they have little (if any) value. Patch below for that. > > So the problem was never the SG_IO changes, the fact that somebody > noticed the same thing in bugzilla for a 2.6.19-rc6-mm kernel backs that > up. From what I've seen it appears that smartctl has the same problem, it was also reporting the device didn't support SMART.. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/