Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932820AbWLSOtF (ORCPT ); Tue, 19 Dec 2006 09:49:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932825AbWLSOtF (ORCPT ); Tue, 19 Dec 2006 09:49:05 -0500 Received: from brick.kernel.dk ([62.242.22.158]:6378 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932820AbWLSOtE (ORCPT ); Tue, 19 Dec 2006 09:49:04 -0500 Date: Tue, 19 Dec 2006 15:50:46 +0100 From: Jens Axboe To: Robert Hancock Cc: Alistair John Strachan , Jeff Garzik , Linus Torvalds , Linux Kernel Mailing List Subject: Re: Linux 2.6.20-rc1 Message-ID: <20061219145045.GY5010@kernel.dk> References: <200612142144.26023.s0348365@sms.ed.ac.uk> <4581C73F.6060707@garzik.org> <200612142233.10584.s0348365@sms.ed.ac.uk> <20061219124130.GN5010@kernel.dk> <4587F7E4.8000609@shaw.ca> <20061219143815.GW5010@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061219143815.GW5010@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1415 Lines: 33 On Tue, Dec 19 2006, Jens Axboe wrote: > On Tue, Dec 19 2006, Robert Hancock wrote: > > Jens Axboe wrote: > > >Just noticed that most of the mails I wrote on this thread were > > >apparently without linux-kernel cc'ed (dunno who removed the cc). So > > >I'll write a small summary - the problem is that hddtemp includes some > > >fragile code to check the sense info, and this commit: > > > > > >http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=f38621b3109068adc8430bc2d170ccea59df4261 > > > > > >broke it. hddtemp expects 14, but it now sees 12. IMHO hddtemp is buggy > > >and should be fixed, the best option is simply to kill the sense checks > > >as I think they have little (if any) value. Patch below for that. > > > > > >So the problem was never the SG_IO changes, the fact that somebody > > >noticed the same thing in bugzilla for a 2.6.19-rc6-mm kernel backs that > > >up. > > > > From what I've seen it appears that smartctl has the same problem, it > > was also reporting the device didn't support SMART.. > > Can you check whether reverting the above commit makes SMART work again? smartctl fine for me, with and without the patch. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/