Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 Oct 2021 17:01:03 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Waiman Long <longman@redhat.com>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
        <linux-mm@kvack.org>, Shakeel Butt <shakeelb@google.com>,
        Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH 2/3] mm, memcg: Remove obsolete memcg_free_kmem()
Message-ID: <YVehP18mCcsXmFy1@carbon.dhcp.thefacebook.com>
References: <20211001190938.14050-1-longman@redhat.com>
 <20211001190938.14050-3-longman@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211001190938.14050-3-longman@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?29zsu40KTs0IPPKoo7b/hFgnlJyjBcgr/i0OxX6woENFXjVcaDLbe6uilxwP?=
 =?us-ascii?Q?PHquNDEhZSJLtciIJ6Jh1vSs1vcXa/kQV745UgQypMM7y7ZUPGvypPSxlHPi?=
 =?us-ascii?Q?+DEGd0KSSaOuvetR+CDfJ2mVUQStw49tJbj2tg0nE4FQJOb9ZwpGF7WMQgUQ?=
 =?us-ascii?Q?woITU4N+ry57djScWuGDTS+8dXLTJSaRr0K59jgQslxcZY4pN8fUC4nqUM55?=
 =?us-ascii?Q?4w9pRW7oc9VFromQmsPW2gUjHJxgQr1k5AkL+Qo6ntAAQCNLZYv9yyxdTcO+?=
 =?us-ascii?Q?gttSVkvwF1pf13z0H/xhKZaegKl3oWB9/NKg3iu/lJ+E9VLUSVjresDhXvhN?=
 =?us-ascii?Q?qhMwOu+aQ9BekHYSH6GX0GKlmOJ3+NKPysHyYbdfYEwLFhD6oPEFd8PBb2tP?=
 =?us-ascii?Q?/YuPOeikw6PYvH3u7/6RDCfKqBl1X+aHbogBo8UtGrAO9trZYxzkOwvgn6Vw?=
 =?us-ascii?Q?wqlqRN8esD6A7KuqWqO1thS2+JZ3BByIJ7dPuuAv+SVai9Z6nrDc276bS0bw?=
 =?us-ascii?Q?Atab9DYct8GrQT2qYXa2pGt5G43v1SWwl8aX+M6/XpJTP7esMm13Eqv3Nmqd?=
 =?us-ascii?Q?ZCQ2DOcw9GajFa3gsRaQQdTyVVOngxSN9fXRchD2QLw7mxH4jmYqjN9EQlkO?=
 =?us-ascii?Q?ChBPcObMvwSBV0s1mbTWbdA6QkrCxgcyt+k71Vu9yLdT69s4XVbV2KwJRLcy?=
 =?us-ascii?Q?Tj3JPwQjvSHzY60DVvgYu3Nt7WxgydkLFjqvBKOxD2KvkRbf9eAQWNKzCBcT?=
 =?us-ascii?Q?v2c2MBzZxX0YfJRn/rNmzbEnpASlc+StZWmo1xCbA10UqdJruPljPihpkuTv?=
 =?us-ascii?Q?F44dN7KUnXcaNJXcesesGTNTN5t1fJglG+xCYqwpv45EMami3ez6ZXDtyzH4?=
 =?us-ascii?Q?XgRwxXEGmgpGzN3Rs/Da9dBMeRp5gchQTTwzaWAHyDFRrfYQuT92rtk8NZjO?=
 =?us-ascii?Q?488OIiTFQeplEamPvqZqGu6vgIUtOj+fEmAfsiZwlbFZ3QOBz936glH8BdNT?=
 =?us-ascii?Q?4kr9VGdRP9i78vIY77d3M+p29qaqaHhEP+9hH95GmczXRF9QISxP7GKHHvpx?=
 =?us-ascii?Q?JkiGJuHF+i20pZFzN7dbUAVSUO9AA+p+EOf+yt+0qvT4tncFPencaYiH147/?=
 =?us-ascii?Q?IBDep9i9aF/XCZPWJaZbNZsDgAsujpisOd4yxBDcRR+4uM24ff0ZAzjozspS?=
 =?us-ascii?Q?VcXJBEZ8YSjGE/PEarlHYLb7JxAT5UDfsVXzq+Z2+wOgG6HQUC1cEGrHxp5b?=
 =?us-ascii?Q?aATMX2aZVCeBcO/SlLMSGqrTlK1YLgZOivNQSqBRAMF7EieVlXmvs9kQTCRB?=
 =?us-ascii?Q?TQDQ+aCeoyQHle5FIGBUGIfNwZO3NDu8+rKRCPft7Kyn6w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b5d35de-5eb2-4437-d65a-08d98537bb85
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2021 00:01:06.7090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ufE/40Q2RsT1y7U2fgOGL03yelb8Uc94v5JNf4kK3g8+yPeZ8qn5gyqGwVcSQ4Ko
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3480
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: YBhHUXRzzF9_lJNYnKgDI_RHiu_M1n0n
X-Proofpoint-GUID: YBhHUXRzzF9_lJNYnKgDI_RHiu_M1n0n
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-01_05,2021-10-01_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 adultscore=0
 clxscore=1015 lowpriorityscore=0 impostorscore=0 mlxlogscore=912
 malwarescore=0 phishscore=0 mlxscore=0 priorityscore=1501 spamscore=0
 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110010167
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 01, 2021 at 03:09:37PM -0400, Waiman Long wrote:
> Since commit d648bcc7fe65 ("mm: kmem: make memcg_kmem_enabled()
> irreversible"), the only thing memcg_free_kmem() does is to call
> memcg_offline_kmem() when the memcg is still online. However,
> memcg_offline_kmem() is only called from mem_cgroup_css_free() which
> cannot be reached if the memcg hasn't been offlined first.

Hm, is it true? What if online_css() fails?

> As this
> function now serves no purpose, we should just remove it.

It looks like we can just use memcg_offline_kmem() instead of
memcg_free_kmem().

Thanks!

> 
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
>  mm/memcontrol.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 4568363062c1..8177f253a127 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3673,13 +3673,6 @@ static void memcg_offline_kmem(struct mem_cgroup *memcg)
>  
>  	memcg_free_cache_id(kmemcg_id);
>  }
> -
> -static void memcg_free_kmem(struct mem_cgroup *memcg)
> -{
> -	/* css_alloc() failed, offlining didn't happen */
> -	if (unlikely(memcg->kmem_state == KMEM_ONLINE))
> -		memcg_offline_kmem(memcg);
> -}
>  #else
>  static int memcg_online_kmem(struct mem_cgroup *memcg)
>  {
> @@ -3688,9 +3681,6 @@ static int memcg_online_kmem(struct mem_cgroup *memcg)
>  static void memcg_offline_kmem(struct mem_cgroup *memcg)
>  {
>  }
> -static void memcg_free_kmem(struct mem_cgroup *memcg)
> -{
> -}
>  #endif /* CONFIG_MEMCG_KMEM */
>  
>  static int memcg_update_kmem_max(struct mem_cgroup *memcg,
> @@ -5325,7 +5315,6 @@ static void mem_cgroup_css_free(struct cgroup_subsys_state *css)
>  	cancel_work_sync(&memcg->high_work);
>  	mem_cgroup_remove_from_trees(memcg);
>  	free_shrinker_info(memcg);
> -	memcg_free_kmem(memcg);
>  	mem_cgroup_free(memcg);
>  }
>  
> -- 
> 2.18.1
>