Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1873216pxb; Fri, 1 Oct 2021 23:42:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJxhD6n0bGiniZN5XrTtYu+DCAjDsRnu7dYyiLHKdAjl6YthWCzCjy6NN1PHby1sdxFFaw X-Received: by 2002:a17:90a:1a4c:: with SMTP id 12mr17754181pjl.175.1633156971292; Fri, 01 Oct 2021 23:42:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633156971; cv=none; d=google.com; s=arc-20160816; b=cFwOltyYkqUa5a5nDO4FvrzXqMQXNPEWK4EGPTMGKX7tT56LOKsP4HmoJP8lR98Uln YawOaJT1m9ODdnYcbThVepfYB4fPKDH6hvUcAD8TjyseXVZjPzdEkiJpLs8k9KngnehJ yw/mcCbFCPM7fD/YAEZfzPy4hYNd3BODANt5CiKz0SE23mu+9gxJ/tg39uMtiG2gAHp6 x/IPCi8WF1FYBBOAQTyX7rYuTtGN0NL0IGcpavcnckTiM9RVUJTiII+aSnjumnaVijde 4RQpENnimDnwLl4MfHz7OmeX/Ph+BAKJd4OQzid84IRhhDf5Qy0EcKlV+t4hi4q5kqOP +mRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date; bh=7qHEOE60pozyogRjMArBd6A0V/Yav2hAUuwajRMla2c=; b=WWiRAK0nxT+ixpRDMpacO7A3M0OwxOEzLZdKYJ9XohDhluYkPmPbB3xNttYJcga/W/ r/N8iBxnLPuBQWYRn0AhDyWqktBa3T+75ruYSWb5OEX0p5ViuzBqPvPcLz8fL62hgm+y vHnPSTDVxgxEg9QoBCslDw6nwpcHNk+2nI9uLVn0MJUn7+6e8rKkvLSUM9WtauZGhIfl +OoxeiIQkM0aZhX9EfklYDQpxLsZl7oHRt1z0xVllqpl67MoY11kb8CMOuLZYFkd7lVP C7BiGGFve0IaZj/DYbTDruIawrvFo+++wCz38ErBrL3VKsrFUSymLBXi6u1IP21ovATE 6fAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si10421642pgs.218.2021.10.01.23.42.38; Fri, 01 Oct 2021 23:42:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232450AbhJBGcZ (ORCPT + 99 others); Sat, 2 Oct 2021 02:32:25 -0400 Received: from sauhun.de ([88.99.104.3]:34950 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232082AbhJBGcY (ORCPT ); Sat, 2 Oct 2021 02:32:24 -0400 Received: from localhost (p5486c558.dip0.t-ipconnect.de [84.134.197.88]) by pokefinder.org (Postfix) with ESMTPSA id 16A332C01E6; Sat, 2 Oct 2021 08:30:38 +0200 (CEST) Date: Sat, 2 Oct 2021 08:30:37 +0200 From: Wolfram Sang To: Kewei Xu Cc: matthias.bgg@gmail.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, leilk.liu@mediatek.com, qii.wang@mediatek.com, liguo.zhang@mediatek.com, caiyu.chen@mediatek.com, ot_daolong.zhu@mediatek.com, yuhan.wei@mediatek.com Subject: Re: [PATCH v7 2/7] i2c: mediatek: Reset the handshake signal between i2c and dma Message-ID: Mail-Followup-To: Wolfram Sang , Kewei Xu , matthias.bgg@gmail.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, leilk.liu@mediatek.com, qii.wang@mediatek.com, liguo.zhang@mediatek.com, caiyu.chen@mediatek.com, ot_daolong.zhu@mediatek.com, yuhan.wei@mediatek.com References: <20210917101416.20760-1-kewei.xu@mediatek.com> <20210917101416.20760-3-kewei.xu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UvFvhvLUV2QKFT4X" Content-Disposition: inline In-Reply-To: <20210917101416.20760-3-kewei.xu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --UvFvhvLUV2QKFT4X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > +#define I2C_CLR_DEBUGCTR 0x0000 Hmm, I don't think that a macro to clear a register helps readability... > + mtk_i2c_writew(i2c, I2C_CLR_DEBUGCTR, OFFSET_DEBUGCTRL); ... + mtk_i2c_writew(i2c, 0, OFFSET_DEBUGCTRL); looks good to me. Anyhow, it is not a big issue. Let me know if you want to change it or keep it. --UvFvhvLUV2QKFT4X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmFX/I0ACgkQFA3kzBSg KbarWg/5AWa1p784FQB8L72nw+1vj1664TNbB4mDaDRNT748bnUy4ZrHl5XMROZi u+L3Kb6drKfBHX1iiTN7908T6dss/s6lGfOiGx7IsTJAoTVmZNoG58OpvCptg8gc xTlSls9twWk8S9sp/5LD/sRlsCLsbktcL8BZEP7FHWO9eNWhYNqLq/asy69kpnkO hbKKQ2F/Ne+fLiwubzeLHsdkNb6AQBjmMnAB4Wthnxitgfnn6XgEXp3vZEBiCce4 D4+VtUrNdG2sQXuwuXogtLAnOZMankq/b4o68EE1EloCCBcus98EnXrLHYvbKj8A 1fUxBpoHg0uA5RrKtcyVrrp3e5hpE5rBLimFYdi+NQdL4W7wN1KWmdYvF6y2NWGY i/9NazOqV0gep2cSRtH+KvpSP2jpAZyyTqFC5UGSK9BJJKl+E6hyS6+P9uj6Zos4 /yzLaW9Rk3Z13HAJQLzOmizdrCuFl3L+K+QnFDQCH2HRGhDJiOpV40SqHFWWUN+4 P9Zh2bAn71/S1+dHY1OldIHBEZaCwfY0ydfdhgn+nbrPLL8pI4AklJyJUiAUPiYC FrvB1wc4tcq2PEn/16fiwLuhrHWqNY83qw1MdNCGGBwIB+OEp47F3kQOtWznepou XecMzXpurwrvSS8IgUwPbY4X+XdN8FUCTbaqSaxbgr3LKMnC+gg= =UHsi -----END PGP SIGNATURE----- --UvFvhvLUV2QKFT4X--